Merge #145005

145005: sql: improve error message for creating type in pg_temp r=rafiss a=rafiss

We do not support temporary types. We don't support the syntax for it, but one other way users can try to do this is by specifying the pg_temp schema.

This patch adds a nicer error message when this is attempted, rather than the current behavior to show an internal assertion error.

fixes #142780
Release note: None

Co-authored-by: Rafi Shamim <[email protected]>

Author: craig[bot]

pkg/sql/create_type.go

@@ -8,6 +8,7 @@ package sql
 import (
 	"context"
 	"fmt"
+	"strings"
 
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/kv"
@@ -107,6 +108,14 @@ func (n *createTypeNode) startExec(params runParams) error {
 func resolveNewTypeName(
 	ctx context.Context, p *planner, name *tree.UnresolvedObjectName,
 ) (*tree.TypeName, catalog.DatabaseDescriptor, error) {
+	// Check that we are not creating in a temporary schema. To support this,
+	// we'd need to update the type descriptor to have an IsTemporary flag, and
+	// the temporary object cleaner would need to handle these.
+	if name.HasExplicitSchema() && strings.HasPrefix(name.Schema(), catconstants.PgTempSchemaName) {
+		return nil, nil, pgerror.Newf(pgcode.InvalidSchemaName,
+			"cannot create type %q in temporary schema", name.Object(),
+		)
+	}
 	// Resolve the target schema and database.
 	db, _, prefix, err := p.ResolveTargetObject(ctx, name)
 	if err != nil {

pkg/sql/logictest/testdata/logic_test/temp_table

@@ -481,3 +481,33 @@ statement ok
 DROP DATABASE database_108751 CASCADE
 
 subtest end
+
+# Verify that a good error message is returned for temporary types.
+subtest temp_type
+
+statement ok
+CREATE DATABASE database_142780
+
+statement ok
+USE database_142780
+
+statement ok
+SET experimental_enable_temp_tables = on
+
+statement error cannot create type "temp_type" in temporary schema
+CREATE TYPE pg_temp.temp_type AS (a int, b int);
+
+# Verify that the error message is also good if we create a temporary table first.
+statement ok
+CREATE TEMP TABLE temp_table_142780 (a int primary key, b int);
+
+statement error cannot create type "temp_type" in temporary schema
+CREATE TYPE pg_temp.temp_type AS (a int, b int);
+
+statement ok
+RESET database
+
+statement ok
+DROP DATABASE database_142780
+
+subtest end