asim: port over some trivial commits from prototype

This commit ports over some trivial changes from the mma prototype branch.

Epic: CRDB-25222
Release note: none

Author: wenyihu6

pkg/kv/kvserver/asim/metrics/series.go

@@ -17,7 +17,7 @@ func MakeTS(metrics [][]StoreMetrics) map[string][][]float64 {
 	}
 
 	stores := len(metrics[0])
-	// TODO(kvoli): Either begin resuing prometheus metric definitions with a
+	// TODO(kvoli): Either begin reusing prometheus metric definitions with a
 	// custom scraper or provide definitions for each metric available. These
 	// are partially duplicated with the cluster tracker.
 	ret["qps"] = make([][]float64, stores)

pkg/kv/kvserver/asim/state/load.go

@@ -39,10 +39,6 @@ func LoadEventQPS(le workload.LoadEvent) float64 {
 
 // ReplicaLoadCounter is the sum of all key accesses and size of bytes, both written
 // and read.
-// TODO(kvoli): In the non-simulated code, replica_stats currently maintains
-// this structure, which is rated. This datastructure needs to be adapated by
-// the user to be rated over time. In the future we should introduce a better
-// general pupose stucture that enables rating.
 type ReplicaLoadCounter struct {
 	WriteKeys  int64
 	WriteBytes int64

pkg/kv/kvserver/asim/state/parser_replica_placement.go

@@ -121,6 +121,9 @@ func ParseReplicaPlacement(input string) ReplicaPlacement {
 			}
 			// For matches[0] and stores[0], storeID will be 1.
 			storeID, _ := strconv.Atoi(parts[0][1:])
+			if storeID == 0 {
+				panic(fmt.Sprintf("unable to parse store id: %s", parts[0][1:]))
+			}
 			storeSet = append(storeSet, storeID)
 
 			// If the replica type or leaseholder is not specified, artificially

pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go

@@ -145,13 +145,16 @@ var runAsimTests = envutil.EnvOrDefaultBool("COCKROACH_RUN_ASIM_TESTS", false)
 //     constraints(violating) at the end of the evaluation.
 //
 //   - "setting" [replicate_queue_enabled=bool] [lease_queue_enabled=bool]
-//     [split_queue_enabled=bool] [rebalance_mode=<int>] [rebalance_interval=<duration>]
-//     [rebalance_qps_threshold=<float>] [split_qps_threshold=<float>]
+//     [split_queue_enabled=bool] [rebalance_interval=<duration>]
+//     [rebalance_mode=<int>] [split_qps_threshold=<float>]
 //     [rebalance_range_threshold=<float>] [gossip_delay=<duration>]
+//     [rebalance_objective=<int>]
 //     Configure the simulation's various settings. The default values are:
-//     rebalance_mode=2 (leases and replicas) rebalance_interval=1m (1 minute)
-//     rebalance_qps_threshold=0.1 split_qps_threshold=2500
-//     rebalance_range_threshold=0.05 gossip_delay=500ms.
+//     replicate_queue_enabled=true lease_queue_enabled=true
+//     split_queue_enabled=true rebalance_interval=1m (1 minute)
+//     rebalance_mode=2 (leases and replicas) split_qps_threshold=2500
+//     rebalance_range_threshold=0.05 gossip_delay=500ms rebalance_objective=0
+//     (QPS) (1=CPU)
 //
 //   - "eval" [duration=<string>] [samples=<int>] [seed=<int>]
 //     Run samples (e.g. samples=5) number of simulations for duration (e.g.