Skip to content

Commit 18a0b78

Browse files
committed
build: fix some small errors
These were found by an LLM. None are severe, but to minimize the chances of unexpected errors or avoid further confusion we address them. Epic: none Release note: None
1 parent 95e1d21 commit 18a0b78

File tree

4 files changed

+38
-34
lines changed

4 files changed

+38
-34
lines changed

build/bazelbuilder/Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,11 @@ RUN if [[ ${TARGETPLATFORM} != "linux/s390x" ]]; then \
8989
# NB: As above, this is not available on `s390x`.
9090
RUN if [[ ${TARGETPLATFORM} != "linux/s390x" ]]; then \
9191
case ${TARGETPLATFORM} in \
92-
"linux/amd64") ARCH=x86_64; SHASUM= ;; \
92+
"linux/amd64") ARCH=x86_64; SHASUM=8ba7e746ca05f225e5a73952bbc03f4086a5f65fd94f3717df6f75f212587159 ;; \
9393
"linux/arm64") ARCH=arm; SHASUM=e6153461e3154ebce61d35b73005bdd14a0ecacd42e5008f66e25b4ad231e5c9 ;; \
9494
esac \
9595
&& curl -fsSL "https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-cli-linux-$ARCH.tar.gz" -o gcloud.tar.gz \
96+
&& echo "$SHASUM gcloud.tar.gz" | sha256sum -c - \
9697
&& tar -xzf gcloud.tar.gz \
9798
&& rm gcloud.tar.gz ; \
9899
fi

pkg/cmd/bazci/bazci.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,9 @@ func sendBepDataToBeaverHub(bepFilepath string) error {
320320
}
321321

322322
func bazciImpl(cmd *cobra.Command, args []string) error {
323+
if len(args) == 0 {
324+
return errors.Newf("must provide some subcommand (`build`, `run`, `test`, `coverage`, `merge-test-xmls`, or `munge-test-xml`)")
325+
}
323326
if args[0] != buildSubcmd && args[0] != runSubcmd && args[0] != coverageSubcmd &&
324327
args[0] != testSubcmd && args[0] != mungeTestXMLSubcmd && args[0] != mergeTestXMLsSubcmd {
325328
return errors.Newf("First argument must be `build`, `run`, `test`, `coverage`, `merge-test-xmls`, or `munge-test-xml`; got %v", args[0])

0 commit comments

Comments
 (0)