sql: close input in update swap and delete swap

michae2 · michae2 · commit 18a6a919764e · 2025-06-23T16:08:33.000-07:00
In #144186 I forgot to close the input in updateSwapNode.Close and deleteSwapNode.Close. Informs: #144186 Release note: None
diff --git a/pkg/sql/delete_swap.go b/pkg/sql/delete_swap.go
@@ -133,6 +133,7 @@ func (d *deleteSwapNode) BatchedValues(rowIdx int) tree.Datums {
 }
 
 func (d *deleteSwapNode) Close(ctx context.Context) {
+	d.input.Close(ctx)
 	d.run.td.close(ctx)
 	*d = deleteSwapNode{}
 	deleteSwapNodePool.Put(d)
diff --git a/pkg/sql/update_swap.go b/pkg/sql/update_swap.go
@@ -133,6 +133,7 @@ func (u *updateSwapNode) BatchedValues(rowIdx int) tree.Datums {
 }
 
 func (u *updateSwapNode) Close(ctx context.Context) {
+	u.input.Close(ctx)
 	u.run.tu.close(ctx)
 	*u = updateSwapNode{}
 	updateSwapNodePool.Put(u)

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ func (d *deleteSwapNode) BatchedValues(rowIdx int) tree.Datums {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`func (d *deleteSwapNode) Close(ctx context.Context) {`
	`136`	`+ d.input.Close(ctx)`
`136`	`137`	`d.run.td.close(ctx)`
`137`	`138`	`*d = deleteSwapNode{}`
`138`	`139`	`deleteSwapNodePool.Put(d)`
Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ func (u *updateSwapNode) BatchedValues(rowIdx int) tree.Datums {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`func (u *updateSwapNode) Close(ctx context.Context) {`
	`136`	`+ u.input.Close(ctx)`
`136`	`137`	`u.run.tu.close(ctx)`
`137`	`138`	`*u = updateSwapNode{}`
`138`	`139`	`updateSwapNodePool.Put(u)`