state: rename ParseStoreWeights -> ParseReplicaPlacement

This is a more consistent name.

Author: tbg

pkg/kv/kvserver/asim/state/parser_replica_placement.go

@@ -80,11 +80,11 @@ func (pr ReplicaPlacement) String() string {
 	return strings.Join(result, "\n")
 }
 
-// ParseStoreWeights parses replica placement rules in the format "{stores}:weight".
+// ParseReplicaPlacement parses replica placement rules in the format "{stores}:weight".
 // Weights determine the fraction of ranges using each placement pattern. Examples:
 // {s1:*,s2,s3:NON_VOTER}:1 {s4:*,s5,s6}:1 means half of ranges: s1(leaseholder),s2,s3(non-voter)
 // and half of ranges: s4(leaseholder),s5,s6.
-func ParseStoreWeights(input string) ReplicaPlacement {
+func ParseReplicaPlacement(input string) ReplicaPlacement {
 	pattern := `\{([^}]+)\}:(\d+)`
 	re := regexp.MustCompile(pattern)
 

pkg/kv/kvserver/asim/state/parser_replica_placement_test.go

@@ -18,7 +18,7 @@ func TestReplicaPlacement(t *testing.T) {
 	datadriven.Walk(t, datapathutils.TestDataPath(t, t.Name()), func(t *testing.T, path string) {
 		datadriven.RunTest(t, path, func(t *testing.T, d *datadriven.TestData) string {
 			require.Equal(t, "parse", d.Cmd)
-			rp := ParseStoreWeights(d.Input)
+			rp := ParseReplicaPlacement(d.Input)
 			rp.findReplicaPlacementForEveryStoreSet(1000)
 			return rp.String()
 		})

pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go

@@ -228,7 +228,7 @@ func TestDataDriven(t *testing.T) {
 				placementType := gen.GetRangePlacementType(placementTypeStr)
 				var replicaPlacement state.ReplicaPlacement
 				if placementType == gen.ReplicaPlacement {
-					parsed := state.ParseStoreWeights(d.Input)
+					parsed := state.ParseReplicaPlacement(d.Input)
 					buf.WriteString(fmt.Sprintf("%v", parsed))
 					replicaPlacement = parsed
 				}