Skip to content

Commit 1b95e66

Browse files
authored
Merge pull request #152315 from fqazi/blathers/backport-release-25.3-151947
release-25.3: sql/schemachanger: fix incorrect clean up of sequence ownership
2 parents c1dc90e + 04a0bdb commit 1b95e66

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

pkg/sql/logictest/testdata/logic_test/sequences

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2536,3 +2536,39 @@ SELECT substring(sequence_schema FOR 7), sequence_name FROM [SHOW SEQUENCES] WHE
25362536
pg_temp temp_seq
25372537

25382538
subtest end
2539+
2540+
2541+
subtest incorrect_cleanup_of_owned_by
2542+
2543+
statement ok
2544+
CREATE TABLE t_seq_owner (id BIGSERIAL NOT NULL);
2545+
2546+
statement ok
2547+
CREATE SEQUENCE id_seq_owned OWNED BY t_seq_owner.id;
2548+
2549+
statement ok
2550+
ALTER TABLE t_seq_owner ALTER COLUMN id SET DEFAULT nextval('id_seq_owned');
2551+
2552+
# Confirm the sequence still exists.
2553+
query I
2554+
SELECT count(*) FROM pg_sequences WHERE sequencename='id_seq_owned';
2555+
----
2556+
1
2557+
2558+
2559+
statement ok
2560+
drop table t_seq_owner;
2561+
2562+
# Confirm the sequence is dropped.
2563+
query I
2564+
SELECT count(*) FROM pg_sequences WHERE sequencename='id_seq_owned';
2565+
----
2566+
0
2567+
2568+
# Confirm the table is dropped.
2569+
query I
2570+
SELECT count(*) FROM pg_tables WHERE tablename='t_seq_owner';
2571+
----
2572+
0
2573+
2574+
subtest end

pkg/sql/schemachanger/scexec/scmutationexec/helpers.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,6 @@ func updateColumnExprSequenceUsage(d *descpb.ColumnDescriptor) error {
280280
ids.ForEach(all.Add)
281281
}
282282
d.UsesSequenceIds = all.Ordered()
283-
d.OwnsSequenceIds = all.Ordered()
284283
return nil
285284
}
286285

0 commit comments

Comments
 (0)