Skip to content

Commit 1e81f05

Browse files
committed
microbench-ci: benchmark suite tuning
Previously, one node local KV microbenchmarks were run as part of CI. These tests are sensitive to compiler induced variance. Even though the regressions / improvements are reproducible, often the code change is unrelated to the performance change. It happens often enough with these benchmarks that it could be wasteful for engineers to investigate these slight differences. This change updates the benchmark suite to run the 3 node KV benchmarks instead which is less likely to be triggered due to compiler induced variance.
1 parent 02adab7 commit 1e81f05

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

pkg/cmd/microbench-ci/config/pull-request-suite.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,25 @@ benchmarks:
1313
- "allocs/op"
1414

1515
- display_name: Sysbench
16-
labels: ["KV", "1node", "local", "oltp_read_only"]
17-
name: "BenchmarkSysbench/KV/1node_local/oltp_read_only"
16+
labels: ["KV", "3node", "oltp_read_only"]
17+
name: "BenchmarkSysbench/KV/3node/oltp_read_only"
1818
package: "pkg/sql/tests"
1919
runner_group: 2
20-
count: 20
21-
iterations: 6000
20+
count: 15
21+
iterations: 3000
2222
compare_alpha: 0.025
2323
retries: 3
2424
metrics:
2525
- "sec/op"
2626
- "allocs/op"
2727

2828
- display_name: Sysbench
29-
labels: ["KV", "1node", "local", "oltp_write_only"]
30-
name: "BenchmarkSysbench/KV/1node_local/oltp_write_only"
29+
labels: ["KV", "3node", "oltp_write_only"]
30+
name: "BenchmarkSysbench/KV/3node/oltp_write_only"
3131
package: "pkg/sql/tests"
3232
runner_group: 2
33-
count: 20
34-
iterations: 6000
33+
count: 15
34+
iterations: 3000
3535
compare_alpha: 0.025
3636
retries: 3
3737
metrics:

0 commit comments

Comments
 (0)