Skip to content

Commit 1f663ab

Browse files
craig[bot]ajstormherkolategan
committed
154856: dev-inf: Use GITHUB_TOKEN for Claude Code review action r=rickystewart a=ajstorm The action's OIDC token exchange is failing, likely because the GitHub app isn't configured to accept OIDC tokens from this workflow. By explicitly providing the built-in GITHUB_TOKEN, we bypass the OIDC exchange entirely. The built-in token has sufficient permissions for PR analysis and commenting, which is all this workflow needs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) 154858: roachprod: fix parse int for grow r=DarrylWong a=herkolategan Previously, the number of nodes to grow a cluster by was limited to the max of a signed byte. This change increases the limit to a word. Epic: None Release note: None Co-authored-by: Adam Storm <[email protected]> Co-authored-by: Herko Lategan <[email protected]>
3 parents 6be7477 + a39066a + 487e0e1 commit 1f663ab

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/workflows/pr-analyzer-threestage.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
- name: Checkout repository
1717
uses: actions/checkout@v5
1818
with:
19+
ref: ${{ github.event.pull_request.head.sha || github.ref }}
1920
fetch-depth: 1
2021

2122
- name: Authenticate to Google Cloud
@@ -29,6 +30,7 @@ jobs:
2930
id: stage1
3031
uses: cockroachdb/claude-code-action@v1
3132
with:
33+
github_token: ${{ secrets.GITHUB_TOKEN }}
3234
use_vertex: "true"
3335
claude_args: |
3436
--model claude-sonnet-4-5-20250929
@@ -62,6 +64,7 @@ jobs:
6264
if: contains(steps.stage1.outputs.result, 'STAGE1_RESULT - POTENTIAL_BUG_DETECTED')
6365
uses: cockroachdb/claude-code-action@v1
6466
with:
67+
github_token: ${{ secrets.GITHUB_TOKEN }}
6568
use_vertex: "true"
6669
claude_args: |
6770
--model claude-4-5-sonnet-20250929
@@ -96,6 +99,7 @@ jobs:
9699
if: contains(steps.stage2.outputs.result, 'STAGE2_RESULT - POTENTIAL_BUG_DETECTED')
97100
uses: cockroachdb/claude-code-action@v1
98101
with:
102+
github_token: ${{ secrets.GITHUB_TOKEN }}
99103
use_vertex: "true"
100104
claude_args: |
101105
--model claude-4-5-sonnet-20250929
@@ -144,6 +148,7 @@ jobs:
144148
if: always()
145149
uses: cockroachdb/claude-code-action@v1
146150
with:
151+
github_token: ${{ secrets.GITHUB_TOKEN }}
147152
use_vertex: "true"
148153
claude_args: |
149154
--model claude-4-5-sonnet-20250929

pkg/cmd/roachprod/cli/commands.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ be fairly distributed across the zones of the cluster).
166166
`,
167167
Args: cobra.ExactArgs(2),
168168
Run: Wrap(func(cmd *cobra.Command, args []string) error {
169-
count, err := strconv.ParseInt(args[1], 10, 8)
169+
count, err := strconv.ParseInt(args[1], 10, 16)
170170
if err != nil || count < 1 {
171171
return errors.Wrapf(err, "invalid num-nodes argument")
172172
}

0 commit comments

Comments
 (0)