backup: don't start download job if theres no table data

msbutler · msbutler · commit 2133c1f93f59 · 2025-03-30T13:25:59.000-04:00
diff --git a/pkg/backup/restore_job.go b/pkg/backup/restore_job.go
@@ -1866,9 +1866,6 @@ func (r *restoreResumer) doResume(ctx context.Context, execCtx interface{}) erro
 				return err
 			}
 		}
-		if err := r.maybeWriteDownloadJob(ctx, p.ExecCfg(), preData, mainData); err != nil {
-			return err
-		}
 		emitRestoreJobEvent(ctx, p, jobs.StateSucceeded, r.job)
 		return nil
 	}
diff --git a/pkg/backup/testdata/backup-restore/online-restore-empty-database b/pkg/backup/testdata/backup-restore/online-restore-empty-database
@@ -22,4 +22,4 @@ RESTORE DATABASE d FROM LATEST IN 'nodelocal://1/cluster/' with EXPERIMENTAL DEF
 query-sql retry
 SELECT count(*) FROM [SHOW JOBS] WHERE job_type='RESTORE' and status='succeeded';
 ----
-2
+1

Original file line number	Diff line number	Diff line change
`@@ -1866,9 +1866,6 @@ func (r *restoreResumer) doResume(ctx context.Context, execCtx interface{}) erro`
`1866`	`1866`	`return err`
`1867`	`1867`	`}`
`1868`	`1868`	`}`
`1869`		`- if err := r.maybeWriteDownloadJob(ctx, p.ExecCfg(), preData, mainData); err != nil {`
`1870`		`- return err`
`1871`		`- }`
`1872`	`1869`	`emitRestoreJobEvent(ctx, p, jobs.StateSucceeded, r.job)`
`1873`	`1870`	`return nil`
`1874`	`1871`	`}`