Skip to content

Commit 2473184

Browse files
craig[bot]pritesh-lahoti
andcommitted
Merge #150222
150222: ccl/oidcccl: increase client timeout to fix flaky test r=sanchit-CRL a=pritesh-lahoti ccl/oidcccl: increase client timeout to fix flaky test The default HTTP client timeout was 10s which intermittently resulted in a context deadline exceeded error under stress. This has now been increased to 30s. Fixes: #150136 Release note: None Co-authored-by: Pritesh Lahoti <[email protected]>
2 parents 8f28ff9 + 20e61e6 commit 2473184

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/ccl/oidcccl/authentication_oidc_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ func TestOIDCEnabled(t *testing.T) {
145145
client, err := testCertsContext.GetHTTPClient()
146146
require.NoError(t, err)
147147

148+
// Set a reasonable timeout for the client to prevent flakiness under stress.
149+
client.Timeout = 30 * time.Second
150+
148151
// Don't follow redirects so we can inspect the 302
149152
client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
150153
return http.ErrUseLastResponse

0 commit comments

Comments
 (0)