crosscluster: fix error handling in computeRangeStats

jeffswenson · jeffswenson · commit 2526c4b0789a · 2025-09-03T16:49:53.000-04:00
`computeRangeStats` was returning `err` when it should have returned
`lazyIterator.Error`. The code calling this is best effort, so returning
success is not a critical bug. But it does mean we would miss a warning
log.

Release note: none
Epic: none
diff --git a/pkg/crosscluster/producer/range_stats.go b/pkg/crosscluster/producer/range_stats.go
@@ -108,7 +108,7 @@ func computeRangeStats(
 			}
 		}
 		if lazyIterator.Error() != nil {
-			return streampb.StreamEvent_RangeStats{}, err
+			return streampb.StreamEvent_RangeStats{}, lazyIterator.Error()
 		}
 	}
 	return stats, nil

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ func computeRangeStats(`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`	`if lazyIterator.Error() != nil {`
`111`		`- return streampb.StreamEvent_RangeStats{}, err`
	`111`	`+ return streampb.StreamEvent_RangeStats{}, lazyIterator.Error()`
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`	`return stats, nil`