Skip to content

Commit 253a365

Browse files
committed
changefeedccl: replace incorrect usage of QueryRow in tests
Two recently added ALTER CHANGEFEED unit tests use `QueryRow` instead of `Exec` for queries that don't return values, which technically could allow an error to go unnoticed. This patch corrects that. Release note: None
1 parent bcfd7d4 commit 253a365

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/ccl/changefeedccl/alter_changefeed_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1828,7 +1828,7 @@ func TestAlterChangefeedAddDropSameTarget(t *testing.T) {
18281828
sqlDB.Exec(t, fmt.Sprintf(`ALTER CHANGEFEED %d ADD bar DROP bar`, feed.JobID()))
18291829
require.NoError(t, feed.Resume())
18301830
var tsStr string
1831-
sqlDB.QueryRow(t, `INSERT INTO bar VALUES(1)`)
1831+
sqlDB.Exec(t, `INSERT INTO bar VALUES(1)`)
18321832
sqlDB.QueryRow(t, `INSERT INTO foo VALUES(2) RETURNING cluster_logical_timestamp()`).Scan(&tsStr)
18331833
ts := parseTimeToHLC(t, tsStr)
18341834
require.NoError(t, feed.WaitForHighWaterMark(ts))

0 commit comments

Comments
 (0)