Commit 2b2511f
153464: server: only auto-upgrade system tenant from meta1 leaseholder r=arulajmani a=stevendanna
Running the auto-upgrade process from all nodes does some amount of wasted work. Let's avoid that by only running it from the meta1 leaseholder. This only applies to the system tenant.
For shared-process multi-tenancy, we may consider allowing secondary tenants access to this same information.
For separate process multi-tenancy, a different solution would be needed.
Informs #152916
Release note: None
153683: sql/schemachanger: split computed column dependency rule to fix DROP COLUMN CASCADE deadlock r=spilchen a=spilchen
Previously, a single dependency rule applied to all computed column expressions, causing deadlocks when dropping columns with STORED computed dependencies via CASCADE. The rule forced computed expressions to be dropped before their referenced columns, but this created circular dependencies during CASCADE operations with STORED columns.
This change splits the rule into two separate rules:
- Virtual computed columns: Keep existing precedence rule needed for optimizer
- Stored computed columns: Only apply rule during ALTER COLUMN TYPE operations
This prevents the deadlock while preserving the necessary dependency ordering for ALTER COLUMN TYPE operations where temporary expressions map old rows to new column types.
Also adds NOTICE messages for computed column CASCADE drops.
Fixes #152841.
Release note (bug fix): Fixed deadlock in DROP COLUMN CASCADE operations when dropping columns referenced by STORED computed columns.
Epic: None
153963: changefeedccl: fix log location in test r=KeithCh a=asg0451
Fix a roachtest failure due to the expected log
moving to the new CHANGEFEED log channel.
Fixes: #153130
Release note: None
153970: security: skip flaky TestTLSCipherRestrict r=msbutler a=wenyihu6
This commit skips flaky test TestTLSCipherRestrict for CI.
Informs: #153802
Release note: none
Co-authored-by: Steven Danna <[email protected]>
Co-authored-by: Matt Spilchen <[email protected]>
Co-authored-by: Miles Frankel <[email protected]>
Co-authored-by: wenyihu6 <[email protected]>
File tree
143 files changed
+711
-323
lines changed- pkg
- ccl/schemachangerccl/testdata/end_to_end/alter_table_alter_primary_key_rbr
- clusterversion
- cmd/roachtest/tests
- security
- server
- sql
- logictest/testdata/logic_test
- schemachanger
- scbuild
- internal/scbuildstmt
- testdata
- scplan
- internal/rules/current
- testdata
- testdata
- screl
- testdata/end_to_end
- add_column_with_stored_family
- add_column_with_stored
- alter_table_add_primary_key_drop_rowid_with_secondary_idx
- alter_table_alter_column_type_general_expr
- alter_table_alter_column_type_general
- alter_table_alter_primary_key_using_hash
- create_index_with_expression
- drop_column_computed_index
- drop_column_create_index_separate_statements
- drop_column_with_null_constraint_stored
- drop_index_hash_sharded_index
- drop_index_partial_expression_index
- drop_index_with_fks
- drop_multiple_columns_separate_statements
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
143 files changed
+711
-323
lines changedLines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
| 182 | + | |
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
184 | | - | |
| 184 | + | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| |||
0 commit comments