Merge #149583 #149709 #149716

149583: sql/inspect: introduce new INSPECT processor into DistSQL flow r=spilchen a=spilchen

This change integrates a new INSPECT processor into the DistSQL framework. The job coordinator for INSPECT now builds a distributed plan across the key spans of a single table (currently only supports one table). The plan is executed across nodes based on the partitioning of the table, invoking the new INSPECT processor on each participating node.

At present, the processor is a no-op that simply returns success, laying groundwork for future changes.

Informs: #148683
Epic: CRDB-30356
Release note: none

149709: go.mod: bump Pebble to a370be5e7e50 r=annrpom a=annrpom

Changes:

 * [`a370be5e`](cockroachdb/pebble@a370be5e) internal/keyspan: fix swallowed error in InterleavingIter.NextPrefix
 * [`6630a64b`](cockroachdb/pebble@6630a64b) db: print value separation metrics
 * [`6f57a213`](cockroachdb/pebble@6f57a213) db: merge in obsolete blob file during failed blob rewrite compaction

Release note: none.
Epic: none.

149716: multiregionccl: skip TestMultiRegionTenantRegions under duress r=rafiss a=rafiss

fixes #149010
Release note: None

Co-authored-by: Matt Spilchen <[email protected]>
Co-authored-by: Annie Pompa <[email protected]>
Co-authored-by: Rafi Shamim <[email protected]>

Author: 4 people

.github/CODEOWNERS

@@ -62,6 +62,7 @@
 /pkg/sql/execinfrapb/processors_bulk_io.proto     @cockroachdb/disaster-recovery
 /pkg/sql/execinfrapb/processors_changefeeds.proto @cockroachdb/cdc-prs
 /pkg/sql/execinfrapb/processors_ttl.proto         @cockroachdb/sql-foundations
+/pkg/sql/execinfrapb/processors_inspect.proto     @cockroachdb/sql-foundations
 /pkg/sql/exec_factory_util.go          @cockroachdb/sql-queries-prs
 #!/pkg/sql/exec_log*.go                @cockroachdb/sql-queries-noreview
 #!/pkg/sql/exec_util*.go               @cockroachdb/sql-queries-noreview
@@ -106,6 +107,7 @@
 /pkg/sql/tests/rsg_test.go   @cockroachdb/sql-foundations
 /pkg/sql/ttl                 @cockroachdb/sql-foundations
 /pkg/sql/spanutils/          @cockroachdb/sql-foundations
+/pkg/sql/inspect/            @cockroachdb/sql-foundations
 
 /pkg/sql/syntheticprivilege/      @cockroachdb/sql-foundations
 /pkg/sql/syntheticprivilegecache/ @cockroachdb/sql-foundations

DEPS.bzl

@@ -1835,10 +1835,10 @@ def go_deps():
         patches = [
             "@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch",
         ],
-        sha256 = "23d6f7ca193051e5ba0317a0d6346f0e26ceb4965060fbc5b8cc6e16b7fda849",
-        strip_prefix = "github.com/cockroachdb/[email protected]20250703175825-20e2cbcd70de",
+        sha256 = "d3a727e03593def35072caac3e097b4cbc58ebafc3f8dc7294f9acfb7c4d79c0",
+        strip_prefix = "github.com/cockroachdb/[email protected]20250708172732-a370be5e7e50",
         urls = [
-            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250703175825-20e2cbcd70de.zip",
+            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250708172732-a370be5e7e50.zip",
         ],
     )
     go_repository(

build/bazelutil/distdir_files.bzl

@@ -358,7 +358,7 @@ DISTDIR_FILES = {
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/gostdlib/com_github_cockroachdb_gostdlib-v1.19.0.zip": "c4d516bcfe8c07b6fc09b8a9a07a95065b36c2855627cb3514e40c98f872b69e",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/logtags/com_github_cockroachdb_logtags-v0.0.0-20241215232642-bb51bb14a506.zip": "920068af09e3846d9ebb4e4a7787ff1dd10f3989c5f940ad861b0f6a9f824f6e",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/metamorphic/com_github_cockroachdb_metamorphic-v0.0.0-20231108215700-4ba948b56895.zip": "28c8cf42192951b69378cf537be5a9a43f2aeb35542908cc4fe5f689505853ea",
-    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250703175825-20e2cbcd70de.zip": "23d6f7ca193051e5ba0317a0d6346f0e26ceb4965060fbc5b8cc6e16b7fda849",
+    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20250708172732-a370be5e7e50.zip": "d3a727e03593def35072caac3e097b4cbc58ebafc3f8dc7294f9acfb7c4d79c0",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/redact/com_github_cockroachdb_redact-v1.1.6.zip": "018eccb5fb9ca52d43ec9eaf213539d01c1f2b94e0e822406ebfb2e9321ef6cf",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/returncheck/com_github_cockroachdb_returncheck-v0.0.0-20200612231554-92cdbca611dd.zip": "ce92ba4352deec995b1f2eecf16eba7f5d51f5aa245a1c362dfe24c83d31f82b",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/stress/com_github_cockroachdb_stress-v0.0.0-20220803192808-1806698b1b7b.zip": "3fda531795c600daf25532a4f98be2a1335cd1e5e182c72789bca79f5f69fcc1",

go.mod

@@ -140,7 +140,7 @@ require (
 	github.com/cockroachdb/go-test-teamcity v0.0.0-20191211140407-cff980ad0a55
 	github.com/cockroachdb/gostdlib v1.19.0
 	github.com/cockroachdb/logtags v0.0.0-20241215232642-bb51bb14a506
-	github.com/cockroachdb/pebble v0.0.0-20250703175825-20e2cbcd70de
+	github.com/cockroachdb/pebble v0.0.0-20250708172732-a370be5e7e50
 	github.com/cockroachdb/redact v1.1.6
 	github.com/cockroachdb/returncheck v0.0.0-20200612231554-92cdbca611dd
 	github.com/cockroachdb/stress v0.0.0-20220803192808-1806698b1b7b

go.sum

@@ -582,8 +582,8 @@ github.com/cockroachdb/logtags v0.0.0-20241215232642-bb51bb14a506 h1:ASDL+UJcILM
 github.com/cockroachdb/logtags v0.0.0-20241215232642-bb51bb14a506/go.mod h1:Mw7HqKr2kdtu6aYGn3tPmAftiP3QPX63LdK/zcariIo=
 github.com/cockroachdb/metamorphic v0.0.0-20231108215700-4ba948b56895 h1:XANOgPYtvELQ/h4IrmPAohXqe2pWA8Bwhejr3VQoZsA=
 github.com/cockroachdb/metamorphic v0.0.0-20231108215700-4ba948b56895/go.mod h1:aPd7gM9ov9M8v32Yy5NJrDyOcD8z642dqs+F0CeNXfA=
-github.com/cockroachdb/pebble v0.0.0-20250703175825-20e2cbcd70de h1:PXtuqYSHdl6XuV+OueyfHwxgGJHVASj0wU4NfqYksmw=
-github.com/cockroachdb/pebble v0.0.0-20250703175825-20e2cbcd70de/go.mod h1:LLa+I2vZrOsrsy4QcuZ6wSXBNQll7erNg3GCr8NpE90=
+github.com/cockroachdb/pebble v0.0.0-20250708172732-a370be5e7e50 h1:nURMd/syIIPsnG2yFt0rx4kUFmjSuCIuGys74/YQxEY=
+github.com/cockroachdb/pebble v0.0.0-20250708172732-a370be5e7e50/go.mod h1:LLa+I2vZrOsrsy4QcuZ6wSXBNQll7erNg3GCr8NpE90=
 github.com/cockroachdb/redact v1.1.3/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=
 github.com/cockroachdb/redact v1.1.6 h1:zXJBwDZ84xJNlHl1rMyCojqyIxv+7YUpQiJLQ7n4314=
 github.com/cockroachdb/redact v1.1.6/go.mod h1:BVNblN9mBWFyMyqK1k3AAiSxhvhfK2oOZZ2lK+dpvRg=

pkg/ccl/multiregionccl/multiregion_system_table_test.go

@@ -330,6 +330,8 @@ func TestMultiRegionTenantRegions(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	defer log.Scope(t).Close(t)
 
+	skip.UnderDuress(t, "slow test")
+
 	tc, _, cleanup := multiregionccltestutils.TestingCreateMultiRegionCluster(
 		t, 3 /*numServers*/, base.TestingKnobs{},
 	)

pkg/cli/interactive_tests/test_encryption.tcl

@@ -53,7 +53,7 @@ end_test
 
 start_test "Run pebble debug tool."
 send "$argv debug pebble db lsm $storedir\r"
-eexpect "level | tables  size val-bl vtables | score  ff  cff |   in  | tables  size | tables  size | tables  size |  read |   r   w\r"
+eexpect "level | tables  size val-bl vtables | score  ff  cff |   in  | tables  size | tables  size | tables  size |  read |   r   w  | refsz  valblk\r"
 end_test
 
 start_test "Restart with plaintext."
@@ -107,7 +107,7 @@ end_test
 
 start_test "Run pebble debug tool with AES-256."
 send "$argv debug pebble db lsm $storedir --enterprise-encryption=path=$storedir,key=$keydir/aes-256.key,old-key=$keydir/aes-256.key\r"
-eexpect "level | tables  size val-bl vtables | score  ff  cff |   in  | tables  size | tables  size | tables  size |  read |   r   w\r"
+eexpect "level | tables  size val-bl vtables | score  ff  cff |   in  | tables  size | tables  size | tables  size |  read |   r   w  | refsz  valblk\r"
 # Try running without the encryption flag.
 send "$argv debug pebble db lsm $storedir\r"
 eexpect "If this is an encrypted store, make sure the correct encryption key is set."

pkg/jobs/jobspb/jobs.proto

@@ -1405,7 +1405,42 @@ message HotRangesLoggerDetails {
 }
 
 message InspectDetails {
+  // Check represents a single validation task to perform as part of an INSPECT
+  // job. Each check targets a specific table or index and is associated with a
+  // validation type.
+  message Check {
+    enum InspectCheckType {
+      option (gogoproto.goproto_enum_prefix) = false;
+      option (gogoproto.goproto_enum_stringer) = false;
+
+      // UNSPECIFIED indicates an unset check type. This is invalid.
+      INSPECT_CHECK_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "InspectCheckUnspecified"];
+
+      // INDEX_CONSISTENCY performs validation between primary and secondary indexes
+      // to detect missing or dangling index entries.
+      INSPECT_CHECK_INDEX_CONSISTENCY = 1 [(gogoproto.enumvalue_customname) = "InspectCheckIndexConsistency"];
+    }
+
+    // Type is the kind of validation to perform.
+    InspectCheckType type = 1;
+
+    // TableID identifies the table this check applies to.
+    uint32 table_id = 2 [
+      (gogoproto.customname) = "TableID",
+      (gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb.ID"
+    ];
+
+    // IndexID identifies the specific index to check, if applicable. Only
+    // relevant for check types that operate at the index level. Should be unset
+    // or ignored for table-level checks.
+    uint32 index_id = 3 [
+      (gogoproto.customname) = "IndexID",
+      (gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb.IndexID"
+    ];
+  }
 
+  // Checks is the list of individual checks this job will perform.
+  repeated Check checks = 1;
 }
 
 message UpdateTableMetadataCacheDetails {}

pkg/sql/colexec/colbuilder/execplan.go

@@ -320,6 +320,8 @@ func canWrap(mode sessiondatapb.VectorizeExecMode, core *execinfrapb.ProcessorCo
 		return errIndexBackfillMergerWrap
 	case core.Ttl != nil:
 		return errCoreNotWorthWrapping
+	case core.Inspect != nil:
+		return errCoreNotWorthWrapping
 	case core.HashGroupJoiner != nil:
 	case core.GenerativeSplitAndScatter != nil:
 		return errCoreNotWorthWrapping

pkg/sql/distsql_leaf_txn.go

@@ -233,6 +233,8 @@ func planSafeForReducedLeaf(processors []physicalplan.Processor) bool {
 			return unoptimizedProcessor
 		case core.Ttl != nil:
 			return unoptimizedProcessor
+		case core.Inspect != nil:
+			return unoptimizedProcessor
 		case core.HashGroupJoiner != nil:
 			if unsafeExpr(core.HashGroupJoiner.HashJoinerSpec.OnExpr) {
 				return unsafeProcessor