raft: remove test-only deps on maxApplyingEntsSize

Epic: none
Release note: none

Author: pav-kv

pkg/raft/log.go

@@ -292,7 +292,7 @@ func (l *raftLog) nextCommittedEnts(allowUnstable bool) (ents []pb.Entry) {
 	if span.Empty() {
 		return nil
 	}
-	ents, err := l.slice(uint64(span.After), uint64(span.Last), l.maxApplyingEntsSize)
+	ents, err := l.slice(uint64(span.After), uint64(span.Last), noLimit)
 	if err != nil {
 		l.logger.Panicf("unexpected error when getting unapplied entries (%v)", err)
 	}

pkg/raft/node_test.go

@@ -591,12 +591,9 @@ func TestAppendPagination(t *testing.T) {
 }
 
 func TestCommitPagination(t *testing.T) {
+	const maxCommittedSize = 2048
 	s := newTestMemoryStorage(withPeers(1))
-	cfg := newTestConfig(1, 10, 1, s)
-	cfg.MaxCommittedSizePerReady = 2048
-	rn, err := NewRawNode(cfg)
-	require.NoError(t, err)
-
+	rn := newTestRawNode(1, 10, 1, s)
 	require.NoError(t, rn.Campaign())
 
 	// Persist vote.
@@ -630,17 +627,15 @@ func TestCommitPagination(t *testing.T) {
 	rd = rn.Ready()
 	// TODO(pav-kv): we no longer need this test after the flow control policy is
 	// moved up the stack.
-	committed, err := rn.LogSnapshot().Slice(
-		rd.Committed, uint64(rn.raft.raftLog.maxApplyingEntsSize))
+	committed, err := rn.LogSnapshot().Slice(rd.Committed, maxCommittedSize)
 	require.NoError(t, err)
 	require.Len(t, committed, 2)
 	require.NoError(t, s.Append(rd.Entries))
 	rn.AdvanceHack(rd)
 	rn.AckApplied(committed)
 
 	rd = rn.Ready()
-	committed, err = rn.LogSnapshot().Slice(
-		rd.Committed, uint64(rn.raft.raftLog.maxApplyingEntsSize))
+	committed, err = rn.LogSnapshot().Slice(rd.Committed, maxCommittedSize)
 	require.NoError(t, err)
 	require.Len(t, committed, 1)
 	require.NoError(t, s.Append(rd.Entries))