server: register Status service with DRPC server

Enable the `Status` service on the DRPC server in addition to gRPC. This is
controlled by `rpc.experimental_drpc.enabled` (off by default).

This change is part of a series and is similar to: #146926

Note: This only registers the service; the client is not updated to use the
DRPC client, so this service will not have any functional effect.

Epic: CRDB-48925
Release note: None

Author: shubhamdhama

pkg/server/drpc_server.go

@@ -13,6 +13,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/server/srverrors"
 	"github.com/cockroachdb/errors"
 	"google.golang.org/grpc/codes"
+	"storj.io/drpc"
 	"storj.io/drpc/drpcerr"
 )
 
@@ -75,3 +76,9 @@ func (s *drpcServer) health(ctx context.Context) error {
 		return srverrors.ServerError(ctx, errors.Newf("unknown mode: %v", sm))
 	}
 }
+
+// drpcServiceRegistrar is implemented by servers that create a DRPC server and
+// registers it with drpc.Mux
+type drpcServiceRegistrar interface {
+	RegisterDRPCService(drpc.Mux) error
+}

pkg/server/server.go

@@ -1253,14 +1253,10 @@ func NewServer(cfg Config, stopper *stop.Stopper) (serverctl.ServerStartupInterf
 		gw.RegisterService(grpcServer.Server)
 	}
 
-	if err := sAuth.RegisterDRPCService(drpcServer); err != nil {
-		return nil, err
-	}
-	if err := sTS.RegisterDRPCService(drpcServer); err != nil {
-		return nil, err
-	}
-	if err := sAdmin.RegisterDRPCService(drpcServer); err != nil {
-		return nil, err
+	for _, s := range []drpcServiceRegistrar{sAdmin, sStatus, sAuth, &sTS} {
+		if err := s.RegisterDRPCService(drpcServer); err != nil {
+			return nil, err
+		}
 	}
 
 	// Tell the node event logger (join, restart) how to populate SQL entries

pkg/server/status.go

@@ -95,6 +95,7 @@ import (
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
+	"storj.io/drpc"
 )
 
 const (
@@ -695,6 +696,11 @@ func (s *statusServer) RegisterService(g *grpc.Server) {
 	serverpb.RegisterStatusServer(g, s)
 }
 
+// RegisterService registers the DRPC service.
+func (s *statusServer) RegisterDRPCService(d drpc.Mux) error {
+	return serverpb.DRPCRegisterStatus(d, s)
+}
+
 // RegisterGateway starts the gateway (i.e. reverse
 // proxy) that proxies HTTP requests to the appropriate gRPC endpoints.
 func (s *statusServer) RegisterGateway(
@@ -709,6 +715,11 @@ func (s *systemStatusServer) RegisterService(g *grpc.Server) {
 	serverpb.RegisterStatusServer(g, s)
 }
 
+// RegisterService registers the DRPC service.
+func (s *systemStatusServer) RegisterDRPCService(d drpc.Mux) error {
+	return serverpb.DRPCRegisterStatus(d, s)
+}
+
 func (s *statusServer) parseNodeID(nodeIDParam string) (roachpb.NodeID, bool, error) {
 	id, local, err := s.serverIterator.parseServerID(nodeIDParam)
 	return roachpb.NodeID(id), local, err

pkg/server/tenant.go

@@ -480,14 +480,10 @@ func newTenantServer(
 		gw.RegisterService(args.grpc.Server)
 	}
 
-	if err := sAuth.RegisterDRPCService(args.drpc); err != nil {
-		return nil, err
-	}
-	if err := args.tenantTimeSeriesServer.RegisterDRPCService(args.drpc); err != nil {
-		return nil, err
-	}
-	if err := sAdmin.RegisterDRPCService(args.drpc); err != nil {
-		return nil, err
+	for _, s := range []drpcServiceRegistrar{sAdmin, sStatus, sAuth, args.tenantTimeSeriesServer} {
+		if err := s.RegisterDRPCService(args.drpc); err != nil {
+			return nil, err
+		}
 	}
 
 	// Tell the status/admin servers how to access SQL structures.