Skip to content

Commit 2f31c4c

Browse files
committed
roachtest: use internal name when setting PanicOnAssertions
The user visible name for setting PanicOnAssertions was not added until 23.2. Attempting to use this on mixed version tests that upgrade from an earlier version will throw an unknown cluster setting error
1 parent acb7431 commit 2f31c4c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/roachprod/install/cockroach.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1394,7 +1394,9 @@ func (c *SyncedCluster) generateClusterSettingCmd(
13941394
"enterprise.license": license,
13951395
// N.B. We now enable `PanicOnAssertions` for all roachprod clusters.
13961396
// (See https://github.com/cockroachdb/cockroach/issues/136858)
1397-
"debug.panic_on_failed_assertions.enabled": "true",
1397+
// Use the internal name instead of the user visible name, which wasn't
1398+
// added until 23.2, to avoid breaking mixed version tests.
1399+
"debug.panic_on_failed_assertions": "true",
13981400
}
13991401
for name, value := range c.ClusterSettings.ClusterSettings {
14001402
clusterSettings[name] = value

0 commit comments

Comments
 (0)