Merge #144180

144180: fix: ttl job description doesnot quote key column r=rafiss a=mohitsethia

fixes: #142986 

Co-authored-by: Mohit Sethia <[email protected]>

Author: craig[bot]

pkg/sql/ttl/ttlschedule/BUILD.bazel

@@ -17,6 +17,7 @@ go_library(
         "//pkg/sql/catalog/catpb",
         "//pkg/sql/catalog/descs",
         "//pkg/sql/isql",
+        "//pkg/sql/lexbase",
         "//pkg/sql/pgwire/pgcode",
         "//pkg/sql/pgwire/pgerror",
         "//pkg/sql/sem/tree",

pkg/sql/ttl/ttlschedule/ttlschedule.go

@@ -6,6 +6,7 @@
 package ttlschedule
 
 import (
+	"bytes"
 	"context"
 	"fmt"
 
@@ -20,6 +21,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/catpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/descs"
 	"github.com/cockroachdb/cockroach/pkg/sql/isql"
+	"github.com/cockroachdb/cockroach/pkg/sql/lexbase"
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgcode"
 	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgerror"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
@@ -222,7 +224,13 @@ func makeTTLJobDescription(
 ) string {
 	relationName := tn.FQString()
 	pkIndex := tableDesc.GetPrimaryIndex().IndexDesc()
-	pkColNames := pkIndex.KeyColumnNames
+	pkColNames := make([]string, 0, len(pkIndex.KeyColumnNames))
+	var buf bytes.Buffer
+	for _, name := range pkIndex.KeyColumnNames {
+		lexbase.EncodeRestrictedSQLIdent(&buf, name, lexbase.EncNoFlags)
+		pkColNames = append(pkColNames, buf.String())
+		buf.Reset()
+	}
 	pkColDirs := pkIndex.KeyColumnDirections
 	rowLevelTTL := tableDesc.GetRowLevelTTL()
 	ttlExpirationExpr := rowLevelTTL.GetTTLExpr()