Merge #155203

155203: ui: ensure all essential SQL metrics are shown on dashboards r=yuzefovich a=yuzefovich

This commit audits all essential metrics owned by SQL Queries to ensure that all of them show up on one of the dashboards on SQL page. The following changes are made:
- `txn.restarts.txnpush` and `txn.restarts.unknown` are added to existing "Transaction Restarts" dashboard
- `sql.conn.failures` is added on a new dashboard, right before "Connection Latency"
- SELECTs, UPDATEs, INSERTS, and DELETEs executed within routines are now shown on new dashboard "SQL Queries Within Routines Per Second", right after "SQL Queries Per Second"
- new dashboard "Table Statistics Collections" shows details about Auto and Auto Partial as well as manual stats collections, right after "Schema Changes".

Fixes: #154554.

Release note (ui change): SQL dashboard has been extended to include more details (mostly about stmts executed within routines and table statistics collections).

Co-authored-by: Yahor Yuzefovich <[email protected]>

Author: craig[bot]

pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/sql.tsx

@@ -174,6 +174,39 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
+    <LineGraph
+      title="SQL Queries Within Routines Per Second"
+      isKvGraph={false}
+      sources={nodeSources}
+      tenantSource={tenantSource}
+      tooltip={`A ten-second moving average of the # of SELECT, INSERT, UPDATE, and DELETE statements
+           executed within routines (user-defined functions and stored procedures) ${tooltipSelection}.`}
+      showMetricsInTooltip={true}
+    >
+      <Axis label="queries within routines">
+        <Metric
+          name="cr.node.sql.routine.select.count"
+          title="Selects"
+          nonNegativeRate
+        />
+        <Metric
+          name="cr.node.sql.routine.update.count"
+          title="Updates"
+          nonNegativeRate
+        />
+        <Metric
+          name="cr.node.sql.routine.insert.count"
+          title="Inserts"
+          nonNegativeRate
+        />
+        <Metric
+          name="cr.node.sql.routine.delete.count"
+          title="Deletes"
+          nonNegativeRate
+        />
+      </Axis>
+    </LineGraph>,
+
     <LineGraph
       title="SQL Statement Errors"
       isKvGraph={false}
@@ -271,6 +304,23 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
+    <LineGraph
+      title="Failed SQL Connections"
+      isKvGraph={false}
+      sources={nodeSources}
+      tenantSource={tenantSource}
+      tooltip={`The total number of failed SQL connection attempts ${tooltipSelection}.`}
+      showMetricsInTooltip={true}
+    >
+      <Axis label="failed connections">
+        <Metric
+          name="cr.node.sql.conn.failures"
+          title="Number of Failed SQL Connections"
+          downsampleMax
+        />
+      </Axis>
+    </LineGraph>,
+
     <LineGraph
       title="Connection Latency: 99th percentile"
       isKvGraph={false}
@@ -542,6 +592,16 @@ export default function (props: GraphDashboardProps) {
           title="Aborted"
           nonNegativeRate
         />
+        <Metric
+          name="cr.node.txn.restarts.txnpush"
+          title="Pushed"
+          nonNegativeRate
+        />
+        <Metric
+          name="cr.node.txn.restarts.unknown"
+          title="Unknown"
+          nonNegativeRate
+        />
       </Axis>
     </LineGraph>,
 
@@ -641,6 +701,53 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
+    <LineGraph
+      title="Table Statistics Collections"
+      isKvGraph={false}
+      sources={nodeSources}
+      tenantSource={tenantSource}
+      tooltip={`Details about table statistics collections ${tooltipSelection}.`}
+      showMetricsInTooltip={true}
+    >
+      <Axis label="jobs">
+        <Metric
+          name="cr.node.jobs.auto_create_stats.currently_running"
+          title="Auto Running"
+          downsampleMax
+        />
+        <Metric
+          name="cr.node.jobs.auto_create_partial_stats.currently_running"
+          title="Auto Partial Running"
+          downsampleMax
+        />
+        <Metric
+          name="cr.node.jobs.create_stats.currently_running"
+          title="Manual Running"
+          downsampleMax
+        />
+        <Metric
+          name="cr.node.jobs.auto_create_stats.currently_paused"
+          title="Auto Paused"
+          downsampleMax
+        />
+        <Metric
+          name="cr.node.jobs.auto_create_partial_stats.currently_paused"
+          title="Auto Partial Paused"
+          downsampleMax
+        />
+        <Metric
+          name="cr.node.jobs.auto_create_stats.resume_failed"
+          title="Auto Failed"
+          downsampleMax
+        />
+        <Metric
+          name="cr.node.jobs.auto_create_partial_stats.resume_failed"
+          title="Auto Partial Failed"
+          downsampleMax
+        />
+      </Axis>
+    </LineGraph>,
+
     <LineGraph
       title="Statement Denials: Cluster Settings"
       isKvGraph={false}