opt: enable improved routine dependency tracking

This commit flips `use_improved_routine_dependency_tracking` to on by
default. This means that newly-created routines will not add unnecessary
implicit insert columns to the list of dependencies, and will correctly
track dependencies in the RETURNING clause of UPDATE and DELETE statements.

Informs #145098
Informs #146414

Release note: None

Author: DrewKimball

pkg/sql/logictest/testdata/logic_test/drop_index

@@ -573,17 +573,11 @@ DROP INDEX tab_145100@tab_145100_i_idx
 statement ok
 DROP PROCEDURE proc_select_145100
 
-statement ok
-SET use_improved_routine_dependency_tracking = true;
-
 statement ok
 CREATE PROCEDURE proc_insert_145100(in_id UUID, in_i INT) LANGUAGE SQL AS $$
   INSERT INTO tab_145100 (id, i) VALUES (in_id, in_i);
 $$;
 
-statement ok
-RESET use_improved_routine_dependency_tracking;
-
 statement ok
 DROP INDEX tab_145100@tab_145100_i_idx
 

pkg/sql/logictest/testdata/logic_test/information_schema

@@ -4133,7 +4133,7 @@ unbounded_parallel_scans                                   off
 unconstrained_non_covering_index_scan_enabled              off
 unsafe_allow_triggers_modifying_cascades                   off
 use_cputs_on_non_unique_indexes                            off
-use_improved_routine_dependency_tracking                   off
+use_improved_routine_dependency_tracking                   on
 use_pre_25_2_variadic_builtins                             off
 variable_inequality_lookup_join_enabled                    on
 vector_search_beam_size                                    32

pkg/sql/logictest/testdata/logic_test/pg_catalog

@@ -3128,7 +3128,7 @@ unconstrained_non_covering_index_scan_enabled              off                 N
 unsafe_allow_triggers_modifying_cascades                   off                 NULL      NULL        NULL        string
 use_cputs_on_non_unique_indexes                            off                 NULL      NULL        NULL        string
 use_declarative_schema_changer                             on                  NULL      NULL        NULL        string
-use_improved_routine_dependency_tracking                   off                 NULL      NULL        NULL        string
+use_improved_routine_dependency_tracking                   on                  NULL      NULL        NULL        string
 use_pre_25_2_variadic_builtins                             off                 NULL      NULL        NULL        string
 variable_inequality_lookup_join_enabled                    on                  NULL      NULL        NULL        string
 vector_search_beam_size                                    32                  NULL      NULL        NULL        string
@@ -3360,7 +3360,7 @@ unconstrained_non_covering_index_scan_enabled              off                 N
 unsafe_allow_triggers_modifying_cascades                   off                 NULL  user     NULL      off                 off
 use_cputs_on_non_unique_indexes                            off                 NULL  user     NULL      off                 off
 use_declarative_schema_changer                             on                  NULL  user     NULL      on                  on
-use_improved_routine_dependency_tracking                   off                 NULL  user     NULL      off                 off
+use_improved_routine_dependency_tracking                   on                  NULL  user     NULL      on                  on
 use_pre_25_2_variadic_builtins                             off                 NULL  user     NULL      off                 off
 variable_inequality_lookup_join_enabled                    on                  NULL  user     NULL      on                  on
 vector_search_beam_size                                    32                  NULL  user     NULL      32                  32

pkg/sql/logictest/testdata/logic_test/show_source

@@ -242,7 +242,7 @@ unconstrained_non_covering_index_scan_enabled              off
 unsafe_allow_triggers_modifying_cascades                   off
 use_cputs_on_non_unique_indexes                            off
 use_declarative_schema_changer                             on
-use_improved_routine_dependency_tracking                   off
+use_improved_routine_dependency_tracking                   on
 use_pre_25_2_variadic_builtins                             off
 variable_inequality_lookup_join_enabled                    on
 vector_search_beam_size                                    32

pkg/sql/logictest/testdata/logic_test/udf_delete

@@ -311,18 +311,12 @@ CREATE TABLE t146414 (
   b INT AS (a + 1) VIRTUAL
 )
 
-statement ok
-SET use_improved_routine_dependency_tracking = true;
-
 statement ok
 CREATE FUNCTION f146414() RETURNS INT LANGUAGE SQL AS $$
   DELETE FROM t146414 WHERE a = 1 RETURNING b;
   SELECT 1;
 $$;
 
-statement ok
-RESET use_improved_routine_dependency_tracking;
-
 statement error pgcode 2BP01 pq: cannot drop column "b" because function "f146414" depends on it
 ALTER TABLE t146414 DROP COLUMN b;
 

pkg/sql/logictest/testdata/logic_test/udf_insert

@@ -298,19 +298,13 @@ CREATE TABLE t_computed (
 )
 
 # An insert routine created with use_improved_routine_dependency_tracking = true
-# should not depend on columns other than the target column "a".
-statement ok
-SET use_improved_routine_dependency_tracking = true;
-
+# (the default) should not depend on columns other than the target column "a".
 statement ok
 CREATE FUNCTION f145098() RETURNS INT LANGUAGE SQL AS $$
   INSERT INTO t_computed VALUES (100);
   SELECT 1;
 $$;
 
-statement ok
-RESET use_improved_routine_dependency_tracking;
-
 statement ok
 SELECT f145098();
 
@@ -414,18 +408,12 @@ CREATE TABLE t_hash_sharded (
   INDEX i (a ASC) USING HASH
 )
 
-statement ok
-SET use_improved_routine_dependency_tracking = true;
-
 statement ok
 CREATE FUNCTION f145098() RETURNS INT LANGUAGE SQL AS $$
   INSERT INTO t_hash_sharded VALUES (100) RETURNING crdb_internal_a_shard_16;
   SELECT 1;
 $$;
 
-statement ok
-RESET use_improved_routine_dependency_tracking;
-
 statement error pgcode 2BP01 pq: cannot drop column "crdb_internal_a_shard_16" because function "f145098" depends on it
 DROP INDEX i;
 

pkg/sql/logictest/testdata/logic_test/udf_update

@@ -335,18 +335,12 @@ CREATE TABLE t146414 (
   b INT AS (a + 1) VIRTUAL
 )
 
-statement ok
-SET use_improved_routine_dependency_tracking = true;
-
 statement ok
 CREATE FUNCTION f146414() RETURNS INT LANGUAGE SQL AS $$
   UPDATE t146414 SET a = a + 1 WHERE a = 1 RETURNING b;
   SELECT 1;
 $$;
 
-statement ok
-RESET use_improved_routine_dependency_tracking;
-
 statement error pgcode 2BP01 pq: cannot drop column "b" because function "f146414" depends on it
 ALTER TABLE t146414 DROP COLUMN b;
 

pkg/sql/logictest/testdata/logic_test/udf_upsert

@@ -275,21 +275,13 @@ CREATE TABLE table_drop (
 );
 INSERT INTO table_drop VALUES (1,2,3), (4,5,6), (7,8,9);
 
-# An insert routine created with use_improved_routine_dependency_tracking = true
-# should not depend on columns other than the target column "a". 
-statement ok
-SET use_improved_routine_dependency_tracking = true;
-
 statement ok
 DROP FUNCTION f_upsert;
 CREATE FUNCTION f_upsert() RETURNS INT LANGUAGE SQL AS $$
   UPSERT INTO table_drop (a, b) VALUES (100, 200);
   SELECT 1;
 $$;
 
-statement ok
-RESET use_improved_routine_dependency_tracking;
-
 statement ok
 DROP INDEX i;
 

pkg/sql/vars.go

@@ -4078,7 +4078,7 @@ var varGen = map[string]sessionVar{
 		Get: func(evalCtx *extendedEvalContext, _ *kv.Txn) (string, error) {
 			return formatBoolAsPostgresSetting(evalCtx.SessionData().UseImprovedRoutineDependencyTracking), nil
 		},
-		GlobalDefault: globalFalse,
+		GlobalDefault: globalTrue,
 	},
 }