catalog/lease: fix a bug in out-of-band close timestamp logic

Previously, the logic for handling descriptor updates for the locked
lease timestamps was incorrectly truncating the descriptor versions
array. This could lead to a panic due to an out-of-bounds access later
on, since the descriptor versions and descriptor IDs arrays should be
the same size. To address this, this patch ensures the correct length is
used.

Fixes: #157880
Release note: None

Author: fqazi

pkg/sql/catalog/lease/lease.go

@@ -2188,7 +2188,7 @@ func (m *Manager) processDescriptorUpdate(
 			}
 			// Remove one element from the end after.
 			entry.mu.DescriptorIDs = entry.mu.DescriptorIDs[:len(entry.mu.DescriptorIDs)-1]
-			entry.mu.DescriptorVersions = entry.mu.DescriptorVersions[:len(entry.mu.DescriptorIDs)-1]
+			entry.mu.DescriptorVersions = entry.mu.DescriptorVersions[:len(entry.mu.DescriptorVersions)-1]
 			break
 		}
 		return len(entry.mu.DescriptorIDs) == 0