quantize: rename NewQuantizedVectorSet to NewSet

Rename the NewQuantizedVectorSet method on the Quantizer interface to
NewSet. "QuantizedVector" is already implied by context and consistent
with other methdods like "QuantizeInSet".

Epic: CRDB-42943
Release note: None

Author: andy-kimball

pkg/sql/vecindex/cspann/partition.go

@@ -282,6 +282,6 @@ func (p *Partition) Clear() int {
 // CreateEmptyPartition returns an empty partition for the given quantizer and
 // level.
 func CreateEmptyPartition(quantizer quantize.Quantizer, metadata PartitionMetadata) *Partition {
-	quantizedSet := quantizer.NewQuantizedVectorSet(0, metadata.Centroid)
+	quantizedSet := quantizer.NewSet(0, metadata.Centroid)
 	return NewPartition(metadata, quantizer, quantizedSet, []ChildKey(nil), []ValueBytes(nil))
 }

pkg/sql/vecindex/cspann/quantize/quantizer.go

@@ -41,9 +41,9 @@ type Quantizer interface {
 	//       vectors.
 	QuantizeInSet(w *workspace.T, quantizedSet QuantizedVectorSet, vectors vector.Set)
 
-	// NewQuantizedVectorSet returns a new empty vector set preallocated to the
-	// number of vectors specified.
-	NewQuantizedVectorSet(capacity int, centroid vector.T) QuantizedVectorSet
+	// NewSet returns a new empty vector set preallocated to the number of vectors
+	// specified.
+	NewSet(capacity int, centroid vector.T) QuantizedVectorSet
 
 	// EstimateDistances returns the estimated distances of the query vector from
 	// each data vector represented in the given quantized vector set, as well as

pkg/sql/vecindex/cspann/quantize/quantizer_test.go

@@ -103,7 +103,7 @@ func (s *testState) estimateDistances(t *testing.T, d *datadriven.TestData) stri
 
 		// Now add the vectors one-by-one and ensure that distances and error
 		// bounds stay the same.
-		quantizedSet = quantizer.NewQuantizedVectorSet(vectors.Count, centroid)
+		quantizedSet = quantizer.NewSet(vectors.Count, centroid)
 		for i := range vectors.Count {
 			quantizer.QuantizeInSet(&s.Workspace, quantizedSet, vectors.Slice(i, 1))
 		}

pkg/sql/vecindex/cspann/quantize/rabitq.go

@@ -112,7 +112,7 @@ func (q *RaBitQuantizer) Quantize(w *workspace.T, vectors vector.Set) QuantizedV
 		centroid = vectors.Centroid(make(vector.T, vectors.Dims))
 	}
 
-	quantizedSet := q.NewQuantizedVectorSet(vectors.Count, centroid)
+	quantizedSet := q.NewSet(vectors.Count, centroid)
 	q.quantizeHelper(w, quantizedSet.(*RaBitQuantizedVectorSet), vectors)
 	return quantizedSet
 }
@@ -124,8 +124,8 @@ func (q *RaBitQuantizer) QuantizeInSet(
 	q.quantizeHelper(w, quantizedSet.(*RaBitQuantizedVectorSet), vectors)
 }
 
-// NewQuantizedVectorSet implements the Quantizer interface
-func (q *RaBitQuantizer) NewQuantizedVectorSet(capacity int, centroid vector.T) QuantizedVectorSet {
+// NewSet implements the Quantizer interface
+func (q *RaBitQuantizer) NewSet(capacity int, centroid vector.T) QuantizedVectorSet {
 	codeWidth := RaBitQCodeSetWidth(q.GetDims())
 	dataBuffer := make([]uint64, 0, capacity*codeWidth)
 	if capacity <= 1 {

pkg/sql/vecindex/cspann/quantize/rabitq_test.go

@@ -83,7 +83,7 @@ func TestRaBitQuantizerSimple(t *testing.T) {
 		for i := range centroid {
 			centroid[i] = float32(i)
 		}
-		quantizedSet := quantizer.NewQuantizedVectorSet(5, centroid).(*RaBitQuantizedVectorSet)
+		quantizedSet := quantizer.NewSet(5, centroid).(*RaBitQuantizedVectorSet)
 		require.Equal(t, centroid, quantizedSet.Centroid)
 		require.Equal(t, 0, quantizedSet.Codes.Count)
 		require.Equal(t, 2, quantizedSet.Codes.Width)
@@ -198,7 +198,7 @@ func TestRaBitQuantizerInnerProduct(t *testing.T) {
 	require.Equal(t, []float32{1.41, 3.16, 2.83}, testutils.RoundFloats(errorBounds, 2))
 
 	// Call NewQuantizedSet and ensure capacity.
-	quantizedSet = quantizer.NewQuantizedVectorSet(
+	quantizedSet = quantizer.NewSet(
 		5, quantizedSet.Centroid).(*RaBitQuantizedVectorSet)
 	require.Equal(t, 5, cap(quantizedSet.CentroidDotProducts))
 
@@ -233,7 +233,7 @@ func TestRaBitQuantizerCosine(t *testing.T) {
 	// Call NewQuantizedSet and ensure capacity.
 	centroid := slices.Clone(quantizedSet.Centroid)
 	num32.Normalize(centroid)
-	quantizedSet = quantizer.NewQuantizedVectorSet(5, centroid).(*RaBitQuantizedVectorSet)
+	quantizedSet = quantizer.NewSet(5, centroid).(*RaBitQuantizedVectorSet)
 	require.Equal(t, 5, cap(quantizedSet.CentroidDotProducts))
 
 	// Add vectors to already-created set.

pkg/sql/vecindex/cspann/quantize/unquantizer.go

@@ -69,8 +69,8 @@ func (q *UnQuantizer) QuantizeInSet(
 	unquantizedSet.AddSet(vectors)
 }
 
-// NewQuantizedVectorSet implements the Quantizer interface
-func (q *UnQuantizer) NewQuantizedVectorSet(capacity int, centroid vector.T) QuantizedVectorSet {
+// NewSet implements the Quantizer interface
+func (q *UnQuantizer) NewSet(capacity int, centroid vector.T) QuantizedVectorSet {
 	dataBuffer := make([]float32, 0, capacity*q.GetDims())
 	unquantizedSet := &UnQuantizedVectorSet{
 		Vectors: vector.MakeSetFromRawData(dataBuffer, q.GetDims()),

pkg/sql/vecindex/vecencoding/encoding_test.go

@@ -118,7 +118,7 @@ func testEncodeDecodeRoundTripImpl(t *testing.T, rnd *rand.Rand, set vector.Set)
 
 		switch quantizedSet.(type) {
 		case *quantize.UnQuantizedVectorSet:
-			decodedSet = quantizer.NewQuantizedVectorSet(set.Count, decodedMetadata.Centroid)
+			decodedSet = quantizer.NewSet(set.Count, decodedMetadata.Centroid)
 			for range set.Count {
 				remainder, err = vecencoding.DecodeUnquantizerVectorToSet(
 					remainder, decodedSet.(*quantize.UnQuantizedVectorSet),
@@ -128,7 +128,7 @@ func testEncodeDecodeRoundTripImpl(t *testing.T, rnd *rand.Rand, set vector.Set)
 			// Verify remaining bytes match trailing data
 			require.Equal(t, trailingData, testutils.NormalizeSlice(remainder))
 		case *quantize.RaBitQuantizedVectorSet:
-			decodedSet = quantizer.NewQuantizedVectorSet(set.Count, decodedMetadata.Centroid)
+			decodedSet = quantizer.NewSet(set.Count, decodedMetadata.Centroid)
 			for range set.Count {
 				remainder, err = vecencoding.DecodeRaBitQVectorToSet(
 					remainder,

pkg/sql/vecindex/vecstore/codec.go

@@ -34,7 +34,7 @@ func makeStoreCodec(quantizer quantize.Quantizer) storeCodec {
 // possible.
 func (sc *storeCodec) Init(centroid vector.T, minCapacity int) {
 	if sc.tmpVectorSet == nil {
-		sc.tmpVectorSet = sc.quantizer.NewQuantizedVectorSet(minCapacity, centroid)
+		sc.tmpVectorSet = sc.quantizer.NewSet(minCapacity, centroid)
 	} else {
 		sc.tmpVectorSet.Clear(centroid)
 	}