kvserver: fix TestUpdateLastUpdateTimesUsingStoreLiveness

arulajmani · arulajmani · commit 3735b7085697 · 2025-09-02T21:04:00.000Z
This test wasn't doing as advertised on the tin after I broke some testing knobs in 02fa61b. Epic: none Release note: None
diff --git a/pkg/kv/kvserver/replica_raft.go b/pkg/kv/kvserver/replica_raft.go
@@ -702,7 +702,7 @@ func (r *Replica) stepRaftGroupRaftMuLocked(req *kvserverpb.RaftMessageRequest)
 			// Update the lastUpdateTimes map, unless configured not to by a testing
 			// knob.
 			disableUpdateLastUpdateTimesMapOnRaftGroupStep := false
-			if r.store.TestingKnobs() == nil &&
+			if r.store.TestingKnobs() != nil &&
 				r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep != nil {
 				disableUpdateLastUpdateTimesMapOnRaftGroupStep = r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep(r)
 			}

Original file line number	Diff line number	Diff line change
`@@ -702,7 +702,7 @@ func (r Replica) stepRaftGroupRaftMuLocked(req kvserverpb.RaftMessageRequest)`
`702`	`702`	`// Update the lastUpdateTimes map, unless configured not to by a testing`
`703`	`703`	`// knob.`
`704`	`704`	`disableUpdateLastUpdateTimesMapOnRaftGroupStep := false`
`705`		`- if r.store.TestingKnobs() == nil &&`
	`705`	`+ if r.store.TestingKnobs() != nil &&`
`706`	`706`	`r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep != nil {`
`707`	`707`	`disableUpdateLastUpdateTimesMapOnRaftGroupStep = r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep(r)`
`708`	`708`	`}`