kvclient: move all TxnCoordSender logs from Dev to KvExec

Epic: none

Release note: None

Author: arulajmani

pkg/kv/kvclient/kvcoord/txn_coord_sender.go

@@ -239,10 +239,10 @@ func newRootTxnCoordSender(
 	txn.AssertInitialized(context.TODO())
 
 	if txn.Status != roachpb.PENDING {
-		log.Dev.Fatalf(context.TODO(), "unexpected non-pending txn in RootTransactionalSender: %s", txn)
+		log.KvExec.Fatalf(context.TODO(), "unexpected non-pending txn in RootTransactionalSender: %s", txn)
 	}
 	if txn.Sequence != 0 {
-		log.Dev.Fatalf(context.TODO(), "cannot initialize root txn with seq != 0: %s", txn)
+		log.KvExec.Fatalf(context.TODO(), "cannot initialize root txn with seq != 0: %s", txn)
 	}
 
 	tcs := &TxnCoordSender{
@@ -380,7 +380,7 @@ func newLeafTxnCoordSender(
 	txn.AssertInitialized(context.TODO())
 
 	if txn.Status != roachpb.PENDING {
-		log.Dev.Fatalf(context.TODO(), "unexpected non-pending txn in LeafTransactionalSender: %s", tis)
+		log.KvExec.Fatalf(context.TODO(), "unexpected non-pending txn in LeafTransactionalSender: %s", tis)
 	}
 
 	tcs := &TxnCoordSender{
@@ -537,7 +537,7 @@ func (tc *TxnCoordSender) Send(
 
 	// Associate the txnID with the trace.
 	if tc.mu.txn.ID == (uuid.UUID{}) {
-		log.Dev.Fatalf(ctx, "cannot send transactional request through unbound TxnCoordSender")
+		log.KvExec.Fatalf(ctx, "cannot send transactional request through unbound TxnCoordSender")
 	}
 	if sp.IsVerbose() {
 		sp.SetTag("txnID", attribute.StringValue(tc.mu.txn.ID.String()))
@@ -674,7 +674,7 @@ func (tc *TxnCoordSender) Send(
 // docs/RFCS/20200811_non_blocking_txns.md.
 func (tc *TxnCoordSender) maybeCommitWait(ctx context.Context, deferred bool) error {
 	if tc.mu.txn.Status != roachpb.PREPARED && tc.mu.txn.Status != roachpb.COMMITTED {
-		log.Dev.Fatalf(ctx, "maybeCommitWait called when not prepared/committed")
+		log.KvExec.Fatalf(ctx, "maybeCommitWait called when not prepared/committed")
 	}
 	if tc.mu.commitWaitDeferred && !deferred {
 		// If this is an automatic commit-wait call and the user of this
@@ -787,7 +787,7 @@ func (tc *TxnCoordSender) maybeRejectClientLocked(
 			// unexpected for it to find the transaction already in a txnFinalized
 			// state. This may be a bug, so log a stack trace.
 			stack := debugutil.Stack()
-			log.Dev.Errorf(ctx, "%s. stack:\n%s", msg, stack)
+			log.KvExec.Errorf(ctx, "%s. stack:\n%s", msg, stack)
 		}
 		reason := kvpb.TransactionStatusError_REASON_UNKNOWN
 		if tc.mu.txn.Status == roachpb.COMMITTED {
@@ -1028,7 +1028,7 @@ func (tc *TxnCoordSender) updateStateLocked(
 		if errTxnID != txnID {
 			// KV should not return errors for transactions other than the one in
 			// the BatchRequest.
-			log.Dev.Fatalf(ctx, "retryable error for the wrong txn. ba.Txn: %s. pErr: %s",
+			log.KvExec.Fatalf(ctx, "retryable error for the wrong txn. ba.Txn: %s. pErr: %s",
 				ba.Txn, pErr)
 		}
 		return kvpb.NewError(tc.handleRetryableErrLocked(ctx, pErr))
@@ -1095,7 +1095,7 @@ func sanityCheckErrWithTxn(
 			Detail: "you have encountered a known bug in CockroachDB, please consider " +
 				"reporting on the Github issue or reach out via Support.",
 		}))
-	log.Dev.Warningf(ctx, "%v", err)
+	log.KvExec.Warningf(ctx, "%v", err)
 	return err
 }
 
@@ -1479,7 +1479,7 @@ func (tc *TxnCoordSender) UpdateRootWithLeafFinalState(
 	defer tc.mu.Unlock()
 
 	if tc.mu.txn.ID == (uuid.UUID{}) {
-		log.Dev.Fatalf(ctx, "cannot UpdateRootWithLeafFinalState on unbound TxnCoordSender. input id: %s", tfs.Txn.ID)
+		log.KvExec.Fatalf(ctx, "cannot UpdateRootWithLeafFinalState on unbound TxnCoordSender. input id: %s", tfs.Txn.ID)
 	}
 
 	// Sanity check: don't combine if the tfs is for a different txn ID.

pkg/kv/kvclient/kvcoord/txn_interceptor_heartbeater.go

@@ -317,11 +317,11 @@ func (h *txnHeartbeater) closeLocked() {
 // startHeartbeatLoopLocked starts a heartbeat loop in a different goroutine.
 func (h *txnHeartbeater) startHeartbeatLoopLocked(ctx context.Context) {
 	if h.loopInterval < 0 {
-		log.Dev.Infof(ctx, "coordinator heartbeat loop disabled")
+		log.KvExec.Infof(ctx, "coordinator heartbeat loop disabled")
 		return
 	}
 	if h.mu.loopStarted {
-		log.Dev.Fatal(ctx, "attempting to start a second heartbeat loop")
+		log.KvExec.Fatal(ctx, "attempting to start a second heartbeat loop")
 	}
 	log.VEventf(ctx, 2, kvbase.SpawningHeartbeatLoopMsg)
 	h.mu.loopStarted = true
@@ -459,15 +459,15 @@ func (h *txnHeartbeater) heartbeatLocked(ctx context.Context) bool {
 		// client needs to send a rollback.
 		return false
 	case roachpb.COMMITTED:
-		log.Dev.Fatalf(ctx, "txn committed but heartbeat loop hasn't been signaled to stop: %s", h.mu.txn)
+		log.KvExec.Fatalf(ctx, "txn committed but heartbeat loop hasn't been signaled to stop: %s", h.mu.txn)
 	default:
-		log.Dev.Fatalf(ctx, "unexpected txn status in heartbeat loop: %s", h.mu.txn)
+		log.KvExec.Fatalf(ctx, "unexpected txn status in heartbeat loop: %s", h.mu.txn)
 	}
 
 	// Clone the txn in order to put it in the heartbeat request.
 	txn := h.mu.txn.Clone()
 	if txn.Key == nil {
-		log.Dev.Fatalf(ctx, "attempting to heartbeat txn without anchor key: %v", txn)
+		log.KvExec.Fatalf(ctx, "attempting to heartbeat txn without anchor key: %v", txn)
 	}
 	ba := &kvpb.BatchRequest{}
 	ba.Txn = txn
@@ -632,7 +632,7 @@ func (h *txnHeartbeater) abortTxnAsyncLocked(ctx context.Context) {
 		TaskName: taskName,
 	})
 	if err != nil {
-		log.Dev.Warningf(ctx, "%v", err)
+		log.KvExec.Warningf(ctx, "%v", err)
 		h.metrics.AsyncRollbacksFailed.Inc(1)
 		return
 	}

pkg/kv/kvclient/kvcoord/txn_interceptor_pipeliner.go

@@ -490,10 +490,10 @@ func (tp *txnPipeliner) attachLocksToEndTxn(
 
 	if log.V(3) {
 		for _, intent := range et.LockSpans {
-			log.Dev.Infof(ctx, "intent: [%s,%s)", intent.Key, intent.EndKey)
+			log.KvExec.Infof(ctx, "intent: [%s,%s)", intent.Key, intent.EndKey)
 		}
 		for _, write := range et.InFlightWrites {
-			log.Dev.Infof(ctx, "in-flight: %d:%s (%s)", write.Sequence, write.Key, write.Strength)
+			log.KvExec.Infof(ctx, "in-flight: %d:%s (%s)", write.Sequence, write.Key, write.Strength)
 		}
 	}
 	return ba, nil
@@ -736,7 +736,7 @@ func (tp *txnPipeliner) updateLockTracking(
 	// fine for now, but we add some observability to be aware of this happening.
 	if tp.ifWrites.byteSize() > maxBytes {
 		if tp.inflightOverBudgetEveryN.ShouldLog() || log.ExpensiveLogEnabled(ctx, 2) {
-			log.Dev.Warningf(ctx, "a transaction's in-flight writes and locking reads have "+
+			log.KvExec.Warningf(ctx, "a transaction's in-flight writes and locking reads have "+
 				"exceeded the intent tracking limit (kv.transaction.max_intents_bytes). "+
 				"in-flight writes and locking reads size: %d bytes, txn: %s, ba: %s",
 				tp.ifWrites.byteSize(), ba.Txn, ba.Summary())
@@ -748,7 +748,7 @@ func (tp *txnPipeliner) updateLockTracking(
 	// number of ranged locking reads before sending the request.
 	if rejectTxnMaxCount > 0 && tp.writeCount > rejectTxnMaxCount {
 		if tp.inflightOverBudgetEveryN.ShouldLog() || log.ExpensiveLogEnabled(ctx, 2) {
-			log.Dev.Warningf(ctx, "a transaction has exceeded the maximum number of writes "+
+			log.KvExec.Warningf(ctx, "a transaction has exceeded the maximum number of writes "+
 				"allowed by kv.transaction.max_intents_and_locks: "+
 				"count: %d, txn: %s, ba: %s", tp.writeCount, ba.Txn, ba.Summary())
 		}
@@ -782,7 +782,7 @@ func (tp *txnPipeliner) updateLockTracking(
 	condensed := tp.lockFootprint.maybeCondense(ctx, tp.riGen, locksBudget)
 	if condensed && !alreadyCondensed {
 		if tp.condensedIntentsEveryN.ShouldLog() || log.ExpensiveLogEnabled(ctx, 2) {
-			log.Dev.Warningf(ctx,
+			log.KvExec.Warningf(ctx,
 				"a transaction has hit the intent tracking limit (kv.transaction.max_intents_bytes); "+
 					"is it a bulk operation? Intent cleanup will be slower. txn: %s ba: %s",
 				ba.Txn, ba.Summary())
@@ -878,7 +878,7 @@ func (tp *txnPipeliner) updateLockTrackingInner(
 					// Record any writes that were performed asynchronously. We'll
 					// need to prove that these succeeded sometime before we commit.
 					if span.EndKey != nil {
-						log.Dev.Fatalf(ctx, "unexpected multi-key intent pipelined")
+						log.KvExec.Fatalf(ctx, "unexpected multi-key intent pipelined")
 					}
 					tp.ifWrites.insert(span.Key, seq, str)
 				} else {

pkg/kv/kvclient/kvcoord/txn_interceptor_write_buffer.go

@@ -601,7 +601,7 @@ func (twb *txnWriteBuffer) adjustError(
 				// For requests that were not transformed, attributing an error to them
 				// shouldn't confuse the client.
 				if baIdx == pErr.Index.Index && record.transformed {
-					log.Dev.Warningf(ctx, "error index %d is part of a transformed request", pErr.Index.Index)
+					log.KvExec.Warningf(ctx, "error index %d is part of a transformed request", pErr.Index.Index)
 					pErr.Index = nil
 					return pErr
 				} else if baIdx == pErr.Index.Index {
@@ -626,7 +626,7 @@ func (twb *txnWriteBuffer) adjustErrorUponFlush(
 		if pErr.Index.Index < int32(numBuffered) {
 			// If the error belongs to a request because part of the buffer flush, nil
 			// out the index.
-			log.Dev.Warningf(ctx, "error index %d is part of the buffer flush", pErr.Index.Index)
+			log.KvExec.Warningf(ctx, "error index %d is part of the buffer flush", pErr.Index.Index)
 			pErr.Index = nil
 		} else {
 			// Otherwise, adjust the error index to hide the impact of any flushed
@@ -1313,7 +1313,7 @@ func (twb *txnWriteBuffer) mergeResponseWithRequestRecords(
 	ctx context.Context, rr requestRecords, br *kvpb.BatchResponse,
 ) (_ *kvpb.BatchResponse, pErr *kvpb.Error) {
 	if rr.Empty() && br == nil {
-		log.Dev.Fatal(ctx, "unexpectedly found no transformations and no batch response")
+		log.KvExec.Fatal(ctx, "unexpectedly found no transformations and no batch response")
 	} else if rr.Empty() {
 		return br, nil
 	}
@@ -1325,7 +1325,7 @@ func (twb *txnWriteBuffer) mergeResponseWithRequestRecords(
 		brResp := kvpb.ResponseUnion{}
 		if !record.stripped {
 			if len(br.Responses) == 0 {
-				log.Dev.Fatal(ctx, "unexpectedly found a non-stripped request and no batch response")
+				log.KvExec.Fatal(ctx, "unexpectedly found a non-stripped request and no batch response")
 			}
 			// If the request wasn't stripped from the batch we sent to KV, we
 			// received a response for it, which then needs to be combined with