Merge #144444

144444: vecindex: convert vecstore for use with non-transactional fixups r=drewkimball a=andy-kimball

Previously, the vecstore was not compatible with the new non-transactional
split operation, because it did not implement the upgraded cspann.Store
interface. This commit completes that implementation, including the new
Try methods, as well as making some changes to the semantics of the
methods on cspann.Txn.

Epic: CRDB-42943
Release note: None


Co-authored-by: Andrew Kimball <[email protected]>

Author: craig[bot]

pkg/cmd/vecbench/main.go

@@ -439,7 +439,6 @@ func newVectorProvider(
 		MinPartitionSize: minPartitionSize,
 		MaxPartitionSize: maxPartitionSize,
 		BaseBeamSize:     *flagBeamSize,
-		UseNewFixups:     true,
 	}
 
 	if *flagMemStore {

pkg/sql/vecindex/cspann/BUILD.bazel

@@ -24,7 +24,6 @@ go_library(
         "partition_metadata.go",
         "search_set.go",
         "searcher.go",
-        "split_data.go",
         "store.go",
         "store_errors.go",
     ],
@@ -55,7 +54,6 @@ go_test(
         "cspannpb_test.go",
         "fixup_processor_test.go",
         "fixup_split_test.go",
-        "fixup_worker_test.go",
         "index_stats_test.go",
         "index_test.go",
         "kmeans_test.go",

pkg/sql/vecindex/cspann/commontest/BUILD.bazel

@@ -12,8 +12,6 @@ go_library(
         "//pkg/sql/vecindex/cspann",
         "//pkg/sql/vecindex/cspann/quantize",
         "//pkg/sql/vecindex/cspann/testutils",
-        "//pkg/sql/vecindex/cspann/workspace",
-        "//pkg/util/num32",
         "//pkg/util/vector",
         "@com_github_cockroachdb_errors//:errors",
         "@com_github_stretchr_testify//require",