Skip to content

Commit 3acc730

Browse files
craig[bot]Dedej-Bergin
andcommitted
Merge #145254
145254: roachtest: ignore flaky psycopg tests r=Dedej-Bergin a=Dedej-Bergin Added these flaky tests to `psycopgIgnoreList`. ``` tests.pool.test_pool_common.test_queue_timeout_override tests.pool.test_pool_async.test_shrink[asyncio] tests.pool.test_pool_common_async.test_queue_timeout[asyncio-AsyncNullConnectionPool] tests.pool.test_pool_common_async.test_queue_timeout_override[asyncio-AsyncNullConnectionPool] tests.pool.test_pool_common_async.test_stats_measures[asyncio-AsyncNullConnectionPool] ``` Fixes: #144532 Fixes: #144358 Release note: none Co-authored-by: Bergin Dedej <[email protected]>
2 parents 0229d90 + 37c370b commit 3acc730

File tree

1 file changed

+32
-27
lines changed

1 file changed

+32
-27
lines changed

pkg/cmd/roachtest/tests/psycopg_blocklist.go

Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -19,31 +19,36 @@ package tests
1919
var psycopgBlockList = blocklist{}
2020

2121
var psycopgIgnoreList = blocklist{
22-
`tests.pool.test_pool.test_connect_check_timeout`: "requires insecure mode",
23-
`tests.pool.test_pool.test_reconnect`: "requires insecure mode",
24-
`tests.pool.test_pool.test_reconnect_after_grow_failed`: "requires insecure mode",
25-
`tests.pool.test_pool.test_reconnect_failure[False]`: "requires insecure mode",
26-
`tests.pool.test_pool.test_refill_on_check`: "requires insecure mode",
27-
`tests.pool.test_pool.test_stats_connect`: "requires insecure mode",
28-
`tests.pool.test_pool_async.test_connect_check_timeout[asyncio]`: "requires insecure mode",
29-
`tests.pool.test_pool_async.test_reconnect[asyncio]`: "requires insecure mode",
30-
`tests.pool.test_pool_async.test_reconnect_after_grow_failed[asyncio]`: "requires insecure mode",
31-
`tests.pool.test_pool_async.test_reconnect_failure[asyncio-False]`: "requires insecure mode",
32-
`tests.pool.test_pool_async.test_reconnect_failure[asyncio-True]`: "requires insecure mode",
33-
`tests.pool.test_pool_async.test_refill_on_check[asyncio]`: "requires insecure mode",
34-
`tests.pool.test_pool_async.test_stats_connect[asyncio]`: "requires insecure mode",
35-
`tests.pool.test_pool_common.test_queue[NullConnectionPool]`: "test is timing dependent, see https://github.com/cockroachdb/cockroach/issues/143491",
36-
`tests.pool.test_pool_common.test_setup_no_timeout[ConnectionPool]`: "requires insecure mode",
37-
`tests.pool.test_pool_common.test_setup_no_timeout[NullConnectionPool]`: "requires insecure mode",
38-
`tests.pool.test_pool_common.test_stats_usage[NullConnectionPool]`: "test is timing dependent, see https://github.com/cockroachdb/cockroach/issues/143491",
39-
`tests.pool.test_pool_common_async.test_queue[asyncio-AsyncNullConnectionPool]`: "requires insecure mode",
40-
`tests.pool.test_pool_common_async.test_setup_no_timeout[asyncio-AsyncConnectionPool]`: "requires insecure mode",
41-
`tests.pool.test_pool_common_async.test_setup_no_timeout[asyncio-AsyncNullConnectionPool]`: "requires insecure mode",
42-
`tests.pool.test_pool_common_async.test_stats_usage[asyncio-AsyncNullConnectionPool]`: "requires insecure mode",
43-
`tests.pool.test_pool_null.test_stats_connect`: "requires insecure mode",
44-
`tests.pool.test_pool_null_async.test_stats_connect[asyncio]`: "requires insecure mode",
45-
`tests.test_connection.test_cancel_safe_error`: "requires insecure mode",
46-
`tests.test_connection_async.test_cancel_safe_error[asyncio]`: "requires insecure mode",
47-
`tests.test_generators.test_connect_operationalerror_pgconn`: "requires insecure mode",
48-
"tests.test_connection.TestConnectionInfo.test_backend_pid": "we return -1 for pg_backend_pid()",
22+
`tests.pool.test_pool.test_connect_check_timeout`: "requires insecure mode",
23+
`tests.pool.test_pool.test_reconnect`: "requires insecure mode",
24+
`tests.pool.test_pool.test_reconnect_after_grow_failed`: "requires insecure mode",
25+
`tests.pool.test_pool.test_reconnect_failure[False]`: "requires insecure mode",
26+
`tests.pool.test_pool.test_refill_on_check`: "requires insecure mode",
27+
`tests.pool.test_pool.test_stats_connect`: "requires insecure mode",
28+
`tests.pool.test_pool_async.test_connect_check_timeout[asyncio]`: "requires insecure mode",
29+
`tests.pool.test_pool_async.test_reconnect[asyncio]`: "requires insecure mode",
30+
`tests.pool.test_pool_async.test_reconnect_after_grow_failed[asyncio]`: "requires insecure mode",
31+
`tests.pool.test_pool_async.test_reconnect_failure[asyncio-False]`: "requires insecure mode",
32+
`tests.pool.test_pool_async.test_reconnect_failure[asyncio-True]`: "requires insecure mode",
33+
`tests.pool.test_pool_async.test_refill_on_check[asyncio]`: "requires insecure mode",
34+
`tests.pool.test_pool_async.test_shrink[asyncio]`: "see https://github.com/cockroachdb/cockroach/issues/144532",
35+
`tests.pool.test_pool_async.test_stats_connect[asyncio]`: "requires insecure mode",
36+
`tests.pool.test_pool_common.test_queue[NullConnectionPool]`: "test is timing dependent, see https://github.com/cockroachdb/cockroach/issues/143491",
37+
`tests.pool.test_pool_common.test_queue_timeout_override`: "see https://github.com/cockroachdb/cockroach/issues/144532",
38+
`tests.pool.test_pool_common.test_setup_no_timeout[ConnectionPool]`: "requires insecure mode",
39+
`tests.pool.test_pool_common.test_setup_no_timeout[NullConnectionPool]`: "requires insecure mode",
40+
`tests.pool.test_pool_common.test_stats_usage[NullConnectionPool]`: "test is timing dependent, see https://github.com/cockroachdb/cockroach/issues/143491",
41+
`tests.pool.test_pool_common_async.test_queue[asyncio-AsyncNullConnectionPool]`: "requires insecure mode",
42+
`tests.pool.test_pool_common_async.test_queue_timeout[asyncio-AsyncNullConnectionPool]`: "see https://github.com/cockroachdb/cockroach/issues/144532",
43+
`tests.pool.test_pool_common_async.test_queue_timeout_override[asyncio-AsyncNullConnectionPool]`: "see https://github.com/cockroachdb/cockroach/issues/144532",
44+
`tests.pool.test_pool_common_async.test_setup_no_timeout[asyncio-AsyncConnectionPool]`: "requires insecure mode",
45+
`tests.pool.test_pool_common_async.test_setup_no_timeout[asyncio-AsyncNullConnectionPool]`: "requires insecure mode",
46+
`tests.pool.test_pool_common_async.test_stats_measures[asyncio-AsyncNullConnectionPool]`: "see https://github.com/cockroachdb/cockroach/issues/144532",
47+
`tests.pool.test_pool_common_async.test_stats_usage[asyncio-AsyncNullConnectionPool]`: "requires insecure mode",
48+
`tests.pool.test_pool_null.test_stats_connect`: "requires insecure mode",
49+
`tests.pool.test_pool_null_async.test_stats_connect[asyncio]`: "requires insecure mode",
50+
`tests.test_connection.test_cancel_safe_error`: "requires insecure mode",
51+
`tests.test_connection_async.test_cancel_safe_error[asyncio]`: "requires insecure mode",
52+
`tests.test_generators.test_connect_operationalerror_pgconn`: "requires insecure mode",
53+
"tests.test_connection.TestConnectionInfo.test_backend_pid": "we return -1 for pg_backend_pid()",
4954
}

0 commit comments

Comments
 (0)