Merge #147349 #148242

147349: roachtest: use failure injection library for disk stalls  r=herkolategan a=DarrylWong

This change switches the roachtestutil disk staller to using the failureinjection library instead. We keep the roachtestutil disk staller interface for now, as it still provides some additional cluster spec validation, but will be replaced completely in the future.

Informs: #138970
Release note: none

148242: crosscluster: do not panic on poorly formatted inline certs r=jeffswenson,stevendanna a=kev-cao

Previously, when parsing inline SSL certificates in an external connection, if the certificate was not formatted correctly we would run into a panic from a nil pointer. This fixes the parser to properly surface an error instead of crashing.

Epic: CRDB-50820

Fixes: #145949

Release note: CockroachDB now raises an error when encountering improper inline SSL credentials instead of panicking.

Co-authored-by: DarrylWong <[email protected]>
Co-authored-by: Kevin Cao <[email protected]>

Author: 3 people

pkg/cmd/roachtest/BUILD.bazel

@@ -48,6 +48,7 @@ go_library(
         "//pkg/roachprod/cloud",
         "//pkg/roachprod/config",
         "//pkg/roachprod/errors",
+        "//pkg/roachprod/failureinjection/failures",
         "//pkg/roachprod/install",
         "//pkg/roachprod/logger",
         "//pkg/roachprod/prometheus",

pkg/cmd/roachtest/cluster.go

@@ -42,6 +42,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/roachprod"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/cloud"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/config"
+	"github.com/cockroachdb/cockroach/pkg/roachprod/failureinjection/failures"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/install"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/logger"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/prometheus"
@@ -3311,3 +3312,20 @@ func (c *clusterImpl) RegisterClusterHook(
 		panic(fmt.Sprintf("unknown test hook type %v", hookType))
 	}
 }
+
+// GetFailer returns a *failures.Failer for the given failure mode name. Used
+// for conducting failure injection on a cluster.
+func (c *clusterImpl) GetFailer(
+	l *logger.Logger,
+	nodes option.NodeListOption,
+	failureModeName string,
+	opts ...failures.ClusterOptionFunc,
+) (*failures.Failer, error) {
+	fr := failures.GetFailureRegistry()
+	clusterOpts := append(opts, failures.Secure(c.IsSecure()))
+	failer, err := fr.GetFailer(c.MakeNodes(nodes), failureModeName, l, clusterOpts...)
+	if err != nil {
+		return nil, err
+	}
+	return failer, err
+}

pkg/cmd/roachtest/cluster/BUILD.bazel

@@ -15,6 +15,7 @@ go_library(
         "//pkg/cmd/roachtest/option",
         "//pkg/cmd/roachtest/spec",
         "//pkg/roachprod",
+        "//pkg/roachprod/failureinjection/failures",
         "//pkg/roachprod/install",
         "//pkg/roachprod/logger",
         "//pkg/roachprod/prometheus",

pkg/cmd/roachtest/cluster/cluster_interface.go

@@ -15,6 +15,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/option"
 	"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/spec"
 	"github.com/cockroachdb/cockroach/pkg/roachprod"
+	"github.com/cockroachdb/cockroach/pkg/roachprod/failureinjection/failures"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/install"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/logger"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/prometheus"
@@ -215,4 +216,6 @@ type Cluster interface {
 	GetPreemptedVMs(ctx context.Context, l *logger.Logger) ([]vm.PreemptedVM, error)
 
 	RegisterClusterHook(hookName string, hookType option.ClusterHookType, timeout time.Duration, hook func(context.Context) error)
+
+	GetFailer(l *logger.Logger, nodes option.NodeListOption, failureModeName string, opts ...failures.ClusterOptionFunc) (*failures.Failer, error)
 }

pkg/cmd/roachtest/clusterstats/BUILD.bazel

@@ -21,6 +21,7 @@ go_library(
         # Required for generated mocks
         "//pkg/roachprod",  #keep
         # Required for generated mocks
+        "//pkg/roachprod/failureinjection/failures",  #keep
         "//pkg/roachprod/install",  #keep
         "//pkg/roachprod/logger",
         "//pkg/roachprod/prometheus",