Skip to content

Commit 3b61ff1

Browse files
committed
changefeedccl/schemafeed: add verbose logging to table event filter
This patch adds some verbose logging to the schema feed table event filter to make it easier to debug missing schema feed events. Release note: None
1 parent 84476ac commit 3b61ff1

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

pkg/ccl/changefeedccl/changefeed_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6253,6 +6253,8 @@ func TestChangefeedTruncateOrDrop(t *testing.T) {
62536253
defer leaktest.AfterTest(t)()
62546254
defer log.Scope(t).Close(t)
62556255

6256+
require.NoError(t, log.SetVModule("table_event_filter=2"))
6257+
62566258
assertFailuresCounter := func(t *testing.T, m *Metrics, exp int64) {
62576259
t.Helper()
62586260
// If this changefeed is running as a job, we anticipate that it will move

pkg/ccl/changefeedccl/schemafeed/table_event_filter.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
1515
"github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb"
1616
"github.com/cockroachdb/cockroach/pkg/util/intsets"
17+
"github.com/cockroachdb/cockroach/pkg/util/log"
1718
"github.com/cockroachdb/errors"
1819
)
1920

@@ -123,9 +124,16 @@ type tableEventFilter map[tableEventType]bool
123124

124125
func (filter tableEventFilter) shouldFilter(
125126
ctx context.Context, e TableEvent, targets changefeedbase.Targets,
126-
) (bool, error) {
127+
) (ok bool, _ error) {
127128
et := classifyTableEvent(e)
128129

130+
if log.V(2) {
131+
log.Infof(ctx, "table event %v classified as %v", e, et)
132+
defer func() {
133+
log.Infof(ctx, "should filter table event %v: %t", e, ok)
134+
}()
135+
}
136+
129137
// Truncation events are not ignored and return an error.
130138
if et.Contains(tableEventTruncate) {
131139
return false, errors.Errorf(`"%s" was truncated`, e.Before.GetName())

0 commit comments

Comments
 (0)