base: remove TODOTestTenantDisabled

All test tenant skips now have specific issues.

Release note: None

Author: yuzefovich

pkg/backup/datadriven_test.go

@@ -344,7 +344,8 @@ func (d *datadrivenTestState) getSQLDBForVC(
 //   - testingKnobCfg: specifies a key to a hardcoded testingKnob configuration
 //
 //   - disable-tenant : ensures the test is never run in a multitenant environment by
-//     setting testserverargs.DefaultTestTenant to base.TODOTestTenantDisabled.
+//     setting testserverargs.DefaultTestTenant to
+//     base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142798).
 //
 //   - "upgrade-cluster version=<version>"
 //     Upgrade the cluster version of the active cluster to the passed in

pkg/base/test_server_args.go

@@ -379,11 +379,6 @@ var (
 	// to use TestTenantProbabilistic or TestTenantProbabilisticOnly.
 	SharedTestTenantAlwaysEnabled = DefaultTestTenantOptions{testBehavior: ttEnabled | ttSharedProcess, allowAdditionalTenants: true}
 
-	// TODOTestTenantDisabled should not be used anymore. Use the
-	// other values instead.
-	// TODO(#76378): Review existing tests and use the proper value instead.
-	TODOTestTenantDisabled = DefaultTestTenantOptions{testBehavior: ttDisabled, allowAdditionalTenants: true}
-
 	// TestRequiresExplicitSQLConnection is used when the test is unable to pass
 	// the cluster as an option in the connection URL. The test could still
 	// probabilistically use an external process test virtual cluster, but

pkg/cmd/github-pull-request-make/testdata/new_test.diff

@@ -31,8 +31,7 @@ index 6c20afaef23..879494bdadd 100644
 +
 +       ctx := context.Background()
 +
-+       srv, db, _ := serverutils.StartServer(t, base.TestServerArgs{DefaultTestTenant: base.TODOTestTenantDis
-abled})
++       srv, db, _ := serverutils.StartServer(t, base.TestServerArgs{})
 +       defer srv.Stopper().Stop(ctx)
 +
 +       sql := sqlutils.MakeSQLRunner(db)

pkg/sql/schemachanger/sctest/test_server_factory.go

@@ -117,8 +117,7 @@ func (f SingleNodeTestClusterFactory) Start(ctx context.Context, t *testing.T) T
 				UseTransactionalDescIDGenerator: true,
 			},
 		},
-		// TODO(postamar): remove this
-		DefaultTestTenant: base.TODOTestTenantDisabled,
+		DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142814),
 	}
 	if f.server != nil {
 		args.Knobs.Server = f.server

pkg/testutils/lint/lint_test.go

@@ -2506,94 +2506,6 @@ func TestLint(t *testing.T) {
 		}
 	})
 
-	// TODO(yuzefovich): remove this linter when #76378 is resolved.
-	t.Run("TestTODOTestTenantDisabled", func(t *testing.T) {
-		t.Parallel()
-		cmd, stderr, filter, err := dirCmd(
-			pkgDir,
-			"git",
-			"grep",
-			"-nE",
-			`base\.TODOTestTenantDisabled`,
-			"--",
-			"*",
-			":!backup/backup_test.go",
-			":!backup/backuprand/backup_rand_test.go",
-			":!backup/backuptestutils/testutils.go",
-			":!backup/create_scheduled_backup_test.go",
-			":!backup/datadriven_test.go",
-			":!backup/full_cluster_backup_restore_test.go",
-			":!backup/restore_old_versions_test.go",
-			":!backup/utils_test.go",
-			":!ccl/changefeedccl/alter_changefeed_test.go",
-			":!ccl/changefeedccl/changefeed_test.go",
-			":!ccl/changefeedccl/helpers_test.go",
-			":!ccl/changefeedccl/parquet_test.go",
-			":!ccl/changefeedccl/scheduled_changefeed_test.go",
-			":!ccl/kvccl/kvfollowerreadsccl/boundedstaleness_test.go",
-			":!ccl/kvccl/kvfollowerreadsccl/followerreads_test.go",
-			":!ccl/kvccl/kvtenantccl/upgradeccl/tenant_upgrade_test.go",
-			":!ccl/multiregionccl/cold_start_latency_test.go",
-			":!ccl/multiregionccl/datadriven_test.go",
-			":!ccl/multiregionccl/multiregionccltestutils/testutils.go",
-			":!ccl/multiregionccl/regional_by_row_test.go",
-			":!ccl/multiregionccl/unique_test.go",
-			":!ccl/partitionccl/drop_test.go",
-			":!ccl/partitionccl/partition_test.go",
-			":!ccl/partitionccl/zone_test.go",
-			":!ccl/serverccl/admin_test.go",
-			":!crosscluster/replicationtestutils/testutils.go",
-			":!crosscluster/streamclient/partitioned_stream_client_test.go",
-			":!crosscluster/physical/replication_random_client_test.go",
-			":!crosscluster/physical/stream_ingestion_job_test.go",
-			":!crosscluster/physical/stream_ingestion_processor_test.go",
-			":!crosscluster/producer/producer_job_test.go",
-			":!crosscluster/producer/replication_stream_test.go",
-			":!ccl/workloadccl/allccl/all_test.go",
-			":!cli/democluster/demo_cluster.go",
-			":!cli/democluster/demo_cluster_test.go",
-			":!server/application_api/config_test.go",
-			":!server/application_api/dbconsole_test.go",
-			":!server/application_api/events_test.go",
-			":!server/application_api/insights_test.go",
-			":!server/application_api/jobs_test.go",
-			":!server/application_api/query_plan_test.go",
-			":!server/application_api/security_test.go",
-			":!server/application_api/zcfg_test.go",
-			":!server/grpc_gateway_test.go",
-			":!server/multi_store_test.go",
-			":!server/storage_api/decommission_test.go",
-			":!server/storage_api/health_test.go",
-			":!server/storage_api/rangelog_test.go",
-			":!server/testserver.go",
-			":!sql/schemachanger/sctest/test_server_factory.go",
-			":!sql/server_params_test.go",
-			":!sql/ttl/ttljob/ttljob_test.go",
-			":!testutils/lint/lint_test.go",
-			":!ts/server_test.go",
-			":!upgrade/upgrademanager/manager_external_test.go",
-		)
-		if err != nil {
-			t.Fatal(err)
-		}
-
-		if err := cmd.Start(); err != nil {
-			t.Fatal(err)
-		}
-
-		if err := stream.ForEach(filter, func(s string) {
-			t.Errorf("\n%s <- new usages of base.TODOTestTenantDisabled are forbidden", s)
-		}); err != nil {
-			t.Error(err)
-		}
-
-		if err := cmd.Wait(); err != nil {
-			if out := stderr.String(); len(out) > 0 {
-				t.Fatalf("err=%s, stderr=%s", err, out)
-			}
-		}
-	})
-
 	// This linter prohibits ignoring the context.CancelFunc that is returned on
 	// stop.Stopper.WithCancelOnQuiesce call (which can result in a memory
 	// leak).