backup: compaction dist sql processor now handles errors correctly

kev-cao · kev-cao · commit 3bcdb426cbb5 · 2025-04-17T14:45:58.000-04:00
Previously, when one of the processor nodes in the backup compaction
dist SQL plan ran into an error, the compaction job would continue on,
blissfully unaware of the error. This would result in faulty job
successes. This patch fixes the coordinator node so that errors from
other nodes is properly handled and surfaced.

Epic: None

Release note: None
diff --git a/pkg/backup/compaction_dist.go b/pkg/backup/compaction_dist.go
@@ -130,7 +130,7 @@ func runCompactionPlan(
 
 	evalCtxCopy := execCtx.ExtendedEvalContext().Copy()
 	dsp.Run(ctx, planCtx, nil /* txn */, plan, recv, evalCtxCopy, nil /* finishedSetupFn */)
-	return nil
+	return rowResultWriter.Err()
 }
 
 // createCompactionPlan creates an un-finalized physical plan that will

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ func runCompactionPlan(`
`130`	`130`
`131`	`131`	`evalCtxCopy := execCtx.ExtendedEvalContext().Copy()`
`132`	`132`	`dsp.Run(ctx, planCtx, nil /* txn /, plan, recv, evalCtxCopy, nil / finishedSetupFn */)`
`133`		`- return nil`
	`133`	`+ return rowResultWriter.Err()`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`// createCompactionPlan creates an un-finalized physical plan that will`