stmtdiagnostics: don't create statement dignostics request for txn diagnostics

kyle-a-wong · kyle-a-wong · commit 3e01ba6c2d06 · 2025-10-02T15:21:51.000-05:00
Previously, `innerInsertStatementDiagnostics` was creating new statement diagnostics requests when a transaction diagnostics bundle was being created. Now, these new statement requests will no longer be created. Epic: CRDB-53541 Release note: None
diff --git a/pkg/sql/stmtdiagnostics/statement_diagnostics.go b/pkg/sql/stmtdiagnostics/statement_diagnostics.go
@@ -653,7 +653,7 @@ func (r *Registry) innerInsertStatementDiagnostics(
 		if err != nil {
 			return diagID, err
 		}
-	} else {
+	} else if txnDiagnosticId == 0 {
 		// Insert a completed request into system.statement_diagnostics_request.
 		// This is necessary because the UI uses this table to discover completed
 		// diagnostics.

Original file line number	Diff line number	Diff line change
`@@ -653,7 +653,7 @@ func (r *Registry) innerInsertStatementDiagnostics(`
`653`	`653`	`if err != nil {`
`654`	`654`	`return diagID, err`
`655`	`655`	`}`
`656`		`- } else {`
	`656`	`+ } else if txnDiagnosticId == 0 {`
`657`	`657`	`// Insert a completed request into system.statement_diagnostics_request.`
`658`	`658`	`// This is necessary because the UI uses this table to discover completed`
`659`	`659`	`// diagnostics.`