Merge #152595

152595: workload: fix divide by zero in `csvServerPaths` r=stevendanna,williamchoe3 a=srosenberg

Previously, `getNodeCount` could return zero without an error. This internal helper is used in `csvServerPaths` to determine `rowStep`. Not having any SQL nodes "available" is plausibly a valid system state. However, in the context of loading data, that indicates an error.

This PR ensures `getNodeCount` returns a non-zero result or an error. As a precaution, we also clamp down the divisor.

Epic: none
Fixes: #152092
Release note: None

Co-authored-by: Stan Rosenberg <[email protected]>

Author: craig[bot]

pkg/ccl/workloadccl/fixture.go

@@ -167,7 +167,7 @@ func csvServerPaths(
 	// so our "integer multiple" is picked to be 1 to minimize this effect. Too
 	// bad about the progress tracking granularity.
 	numFiles := numNodes
-	rowStep := table.InitialRows.NumBatches / numFiles
+	rowStep := table.InitialRows.NumBatches / max(numFiles, 1)
 	if rowStep == 0 {
 		rowStep = 1
 	}
@@ -329,11 +329,16 @@ func (l ImportDataLoader) InitialDataLoad(
 // the database we're connected to does not exist.
 const numNodesQuery = `SELECT count(1) FROM system.sql_instances WHERE addr IS NOT NULL`
 
+// getNodeCount returns the number of nodes in the cluster by querying a system table.
+// Ensures err != nil => res > 0.
 func getNodeCount(ctx context.Context, sqlDB *gosql.DB) (int, error) {
 	var numNodes int
-	if err := sqlDB.QueryRow(numNodesQuery).Scan(&numNodes); err != nil {
+	if err := sqlDB.QueryRowContext(ctx, numNodesQuery).Scan(&numNodes); err != nil {
 		return 0, err
 	}
+	if numNodes == 0 {
+		return 0, errors.New("no SQL nodes available")
+	}
 	return numNodes, nil
 }