Skip to content

Commit 413f019

Browse files
author
katmayb
committed
docgen: update check external connection sql diagram
Epic: none Release note: None Release justification: non-production code change
1 parent acd0334 commit 413f019

File tree

7 files changed

+24
-12
lines changed

7 files changed

+24
-12
lines changed

‎docs/generated/sql/bnf/BUILD.bazel‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ FILES = [
8383
"cancel_session",
8484
"cancel_stmt",
8585
"check_column_level",
86+
"check_external_connection",
8687
"check_table_level",
8788
"close_cursor_stmt",
8889
"col_qualification",
@@ -98,7 +99,7 @@ FILES = [
9899
"create_database_stmt",
99100
"create_ddl_stmt",
100101
"create_extension_stmt",
101-
"create_external_connection_stmt",
102+
"create_external_connection",
102103
"create_func",
103104
"create_index_stmt",
104105
"create_index_with_storage_param",
@@ -121,7 +122,6 @@ FILES = [
121122
"create_type",
122123
"create_view_stmt",
123124
"check_stmt",
124-
"check_external_connection_stmt",
125125
"deallocate_stmt",
126126
"declare_cursor_stmt",
127127
"default_value_column_level",

‎docs/generated/sql/bnf/check_external_connection.bnf‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
check_external_connection_stmt ::=
2+
'CHECK' 'EXTERNAL' 'CONNECTION' connection_uri 'WITH' check_external_connection_options_list
3+
| 'CHECK' 'EXTERNAL' 'CONNECTION' connection_uri

‎docs/generated/sql/bnf/check_external_connection_stmt.bnf‎

Lines changed: 0 additions & 2 deletions
This file was deleted.

‎docs/generated/sql/bnf/create_external_connection_stmt.bnf‎ renamed to ‎docs/generated/sql/bnf/create_external_connection.bnf‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
create_external_connection_stmt ::=
2-
'CREATE' 'EXTERNAL' 'CONNECTION' connection_name 'AS' connection_URI
2+
'CREATE' 'EXTERNAL' 'CONNECTION' connection_name 'AS' connection_uri

‎pkg/cmd/docgen/diagrams.go‎

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -653,6 +653,16 @@ var specs = []stmtSpec{
653653
replace: map[string]string{" stmt": " 'CREATE' 'TABLE' table_name '(' column_name column_type 'CHECK' '(' check_expr ')' ( column_constraints | ) ( ',' ( column_table_def ( ',' column_table_def )* ) | ) ( table_constraints | ) ')' ')'"},
654654
unlink: []string{"table_name", "column_name", "column_type", "check_expr", "column_constraints", "table_constraints"},
655655
},
656+
{
657+
name: "check_external_connection",
658+
stmt: "check_external_connection_stmt",
659+
inline: []string{"opt_with_check_external_connection_options_list"},
660+
exclude: []*regexp.Regexp{
661+
regexp.MustCompile("'WITH' 'OPTIONS'"),
662+
},
663+
replace: map[string]string{"string_or_placeholder": "connection_uri"},
664+
unlink: []string{"connection_uri"},
665+
},
656666
{
657667
name: "check_table_level",
658668
stmt: "stmt_block",
@@ -763,9 +773,10 @@ var specs = []stmtSpec{
763773
unlink: []string{"table_name", "sink", "option", "value"},
764774
},
765775
{
766-
name: "create_external_connection_stmt",
767-
replace: map[string]string{"label_spec": "connection_name", "string_or_placeholder": "connection_URI"},
768-
unlink: []string{"connection_name", "connection_URI"},
776+
name: "create_external_connection",
777+
stmt: "create_external_connection_stmt",
778+
replace: map[string]string{"label_spec": "connection_name", "string_or_placeholder": "connection_uri"},
779+
unlink: []string{"connection_name", "connection_uri"},
769780
},
770781
{
771782
name: "create_index_stmt",

‎pkg/gen/bnf.bzl‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ BNF_SRCS = [
8383
"//docs/generated/sql/bnf:cancel_session.bnf",
8484
"//docs/generated/sql/bnf:cancel_stmt.bnf",
8585
"//docs/generated/sql/bnf:check_column_level.bnf",
86-
"//docs/generated/sql/bnf:check_external_connection_stmt.bnf",
86+
"//docs/generated/sql/bnf:check_external_connection.bnf",
8787
"//docs/generated/sql/bnf:check_stmt.bnf",
8888
"//docs/generated/sql/bnf:check_table_level.bnf",
8989
"//docs/generated/sql/bnf:close_cursor_stmt.bnf",
@@ -100,7 +100,7 @@ BNF_SRCS = [
100100
"//docs/generated/sql/bnf:create_database_stmt.bnf",
101101
"//docs/generated/sql/bnf:create_ddl_stmt.bnf",
102102
"//docs/generated/sql/bnf:create_extension_stmt.bnf",
103-
"//docs/generated/sql/bnf:create_external_connection_stmt.bnf",
103+
"//docs/generated/sql/bnf:create_external_connection.bnf",
104104
"//docs/generated/sql/bnf:create_func.bnf",
105105
"//docs/generated/sql/bnf:create_index_stmt.bnf",
106106
"//docs/generated/sql/bnf:create_index_with_storage_param.bnf",

‎pkg/gen/docs.bzl‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ DOCS_SRCS = [
9393
"//docs/generated/sql/bnf:cancel_session.bnf",
9494
"//docs/generated/sql/bnf:cancel_stmt.bnf",
9595
"//docs/generated/sql/bnf:check_column_level.bnf",
96-
"//docs/generated/sql/bnf:check_external_connection_stmt.bnf",
96+
"//docs/generated/sql/bnf:check_external_connection.bnf",
9797
"//docs/generated/sql/bnf:check_stmt.bnf",
9898
"//docs/generated/sql/bnf:check_table_level.bnf",
9999
"//docs/generated/sql/bnf:close_cursor_stmt.bnf",
@@ -110,7 +110,7 @@ DOCS_SRCS = [
110110
"//docs/generated/sql/bnf:create_database_stmt.bnf",
111111
"//docs/generated/sql/bnf:create_ddl_stmt.bnf",
112112
"//docs/generated/sql/bnf:create_extension_stmt.bnf",
113-
"//docs/generated/sql/bnf:create_external_connection_stmt.bnf",
113+
"//docs/generated/sql/bnf:create_external_connection.bnf",
114114
"//docs/generated/sql/bnf:create_func.bnf",
115115
"//docs/generated/sql/bnf:create_index_stmt.bnf",
116116
"//docs/generated/sql/bnf:create_index_with_storage_param.bnf",

0 commit comments

Comments
 (0)