Merge pull request #160383 from cockroachdb/blathers/backport-release-26.1-159840

release-26.1: pkg/ts,util: make metric visibility proto field optional

Author: dhartunian

pkg/ts/catalog/chart_catalog.proto

@@ -91,7 +91,7 @@ message ChartMetric {
   // exportedName is the name of metrics as seen by external scrapers.
   required string exportedName = 6 [(gogoproto.nullable) = false];
   // visibility indicates the intended audience for this metric (INTERNAL, SUPPORT, or ESSENTIAL).
-  required string visibility = 7 [(gogoproto.nullable) = false];
+  optional string visibility = 7 [(gogoproto.nullable) = false];
   // howToUse is the usage instructions for the metric.
   optional string howToUse = 8 [(gogoproto.nullable) = false];
   // labeledName is the name of the metric with its labels, formatted as name{label1: value1, ...}.

pkg/util/metric/metric.proto

@@ -128,7 +128,7 @@ message Metadata {
 
   // visibility defines the intended audience and usage level for this metric.
   // See MetricVisibility for details on each visibility level.
-  required MetricVisibility visibility = 10 [(gogoproto.nullable) = false];
+  optional MetricVisibility visibility = 10 [(gogoproto.nullable) = false];
   // category is the dashboard category of this metric. This is
   // required if visibility is ESSENTIAL.
   required Category category = 11 [(gogoproto.nullable) = false];