Skip to content

Commit 45bbe65

Browse files
committed
changefeedccl: fix slow acquisition log message
Previously, have been waiting rangefeed attempting to acquire changefeed quota (buffer=5.000049088s) Now, have been waiting 5.000049088s attempting to acquire changefeed quota (buffer=rangefeed) It would be nice if the buffer name `rangefeed` was something that indicated that this a buffer that lives in the changefeed, but changing the name impacts the metrics which doesn't seem worth it. Epic: none Release note: None
1 parent 287999c commit 45bbe65

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pkg/ccl/changefeedccl/kvevent/blocking_buffer.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -523,13 +523,16 @@ func logSlowAcquisition(
523523
return func(ctx context.Context, poolName string, r quotapool.Request, start time.Time) func() {
524524
shouldLog := logSlowAcquire.ShouldLog()
525525
if shouldLog {
526-
log.Changefeed.Warningf(ctx, "have been waiting %s attempting to acquire changefeed quota (buffer=%s)", redact.SafeString(bufType),
527-
timeutil.Since(start))
526+
log.Changefeed.Warningf(ctx, "have been waiting %s attempting to acquire changefeed quota (buffer=%s)",
527+
timeutil.Since(start),
528+
redact.SafeString(bufType))
528529
}
529530

530531
return func() {
531532
if shouldLog {
532-
log.Changefeed.Infof(ctx, "acquired changefeed quota after %s (buffer=%s)", timeutil.Since(start), redact.SafeString(bufType))
533+
log.Changefeed.Infof(ctx, "acquired changefeed quota after %s (buffer=%s)",
534+
timeutil.Since(start),
535+
redact.SafeString(bufType))
533536
}
534537
}
535538
}

0 commit comments

Comments
 (0)