kvserver: fix TestUpdateLastUpdateTimesUsingStoreLiveness

arulajmani · arulajmani · commit 4837dbce5976 · 2025-09-02T17:04:00.000-04:00
This test wasn't doing as advertised on the tin after I broke some testing knobs in 02fa61b. Epic: none Release note: None
diff --git a/pkg/kv/kvserver/replica_raft.go b/pkg/kv/kvserver/replica_raft.go
@@ -699,7 +699,7 @@ func (r *Replica) stepRaftGroupRaftMuLocked(req *kvserverpb.RaftMessageRequest)
 			// Update the lastUpdateTimes map, unless configured not to by a testing
 			// knob.
 			disableUpdateLastUpdateTimesMapOnRaftGroupStep := false
-			if r.store.TestingKnobs() == nil &&
+			if r.store.TestingKnobs() != nil &&
 				r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep != nil {
 				disableUpdateLastUpdateTimesMapOnRaftGroupStep = r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep(r)
 			}

Original file line number	Diff line number	Diff line change
`@@ -699,7 +699,7 @@ func (r Replica) stepRaftGroupRaftMuLocked(req kvserverpb.RaftMessageRequest)`
`699`	`699`	`// Update the lastUpdateTimes map, unless configured not to by a testing`
`700`	`700`	`// knob.`
`701`	`701`	`disableUpdateLastUpdateTimesMapOnRaftGroupStep := false`
`702`		`- if r.store.TestingKnobs() == nil &&`
	`702`	`+ if r.store.TestingKnobs() != nil &&`
`703`	`703`	`r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep != nil {`
`704`	`704`	`disableUpdateLastUpdateTimesMapOnRaftGroupStep = r.store.TestingKnobs().DisableUpdateLastUpdateTimesMapOnRaftGroupStep(r)`
`705`	`705`	`}`