Skip to content

Commit 486ae5d

Browse files
craig[bot]herkolategan
andcommitted
Merge #156996
156996: roachtest: prefer root logger for mixed version backup test r=dt a=herkolategan Previously, the task waiting for the backup job to succeed used the default task logger which creates a log file based on the name of the task. The name of this task exceeded the maximum file name limit, causing logger creation to fail. This change updates the task to use the root logger instead of trying to log to a separate file for the task. The logging output from this task is minimal and doesn't need to log to a separate task log. Fixes: #156635 Epic: None Co-authored-by: Herko Lategan <[email protected]>
2 parents d00e9c3 + 2e1f332 commit 486ae5d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pkg/cmd/roachtest/tests/mixed_version_backup.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2145,7 +2145,10 @@ func (d *BackupRestoreTestDriver) runBackup(
21452145
backupErr <- err
21462146
}
21472147
return nil
2148-
}, task.Name(fmt.Sprintf("backup %s", collection.name)))
2148+
},
2149+
task.Logger(l),
2150+
task.Name(fmt.Sprintf("backup %s", collection.name)),
2151+
)
21492152

21502153
var numPauses int
21512154
for {

0 commit comments

Comments
 (0)