Merge pull request #151714 from stevendanna/ssd/no-buffer-repl-gets

stevendanna · web-flow · commit 48a9e8f181c1 · 2025-08-13T09:38:49.000+01:00
release-25.3: kvcoord: turn off buffering of replicated gets
diff --git a/pkg/kv/kvclient/kvcoord/txn_interceptor_write_buffer.go b/pkg/kv/kvclient/kvcoord/txn_interceptor_write_buffer.go
@@ -55,7 +55,7 @@ var bufferedWritesGetTransformEnabled = settings.RegisterBoolSetting(
 	settings.ApplicationLevel,
 	"kv.transaction.write_buffering.transformations.get.enabled",
 	"if enabled, locking get requests with replicated durability are transformed to unreplicated durability",
-	metamorphic.ConstantWithTestBool("kv.transaction.write_buffering.transformations.get.enabled", true /* defaultValue */),
+	metamorphic.ConstantWithTestBool("kv.transaction.write_buffering.transformations.get.enabled", false /* defaultValue */),
 )
 
 const defaultBufferSize = 1 << 22 // 4MB

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ var bufferedWritesGetTransformEnabled = settings.RegisterBoolSetting(`
`55`	`55`	`settings.ApplicationLevel,`
`56`	`56`	`"kv.transaction.write_buffering.transformations.get.enabled",`
`57`	`57`	`"if enabled, locking get requests with replicated durability are transformed to unreplicated durability",`
`58`		`- metamorphic.ConstantWithTestBool("kv.transaction.write_buffering.transformations.get.enabled", true /* defaultValue */),`
	`58`	`+ metamorphic.ConstantWithTestBool("kv.transaction.write_buffering.transformations.get.enabled", false /* defaultValue */),`
`59`	`59`	`)`
`60`	`60`
`61`	`61`	`const defaultBufferSize = 1 << 22 // 4MB`