Merge #155611 #155941

155611: roachprod: add parca agent r=DarrylWong a=herkolategan

Adds the ability to install the Parca Agent on  `roachprod` clusters. For more details on the
capabilities of the Parca Agent and Polaris Signals see [Parca Agent] & [Polaris Signals].

[Parca Agent]: https://github.com/parca-dev/parca
[Polaris Signals]: https://www.polarsignals.com/docs/overview

Epic: None
Release note: None

155941: master: Update pkg/testutils/release/cockroach_releases.yaml r=rail a=cockroach-teamcity

Update pkg/testutils/release/cockroach_releases.yaml with recent values.

Epic: None
Release note: None
Release justification: test-only updates

Co-authored-by: Herko Lategan <[email protected]>
Co-authored-by: CRL Release bot <[email protected]>

Author: 3 people

pkg/BUILD.bazel

@@ -321,13 +321,13 @@ ALL_TESTS = [
     "//pkg/revert:revert_test",
     "//pkg/roachpb:roachpb_disallowed_imports_test",
     "//pkg/roachpb:roachpb_test",
+    "//pkg/roachprod/agents/opentelemetry:opentelemetry_test",
     "//pkg/roachprod/blobfixture:blobfixture_test",
     "//pkg/roachprod/cloud:cloud_test",
     "//pkg/roachprod/config:config_test",
     "//pkg/roachprod/failureinjection/failures:failures_test",
     "//pkg/roachprod/install:install_test",
     "//pkg/roachprod/logger:logger_test",
-    "//pkg/roachprod/opentelemetry:opentelemetry_test",
     "//pkg/roachprod/prometheus:prometheus_test",
     "//pkg/roachprod/promhelperclient:promhelperclient_test",
     "//pkg/roachprod/roachprodutil/codec:codec_test",
@@ -1703,6 +1703,10 @@ GO_TARGETS = [
     "//pkg/revert:revert_test",
     "//pkg/roachpb:roachpb",
     "//pkg/roachpb:roachpb_test",
+    "//pkg/roachprod/agents/fluentbit:fluentbit",
+    "//pkg/roachprod/agents/opentelemetry:opentelemetry",
+    "//pkg/roachprod/agents/opentelemetry:opentelemetry_test",
+    "//pkg/roachprod/agents/parca:parca",
     "//pkg/roachprod/blobfixture:blobfixture",
     "//pkg/roachprod/blobfixture:blobfixture_test",
     "//pkg/roachprod/cloud:cloud",
@@ -1712,14 +1716,11 @@ GO_TARGETS = [
     "//pkg/roachprod/errors:errors",
     "//pkg/roachprod/failureinjection/failures:failures",
     "//pkg/roachprod/failureinjection/failures:failures_test",
-    "//pkg/roachprod/fluentbit:fluentbit",
     "//pkg/roachprod/install:install",
     "//pkg/roachprod/install:install_test",
     "//pkg/roachprod/lock:lock",
     "//pkg/roachprod/logger:logger",
     "//pkg/roachprod/logger:logger_test",
-    "//pkg/roachprod/opentelemetry:opentelemetry",
-    "//pkg/roachprod/opentelemetry:opentelemetry_test",
     "//pkg/roachprod/prometheus:prometheus",
     "//pkg/roachprod/prometheus:prometheus_test",
     "//pkg/roachprod/promhelperclient:promhelperclient",

pkg/cmd/roachprod/cli/BUILD.bazel

@@ -16,12 +16,13 @@ go_library(
     deps = [
         "//pkg/cmd/roachprod/grafana",
         "//pkg/roachprod",
+        "//pkg/roachprod/agents/fluentbit",
+        "//pkg/roachprod/agents/opentelemetry",
+        "//pkg/roachprod/agents/parca",
         "//pkg/roachprod/cloud",
         "//pkg/roachprod/config",
         "//pkg/roachprod/errors",
-        "//pkg/roachprod/fluentbit",
         "//pkg/roachprod/install",
-        "//pkg/roachprod/opentelemetry",
         "//pkg/roachprod/roachprodutil",
         "//pkg/roachprod/ssh",
         "//pkg/roachprod/ui",

pkg/cmd/roachprod/cli/commands.go

@@ -2147,6 +2147,32 @@ func (cr *commandRegistry) buildOpentelemetryStopCmd() *cobra.Command {
 	}
 }
 
+func (cr *commandRegistry) buildParcaAgentStartCmd() *cobra.Command {
+	parcaAgentStartCmd := &cobra.Command{
+		Use:   "parca-agent-start <cluster>",
+		Short: "Install and start the Parca Agent",
+		Long:  "Install and start the Parca Agent",
+		Args:  cobra.ExactArgs(1),
+		Run: Wrap(func(cmd *cobra.Command, args []string) error {
+			return roachprod.StartParcaAgent(context.Background(), config.Logger, args[0], parcaAgentConfig)
+		}),
+	}
+	initParcaAgentStartCmdFlags(parcaAgentStartCmd)
+	return parcaAgentStartCmd
+}
+
+func (cr *commandRegistry) buildParcaAgentStopCmd() *cobra.Command {
+	return &cobra.Command{
+		Use:   "parca-agent-stop <cluster>",
+		Short: "Stop the Parca Agent",
+		Long:  "Stop the Parca Agent",
+		Args:  cobra.ExactArgs(1),
+		Run: Wrap(func(cmd *cobra.Command, args []string) error {
+			return roachprod.StopParcaAgent(context.Background(), config.Logger, args[0])
+		}),
+	}
+}
+
 func (cr *commandRegistry) buildFetchLogsCmd() *cobra.Command {
 	fetchLogsCmd := &cobra.Command{
 		Use:     "fetchlogs <cluster> <destination (optional)> [flags]",

pkg/cmd/roachprod/cli/flags.go

@@ -11,10 +11,11 @@ import (
 	"time"
 
 	"github.com/cockroachdb/cockroach/pkg/roachprod"
+	"github.com/cockroachdb/cockroach/pkg/roachprod/agents/fluentbit"
+	"github.com/cockroachdb/cockroach/pkg/roachprod/agents/opentelemetry"
+	"github.com/cockroachdb/cockroach/pkg/roachprod/agents/parca"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/config"
-	"github.com/cockroachdb/cockroach/pkg/roachprod/fluentbit"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/install"
-	"github.com/cockroachdb/cockroach/pkg/roachprod/opentelemetry"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/ssh"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/vm"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/vm/gce"
@@ -101,9 +102,9 @@ var (
 
 	sshKeyUser string
 
-	fluentBitConfig fluentbit.Config
-
+	fluentBitConfig     fluentbit.Config
 	opentelemetryConfig opentelemetry.Config
+	parcaAgentConfig    parca.Config
 
 	fetchLogsTimeout time.Duration
 )
@@ -393,6 +394,11 @@ func initOpentelemetryStartCmdFlags(opentelemetryStartCmd *cobra.Command) {
 		"Datadog tags as a comma-separated list in the format KEY1:VAL1,KEY2:VAL2")
 }
 
+func initParcaAgentStartCmdFlags(parcaAgentStartCmd *cobra.Command) {
+	parcaAgentStartCmd.Flags().StringVar(&parcaAgentConfig.Token, "parca-agent-token", "",
+		"Parca Agent Token")
+}
+
 func initGCCmdFlags(gcCmd *cobra.Command) {
 	gcCmd.Flags().BoolVarP(&dryrun,
 		"dry-run", "n", dryrun, "dry run (don't perform any actions)")

pkg/cmd/roachprod/cli/resgistry.go

@@ -68,6 +68,8 @@ func (cr *commandRegistry) register() {
 		cr.buildFluentBitStopCmd(),
 		cr.buildOpentelemetryStartCmd(),
 		cr.buildOpentelemetryStopCmd(),
+		cr.buildParcaAgentStartCmd(),
+		cr.buildParcaAgentStopCmd(),
 		cr.buildFetchLogsCmd(),
 		cr.buildGetLatestPProfCmd(),
 		cr.buildFetchCertsDir(),

pkg/roachprod/BUILD.bazel

@@ -16,13 +16,14 @@ go_library(
         "//pkg/build",
         "//pkg/cli/exit",
         "//pkg/cmd/roachprod/grafana",
+        "//pkg/roachprod/agents/fluentbit",
+        "//pkg/roachprod/agents/opentelemetry",
+        "//pkg/roachprod/agents/parca",
         "//pkg/roachprod/cloud",
         "//pkg/roachprod/config",
-        "//pkg/roachprod/fluentbit",
         "//pkg/roachprod/install",
         "//pkg/roachprod/lock",
         "//pkg/roachprod/logger",
-        "//pkg/roachprod/opentelemetry",
         "//pkg/roachprod/prometheus",
         "//pkg/roachprod/promhelperclient",
         "//pkg/roachprod/vm",

pkg/roachprod/fluentbit/BUILD.bazel renamed to pkg/roachprod/agents/fluentbit/BUILD.bazel

@@ -7,7 +7,7 @@ go_library(
         "files/fluent-bit.service",
         "files/fluent-bit.yaml.tmpl",
     ],
-    importpath = "github.com/cockroachdb/cockroach/pkg/roachprod/fluentbit",
+    importpath = "github.com/cockroachdb/cockroach/pkg/roachprod/agents/fluentbit",
     visibility = ["//visibility:public"],
     deps = [
         "//pkg/roachprod/install",