kvserver: make leaderlessWatcher constructor private

The struct itself is private.

Epic: none

Release note: None

Author: arulajmani

pkg/kv/kvserver/replica.go

@@ -208,9 +208,9 @@ type leaderlessWatcher struct {
 	closedChannel chan struct{}
 }
 
-// NewLeaderlessWatcher initializes a new leaderlessWatcher with the default
+// newLeaderlessWatcher initializes a new leaderlessWatcher with the default
 // values.
-func NewLeaderlessWatcher(r *Replica) *leaderlessWatcher {
+func newLeaderlessWatcher(r *Replica) *leaderlessWatcher {
 	closedCh := make(chan struct{})
 	close(closedCh)
 	return &leaderlessWatcher{

pkg/kv/kvserver/replica_init.go

@@ -242,7 +242,7 @@ func newUninitializedReplicaWithoutRaftGroup(
 	r.breaker = newReplicaCircuitBreaker(
 		store.cfg.Settings, store.stopper, r.AmbientContext, r, onTrip, onReset,
 	)
-	r.LeaderlessWatcher = NewLeaderlessWatcher(r)
+	r.LeaderlessWatcher = newLeaderlessWatcher(r)
 	r.shMu.currentRACv2Mode = r.replicationAdmissionControlModeToUse(context.TODO())
 	r.raftMu.flowControlLevel = kvflowcontrol.GetV2EnabledWhenLeaderLevel(
 		r.raftCtx, store.ClusterSettings(), store.TestingKnobs().FlowControlTestingKnobs)