Skip to content

Commit 4aeb648

Browse files
DarrylWongDarrylWong
committed
roachprod/roachtest: add detection for live VM migrations on Azure
This change makes it so if a roachtest fails, we now check for a live migration on any of the VMs similar to how we check for preemptions and host errors. If one is found, the failure will be marked as a infra flake and routed to test-eng. Fixes: #143397
1 parent 74f9ec4 commit 4aeb648

File tree

15 files changed

+249
-10
lines changed

15 files changed

+249
-10
lines changed

‎DEPS.bzl‎

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -927,6 +927,26 @@ def go_deps():
927927
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_internal-v1.0.0.zip",
928928
],
929929
)
930+
go_repository(
931+
name = "com_github_azure_azure_sdk_for_go_sdk_resourcemanager_internal_v2",
932+
build_file_proto_mode = "disable_global",
933+
importpath = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v2",
934+
sha256 = "ca118b980624e02a37bf1b312771344e665dee30b8e9dd64aba7cb19201dd348",
935+
strip_prefix = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/[email protected]",
936+
urls = [
937+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v2/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_internal_v2-v2.0.0.zip",
938+
],
939+
)
940+
go_repository(
941+
name = "com_github_azure_azure_sdk_for_go_sdk_resourcemanager_monitor_armmonitor",
942+
build_file_proto_mode = "disable_global",
943+
importpath = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor",
944+
sha256 = "97ad4d0a82444b35ce027cf64e2fe1f97e4fc6424165a13892cfe51bf599cda3",
945+
strip_prefix = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/[email protected]",
946+
urls = [
947+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_monitor_armmonitor-v0.11.0.zip",
948+
],
949+
)
930950
go_repository(
931951
name = "com_github_azure_azure_sdk_for_go_sdk_resourcemanager_network_armnetwork",
932952
build_file_proto_mode = "disable_global",
@@ -941,10 +961,10 @@ def go_deps():
941961
name = "com_github_azure_azure_sdk_for_go_sdk_resourcemanager_resources_armresources",
942962
build_file_proto_mode = "disable_global",
943963
importpath = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources",
944-
sha256 = "09d235afd45048829677351d042fba2c57754df4ae4dde8b25168e39e903db07",
945-
strip_prefix = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources@v1.0.0",
964+
sha256 = "859deb478c6150fcc8ab966b85be386ca0d0e0c385ace0bc5b3c73c14a877bcd",
965+
strip_prefix = "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources@v1.1.1",
946966
urls = [
947-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_resources_armresources-v1.0.0.zip",
967+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_resources_armresources-v1.1.1.zip",
948968
],
949969
)
950970
go_repository(
@@ -2705,10 +2725,10 @@ def go_deps():
27052725
name = "com_github_dnaeon_go_vcr",
27062726
build_file_proto_mode = "disable_global",
27072727
importpath = "github.com/dnaeon/go-vcr",
2708-
sha256 = "d6d94a1c8471809db30c2979add32bac647120bc577ea30f7e8fcc06436483f0",
2709-
strip_prefix = "github.com/dnaeon/go-vcr@v1.1.0",
2728+
sha256 = "6d34b7e17c158d51ffc34f6ac64df05ab736b2ae50c0db07be4a9556dac10c52",
2729+
strip_prefix = "github.com/dnaeon/go-vcr@v1.2.0",
27102730
urls = [
2711-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/dnaeon/go-vcr/com_github_dnaeon_go_vcr-v1.1.0.zip",
2731+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/dnaeon/go-vcr/com_github_dnaeon_go_vcr-v1.2.0.zip",
27122732
],
27132733
)
27142734
go_repository(

‎build/bazelutil/distdir_files.bzl‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,10 @@ DISTDIR_FILES = {
149149
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/keyvault/internal/com_github_azure_azure_sdk_for_go_sdk_keyvault_internal-v0.7.0.zip": "a3a79250f250d01abd0b402649ce9baf7eeebbbad186dc602eb011692fdbec24",
150150
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_compute_armcompute-v1.0.0.zip": "7f0b10080e81a23d259a4449509485c58d862c4ff4757f7c2a234bbf6e9ac6c4",
151151
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_internal-v1.0.0.zip": "e5a50bbc42b4be222b7bafd509316a14388ccc190947545df1abfbdd3727e54c",
152+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v2/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_internal_v2-v2.0.0.zip": "ca118b980624e02a37bf1b312771344e665dee30b8e9dd64aba7cb19201dd348",
153+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_monitor_armmonitor-v0.11.0.zip": "97ad4d0a82444b35ce027cf64e2fe1f97e4fc6424165a13892cfe51bf599cda3",
152154
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_network_armnetwork-v1.0.0.zip": "e09bacbe7fe4532f9887151a51e092ac89a143034da0fb1729126422f9e1212b",
153-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_resources_armresources-v1.0.0.zip": "09d235afd45048829677351d042fba2c57754df4ae4dde8b25168e39e903db07",
155+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources/com_github_azure_azure_sdk_for_go_sdk_resourcemanager_resources_armresources-v1.1.1.zip": "859deb478c6150fcc8ab966b85be386ca0d0e0c385ace0bc5b3c73c14a877bcd",
154156
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/com_github_azure_azure_sdk_for_go_sdk_storage_azblob-v1.0.0.zip": "9bb69aea32f1d59711701f9562d66432c9c0374205e5009d1d1a62f03fb4fdad",
155157
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/azure-storage-blob-go/com_github_azure_azure_storage_blob_go-v0.8.0.zip": "3b02b720c25bbb6cdaf77f45a29a21e374e087081dedfeac2700aed6147b4b35",
156158
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/Azure/go-ansiterm/com_github_azure_go_ansiterm-v0.0.0-20210617225240-d185dfc1b5a1.zip": "631ff4b167a4360e10911e475933ecb3bd327c58974c17877d0d4cf6fbef6c96",
@@ -441,7 +443,7 @@ DISTDIR_FILES = {
441443
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/dimchansky/utfbom/com_github_dimchansky_utfbom-v1.1.1.zip": "0c1a11101602d5f57ac3e790c0b72e09ff87d8d535535f43fbee9e6a42327350",
442444
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/dimfeld/httptreemux/com_github_dimfeld_httptreemux-v5.0.1+incompatible.zip": "031da29a128234db595fdce84301cfe5ff13b4be03c1e344cfe7daadb68559e9",
443445
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/djherbis/atime/com_github_djherbis_atime-v1.1.0.zip": "195cebcceb6d76328f5e5d373154b5c46a6a9bf6b27a88f9c0158276a07c7c41",
444-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/dnaeon/go-vcr/com_github_dnaeon_go_vcr-v1.1.0.zip": "d6d94a1c8471809db30c2979add32bac647120bc577ea30f7e8fcc06436483f0",
446+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/dnaeon/go-vcr/com_github_dnaeon_go_vcr-v1.2.0.zip": "6d34b7e17c158d51ffc34f6ac64df05ab736b2ae50c0db07be4a9556dac10c52",
445447
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/docker/cli/com_github_docker_cli-v20.10.17+incompatible.zip": "595cf0e156e2d8afa7e736cbbed7f307685d103fc6109ea75f9ca6ebcafb767d",
446448
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/docker/distribution/com_github_docker_distribution-v2.7.1+incompatible.zip": "be78bc43d74873b67afe05a6b244490088680dab75bdfaf26d0fd4d054595bc7",
447449
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/docker/go-connections/com_github_docker_go_connections-v0.4.0.zip": "570ebcee7e6fd844e00c89eeab2b1922081d6969df76078dfe4ffacd3db56ada",

‎go.mod‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ require (
9292
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.7.0
9393
github.com/Azure/azure-sdk-for-go/sdk/keyvault/azkeys v0.9.0
9494
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute v1.0.0
95+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor v0.11.0
9596
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.0.0
9697
github.com/Azure/go-autorest/autorest/adal v0.9.15
9798
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c

‎go.sum‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,14 @@ github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute v1.0.0
111111
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute v1.0.0/go.mod h1:gM3K25LQlsET3QR+4V74zxCsFAy0r6xMNN9n80SZn+4=
112112
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal v1.0.0 h1:lMW1lD/17LUA5z1XTURo7LcVG2ICBPlyMHjIUrcFZNQ=
113113
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal v1.0.0/go.mod h1:ceIuwmxDWptoW3eCqSXlnPsZFKh4X+R38dWPv7GS9Vs=
114+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v2 v2.0.0 h1:PTFGRSlMKCQelWwxUyYVEUqseBJVemLyqWJjvMyt0do=
115+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/internal/v2 v2.0.0/go.mod h1:LRr2FzBTQlONPPa5HREE5+RjSCTXl7BwOvYOaWTqCaI=
116+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor v0.11.0 h1:Ds0KRF8ggpEGg4Vo42oX1cIt/IfOhHWJBikksZbVxeg=
117+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/monitor/armmonitor v0.11.0/go.mod h1:jj6P8ybImR+5topJ+eH6fgcemSFBmU6/6bFF8KkwuDI=
114118
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork v1.0.0 h1:nBy98uKOIfun5z6wx6jwWLrULcM0+cjBalBFZlEZ7CA=
115119
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/network/armnetwork v1.0.0/go.mod h1:243D9iHbcQXoFUtgHJwL7gl2zx1aDuDMjvBZVGr2uW0=
116-
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.0.0 h1:ECsQtyERDVz3NP3kvDOTLvbQhqWp/x9EsGKtb4ogUr8=
117-
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.0.0/go.mod h1:s1tW/At+xHqjNFvWU4G0c0Qv33KOhvbGNj0RCTQDV8s=
120+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.1.1 h1:7CBQ+Ei8SP2c6ydQTGCCrS35bDxgTMfoP2miAwK++OU=
121+
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.1.1/go.mod h1:c/wcGeGx5FUPbM/JltUYHZcKmigwyVLJlDq+4HdtXaw=
118122
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.0.0 h1:u/LLAOFgsMv7HmNL4Qufg58y+qElGOt5qv0z1mURkRY=
119123
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v1.0.0/go.mod h1:2e8rMJtl2+2j+HXbTBwnyGpm5Nou7KhvSfxOq8JpTag=
120124
github.com/Azure/azure-storage-blob-go v0.8.0/go.mod h1:lPI3aLPpuLTeUwh1sViKXFxwl2B6teiRqI0deQUvsw0=

‎pkg/cmd/roachtest/cluster.go‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3352,6 +3352,33 @@ func (c *clusterImpl) GetHostErrorVMs(ctx context.Context, l *logger.Logger) ([]
33523352
return allHostErrorVMs, nil
33533353
}
33543354

3355+
func (c *clusterImpl) GetLiveMigrationVMs(l *logger.Logger) ([]string, error) {
3356+
if c.IsLocal() {
3357+
return nil, nil
3358+
}
3359+
cachedCluster, err := getCachedCluster(c.name)
3360+
if err != nil {
3361+
return nil, err
3362+
}
3363+
3364+
var liveMigrationVMs struct {
3365+
syncutil.Mutex
3366+
names []string
3367+
}
3368+
clusterErr := vm.FanOut(cachedCluster.VMs, func(p vm.Provider, vms vm.List) error {
3369+
names, err := p.GetLiveMigrationVMs(l, vms, cachedCluster.CreatedAt)
3370+
if err != nil {
3371+
return err
3372+
}
3373+
liveMigrationVMs.Lock()
3374+
defer liveMigrationVMs.Unlock()
3375+
liveMigrationVMs.names = append(liveMigrationVMs.names, names...)
3376+
return nil
3377+
})
3378+
3379+
return liveMigrationVMs.names, clusterErr
3380+
}
3381+
33553382
// RegisterClusterHook registers a hook to be run at a certain point as defined
33563383
// by option.ClusterHookType. This exposes a way for test writers to run code
33573384
// in between certain steps normally orchestrated by the framework, e.g. running

‎pkg/cmd/roachtest/github_test.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,8 @@ func TestCreatePostRequest(t *testing.T) {
214214
refError = vmPreemptionError("my_VM")
215215
case "vm-host-error":
216216
refError = vmHostError("my_VM")
217+
case "live-migration-error":
218+
refError = liveMigrationError("my_VM")
217219
case "error-with-owner-sql-foundations":
218220
refError = registry.ErrorWithOwner(registry.OwnerSQLFoundations, refError)
219221
case "error-with-owner-test-eng":

‎pkg/cmd/roachtest/test_runner.go‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,16 @@ var (
109109
)
110110
}
111111

112+
// liveMigrationError indicates that a test failed and also experienced
113+
// a live migration. These errors are directed to Test Eng instead of owning teams.
114+
liveMigrationError = func(liveMigrationVMs string) error {
115+
return registry.ErrorWithOwner(
116+
registry.OwnerTestEng, fmt.Errorf("liveMigrationError VMs: %s", liveMigrationVMs),
117+
registry.WithTitleOverride("live_migration_error"),
118+
registry.InfraFlake,
119+
)
120+
}
121+
112122
prng, _ = randutil.NewLockedPseudoRand()
113123

114124
runID string
@@ -1219,6 +1229,12 @@ func (r *testRunner) runTest(
12191229
t.resetFailures()
12201230
t.Error(vmHostError(hostErrorVMNames))
12211231
}
1232+
liveMigrationVMNames := getLiveMigrationVMNames(c, l)
1233+
if liveMigrationVMNames != "" {
1234+
failureMsg = fmt.Sprintf("VMs had live migrations during the test run: %s\n\n**Other Failures:**\n%s", liveMigrationVMNames, failureMsg)
1235+
t.resetFailures()
1236+
t.Error(liveMigrationError(hostErrorVMNames))
1237+
}
12221238

12231239
output := fmt.Sprintf("%s\ntest artifacts and logs in: %s", failureMsg, t.ArtifactsDir())
12241240
params := getTestParameters(t, github.cluster, github.vmCreateOpts)
@@ -1501,6 +1517,18 @@ func getHostErrorVMNames(ctx context.Context, c *clusterImpl, l *logger.Logger)
15011517
return getVMNames(hostErrorVMs)
15021518
}
15031519

1520+
// getLiveMigrationVMNames returns a comma separated list of VMs that
1521+
// experienced a live migration over the duration of the test.
1522+
func getLiveMigrationVMNames(c *clusterImpl, l *logger.Logger) string {
1523+
liveMigrationVMs, err := c.GetLiveMigrationVMs(l)
1524+
if err != nil {
1525+
l.Printf("failed to check live migrations:\n%+v", err)
1526+
return ""
1527+
}
1528+
1529+
return strings.Join(liveMigrationVMs, ", ")
1530+
}
1531+
15041532
// The assertions here are executed after each test, and may result in a test failure. Test authors
15051533
// may opt out of these assertions by setting the relevant `SkipPostValidations` flag in the test spec.
15061534
// An error caused by a timeout will not result in a failure.

‎pkg/cmd/roachtest/testdata/github/live_migration_error‎

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
# Verify live migration failures are routed to test-eng and marked as infra-flake.
2+
3+
add-failure name=(oops) type=(live-migration-error)
4+
----
5+
ok
6+
7+
post
8+
----
9+
----
10+
roachtest.live_migration_error [failed]() on test_branch @ [test_SHA](). A Side-Eye cluster snapshot was captured on timeout: [https://app.side-eye.io/snapshots/1](https://app.side-eye.io/snapshots/1).
11+
12+
13+
```
14+
test github_test failed: liveMigrationError VMs: my_VM [owner=test-eng]
15+
```
16+
17+
Parameters:
18+
- <code>arch=amd64</code>
19+
- <code>cloud=gce</code>
20+
- <code>coverageBuild=false</code>
21+
- <code>cpu=4</code>
22+
- <code>encrypted=false</code>
23+
- <code>fs=ext4</code>
24+
- <code>localSSD=true</code>
25+
- <code>runtimeAssertionsBuild=false</code>
26+
- <code>ssd=0</code>
27+
<details><summary>Help</summary>
28+
<p>
29+
30+
31+
See: [roachtest README](https://github.com/cockroachdb/cockroach/blob/master/pkg/cmd/roachtest/README.md)
32+
33+
34+
35+
See: [How To Investigate \(internal\)](https://cockroachlabs.atlassian.net/l/c/SSSBr8c7)
36+
37+
38+
39+
See: [Grafana](https://go.crdb.dev/roachtest-grafana//github-test/1689957243000/1689957853000)
40+
41+
</p>
42+
</details>
43+
/cc @cockroachdb/test-eng
44+
<sub>
45+
46+
[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*live_migration_error.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)
47+
48+
</sub>
49+
50+
------
51+
Labels:
52+
- <code>O-roachtest</code>
53+
- <code>X-infra-flake</code>
54+
- <code>T-testeng</code>
55+
Rendered:
56+
https://github.com/cockroachdb/cockroach/issues/new?body=roachtest.live_migration_error+%5Bfailed%5D%28%29+on+test_branch+%40+%5Btest_SHA%5D%28%29.+A+Side-Eye+cluster+snapshot+was+captured+on+timeout%3A+%5Bhttps%3A%2F%2Fapp.side-eye.io%2Fsnapshots%2F1%5D%28https%3A%2F%2Fapp.side-eye.io%2Fsnapshots%2F1%29.%0A%0A%0A%60%60%60%0Atest+github_test+failed%3A+liveMigrationError+VMs%3A+my_VM+%5Bowner%3Dtest-eng%5D%0A%60%60%60%0A%0AParameters%3A%0A+-+%3Ccode%3Earch%3Damd64%3C%2Fcode%3E%0A+-+%3Ccode%3Ecloud%3Dgce%3C%2Fcode%3E%0A+-+%3Ccode%3EcoverageBuild%3Dfalse%3C%2Fcode%3E%0A+-+%3Ccode%3Ecpu%3D4%3C%2Fcode%3E%0A+-+%3Ccode%3Eencrypted%3Dfalse%3C%2Fcode%3E%0A+-+%3Ccode%3Efs%3Dext4%3C%2Fcode%3E%0A+-+%3Ccode%3ElocalSSD%3Dtrue%3C%2Fcode%3E%0A+-+%3Ccode%3EruntimeAssertionsBuild%3Dfalse%3C%2Fcode%3E%0A+-+%3Ccode%3Essd%3D0%3C%2Fcode%3E%0A%3Cdetails%3E%3Csummary%3EHelp%3C%2Fsummary%3E%0A%3Cp%3E%0A%0A%0ASee%3A+%5Broachtest+README%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Fblob%2Fmaster%2Fpkg%2Fcmd%2Froachtest%2FREADME.md%29%0A%0A%0A%0ASee%3A+%5BHow+To+Investigate+%5C%28internal%5C%29%5D%28https%3A%2F%2Fcockroachlabs.atlassian.net%2Fl%2Fc%2FSSSBr8c7%29%0A%0A%0A%0ASee%3A+%5BGrafana%5D%28https%3A%2F%2Fgo.crdb.dev%2Froachtest-grafana%2F%2Fgithub-test%2F1689957243000%2F1689957853000%29%0A%0A%3C%2Fp%3E%0A%3C%2Fdetails%3E%0A%2Fcc+%40cockroachdb%2Ftest-eng%0A%3Csub%3E%0A%0A%5BThis+test+on+roachdash%5D%28https%3A%2F%2Froachdash.crdb.dev%2F%3Ffilter%3Dstatus%3Aopen%2520t%3A.%2Alive_migration_error.%2A%26sort%3Dtitle%2Bcreated%26display%3Dlastcommented%2Bproject%29+%7C+%5BImprove+this+report%21%5D%28https%3A%2F%2Fgithub.com%2Fcockroachdb%2Fcockroach%2Ftree%2Fmaster%2Fpkg%2Fcmd%2Fbazci%2Fgithubpost%2Fissues%29%0A%0A%3C%2Fsub%3E%0A%0A------%0ALabels%3A%0A-+%3Ccode%3EO-roachtest%3C%2Fcode%3E%0A-+%3Ccode%3EX-infra-flake%3C%2Fcode%3E%0A-+%3Ccode%3ET-testeng%3C%2Fcode%3E%0A&template=none&title=roachtest%3A+live_migration_error+failed
57+
----
58+
----

‎pkg/roachprod/vm/aws/aws.go‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -363,6 +363,12 @@ func (p *Provider) GetHostErrorVMs(
363363
return nil, nil
364364
}
365365

366+
func (p *Provider) GetLiveMigrationVMs(
367+
l *logger.Logger, vms vm.List, since time.Time,
368+
) ([]string, error) {
369+
return nil, nil
370+
}
371+
366372
// GetVMSpecs returns a map from VM.Name to a map of VM attributes, provided by AWS
367373
func (p *Provider) GetVMSpecs(
368374
l *logger.Logger, vms vm.List,

‎pkg/roachprod/vm/azure/BUILD.bazel‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ go_library(
2424
"@com_github_azure_azure_sdk_for_go//profiles/latest/resources/mgmt/resources",
2525
"@com_github_azure_azure_sdk_for_go//profiles/latest/resources/mgmt/subscriptions",
2626
"@com_github_azure_azure_sdk_for_go_sdk_resourcemanager_compute_armcompute//:armcompute",
27+
"@com_github_azure_azure_sdk_for_go_sdk_resourcemanager_monitor_armmonitor//:armmonitor",
2728
"@com_github_azure_go_autorest_autorest//:autorest",
2829
"@com_github_azure_go_autorest_autorest_adal//:adal",
2930
"@com_github_azure_go_autorest_autorest_azure_auth//:auth",

0 commit comments

Comments
 (0)