Skip to content

Commit 4c7e7f1

Browse files
committed
kvcoord: remove noop target
This was apparently there to fix some sort of gazelle issue, but isn't necessary any more. Epic: none Release note: None
1 parent fe5ec41 commit 4c7e7f1

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

build/bazelutil/BUILD.bazel

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
exports_files(["nogo_config.json"])
22

3-
load("@io_bazel_rules_go//go:def.bzl", "go_library")
4-
53
# The output file will be empty unless we're using the force_build_cdeps config.
64
genrule(
75
name = "test_force_build_cdeps",
@@ -11,11 +9,3 @@ genrule(
119
"//conditions:default": "touch $@",
1210
}),
1311
)
14-
15-
# This noop target is a workaround for https://github.com/bazelbuild/bazel-gazelle/issues/1078.
16-
# We use it in //pkg/kv/kvclient/{kvcoord,rangefeed}.
17-
go_library(
18-
name = "noop",
19-
importpath = "noop",
20-
visibility = ["//pkg:__subpackages__"],
21-
)

pkg/kv/kvclient/kvcoord/BUILD.bazel

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,6 @@ gomock(
122122
],
123123
)
124124

125-
# This noop target is a workaround for https://github.com/bazelbuild/bazel-gazelle/issues/1078.
126-
#
127-
# gazelle:resolve go github.com/cockroachdb/cockroach/pkg/kv/kvclient/kvcoord //build/bazelutil:noop
128-
129125
go_test(
130126
name = "kvcoord_test",
131127
size = "large",
@@ -174,7 +170,6 @@ go_test(
174170
}),
175171
shard_count = 16,
176172
deps = [
177-
"//build/bazelutil:noop",
178173
"//pkg/base",
179174
"//pkg/config",
180175
"//pkg/config/zonepb",

pkg/kv/kvclient/kvcoord/txncorrectnesstest/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ go_test(
1616
"write_skew_anomaly_test.go",
1717
],
1818
deps = [
19-
"//build/bazelutil:noop",
2019
"//pkg/base",
2120
"//pkg/kv",
2221
"//pkg/kv/kvclient/kvcoord", # keep

0 commit comments

Comments
 (0)