Skip to content

Commit 4d8f17c

Browse files
committed
asim: use exact_bound in a few cases
It's more intuitive in cases where we assert that the function is constant.
1 parent fc035ee commit 4d8f17c

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_multi_store.txt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@ assertion stat=leases type=balance ticks=6 upper_bound=1
1515
----
1616
asserting: max_{stores}(leases)/mean_{stores}(leases) ≤ 1.00 at each of last 6 ticks
1717

18-
assertion stat=leases type=steady ticks=6 upper_bound=0
18+
assertion stat=leases type=steady ticks=6 exact_bound=0
1919
----
20-
asserting: |leases(t)/mean_{T}(leases) - 1| 0.00 ∀ t∈T and each store (T=last 6 ticks)
20+
asserting: |leases(t)/mean_{T}(leases) - 1| = 0.00 ∀ t∈T and each store (T=last 6 ticks)
2121

22+
# TODO(tbg): fix the NaN issue here.
2223
eval duration=5m seed=42 metrics=(leases) cfgs=(sma-count,mma-only)
2324
----
2425
leases#1: first: [s1=8, s2=3, s3=0, s4=0, s5=0, s6=0, s7=0, s8=0, s9=1, s10=0, s11=1, s12=0, s13=1, s14=0] (stddev=2.10, mean=1.00, sum=14)
@@ -35,3 +36,9 @@ failed assertion sample 1
3536
max/mean=4.00 tick=3
3637
max/mean=4.00 tick=4
3738
max/mean=4.00 tick=5
39+
steady state stat=leases threshold=(=0.00) ticks=6
40+
store=3 min/mean=NaN max/mean=NaN
41+
store=4 min/mean=NaN max/mean=NaN
42+
store=5 min/mean=NaN max/mean=NaN
43+
store=7 min/mean=NaN max/mean=NaN
44+
store=8 min/mean=NaN max/mean=NaN

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_splitting.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ setting split_qps_threshold=2500
2020

2121
# Assert that the number of replicas should not change at all during the last 6
2222
# ticks of the simulation.
23-
assertion stat=replicas type=steady ticks=6 upper_bound=0.00
23+
assertion stat=replicas type=steady ticks=6 exact_bound=0.00
2424
----
25-
asserting: |replicas(t)/mean_{T}(replicas) - 1| 0.00 ∀ t∈T and each store (T=last 6 ticks)
25+
asserting: |replicas(t)/mean_{T}(replicas) - 1| = 0.00 ∀ t∈T and each store (T=last 6 ticks)
2626

2727

2828
# Examine the number of replicas. Here there were 5 load based splits. This

0 commit comments

Comments
 (0)