storage: metamorphically enable blob-file rewrites

annrpom · annrpom · commit 4e99c55f4507 · 2025-07-01T15:52:03.000-04:00
This patch enables blob-file rewrites metamorphically.

Epic: none

Release note: None
diff --git a/pkg/storage/pebble.go b/pkg/storage/pebble.go
@@ -456,7 +456,9 @@ var (
 		"storage.value_separation.compaction_garbage_threshold",
 		"the max garbage threshold configures the percentage of unreferenced value "+
 			"bytes that trigger blob-file rewrite compactions; 100 disables these compactions",
-		100, /* default; disables blob-file rewrites */
+		int64(metamorphic.ConstantWithTestRange("storage.value_separation.compaction_garbage_threshold",
+			10, /* default */
+			1 /* min */, 80 /* max */)),
 		settings.IntInRange(1, 100),
 	)
 )

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,9 @@ var (`
`456`	`456`	`"storage.value_separation.compaction_garbage_threshold",`
`457`	`457`	`"the max garbage threshold configures the percentage of unreferenced value "+`
`458`	`458`	`"bytes that trigger blob-file rewrite compactions; 100 disables these compactions",`
`459`		`- 100, /* default; disables blob-file rewrites */`
	`459`	`+ int64(metamorphic.ConstantWithTestRange("storage.value_separation.compaction_garbage_threshold",`
	`460`	`+ 10, /* default */`
	`461`	`+ 1 /* min /, 80 / max */)),`
`460`	`462`	`settings.IntInRange(1, 100),`
`461`	`463`	`)`
`462`	`464`	`)`