Skip to content

Commit 4eb6516

Browse files
committed
kvserver: default kv.range_split.load_sample_reset_duration to 30m
See #144407 - the split reservoir can sometimes contain "old state" when the load based splitter is persistently engaged. When the splitter can make a split, it typically is ready to do so in a minute or two, though the range also needs to be picked up by the replica scanner, which is only guaranteed to come around every ~10 minutes. So resetting it every "tens of minutes" is not disruptive but can help ranges getting stuck in a state where they deserve a split but will not perform one. Release note (ops change): the kv.range_split.load_sample_reset_duration now defaults to 30m. This should improve load-based splitting in rare edge cases.
1 parent 2168630 commit 4eb6516

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/kv/kvserver/replica_split_load.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ var SplitSampleResetDuration = settings.RegisterDurationSetting(
7474
"the duration after which the load based split sampler will reset its state, "+
7575
"regardless of any split suggestions made, when zero, the sampler will "+
7676
"never reset",
77-
0, /* disabled */
77+
30*time.Minute, // a multiple of the default scan interval of 10m
7878
settings.DurationWithMinimumOrZeroDisable(10*time.Second),
7979
)
8080

0 commit comments

Comments
 (0)