Skip to content

Commit 4ec2d66

Browse files
committed
asim: rename sma-only to sma-count and remove default
This commit renames sma-only to sma-count specify that it enables single-metric store rebalancer and count-based rebalancing. It also removes default since it is unclear what it was intended for and does the same thing as sma-count now.
1 parent 28b9b31 commit 4ec2d66

22 files changed

+39
-49
lines changed

pkg/kv/kvserver/asim/tests/datadriven_simulation_test.go

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ func TestDataDriven(t *testing.T) {
463463
if len(cfgs) == 0 {
464464
// TODO(tbg): force each test to specify the configs it wants to run
465465
// under.
466-
cfgs = []string{"default"}
466+
cfgs = []string{"sma-count"}
467467
}
468468

469469
metricsMap := map[string]struct{}{}
@@ -475,9 +475,7 @@ func TestDataDriven(t *testing.T) {
475475
require.NotZero(t, rangeGen)
476476

477477
knownConfigurations := map[string]func(eg *gen.StaticEvents){
478-
// In default mode, the test manages its rebalancer-related settings
479-
// manually.
480-
"default": func(eg *gen.StaticEvents) {
478+
"sma-count": func(eg *gen.StaticEvents) {
481479
eg.ScheduleEvent(settingsGen.Settings.StartTime, 0,
482480
event.SetSimulationSettingsEvent{
483481
IsClusterSetting: true,
@@ -487,14 +485,6 @@ func TestDataDriven(t *testing.T) {
487485
},
488486
// 'mma-only' runs with the multi-metric allocator and turns off the
489487
// replicate and lease queues.
490-
"sma-only": func(eg *gen.StaticEvents) {
491-
eg.ScheduleEvent(settingsGen.Settings.StartTime, 0,
492-
event.SetSimulationSettingsEvent{
493-
IsClusterSetting: true,
494-
Key: "LBRebalancingMode",
495-
Value: int64(kvserverbase.LBRebalancingLeasesAndReplicas),
496-
})
497-
},
498488
"mma-only": func(eg *gen.StaticEvents) {
499489
eg.ScheduleEvent(settingsGen.Settings.StartTime, 0,
500490
event.SetSimulationSettingsEvent{
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

pkg/kv/kvserver/asim/tests/testdata/non_rand/decommission_conformance.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ set_liveness node=4 liveness=decommissioning delay=5m
2626
assertion type=conformance under=0 over=0 unavailable=0 violating=0
2727
----
2828

29-
eval duration=20m cfgs=(default,mma-only)
29+
eval duration=20m cfgs=(sma-count,mma-only)
3030
----
31-
artifacts[default]: 1375509107ab02af
31+
artifacts[sma-count]: 1375509107ab02af
3232
artifacts[mma-only]: 398e8cd95b3327fb

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_add_node.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ eval duration=20m samples=1 seed=42 metrics=(replicas)
3333
----
3434
replicas#1: first: [s1=301, s2=0, s3=0] (stddev=141.89, mean=100.33, sum=301)
3535
replicas#1: last: [s1=301, s2=271, s3=267] (stddev=15.17, mean=279.67, sum=839)
36-
artifacts[default]: 866426beb5ad043b
36+
artifacts[sma-count]: 866426beb5ad043b
3737
failed assertion sample 1
3838
balance stat=replicas threshold=(<1.05) ticks=6
3939
max/mean=1.08 tick=0

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_conformance.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ set_span_config delay=5m
2626
assertion type=conformance under=0 over=0 unavailable=0 violating=0
2727
----
2828

29-
eval duration=10m cfgs=(default,mma-only)
29+
eval duration=10m cfgs=(sma-count,mma-only)
3030
----
31-
artifacts[default]: ca2c6e7399a9dc9c
31+
artifacts[sma-count]: ca2c6e7399a9dc9c
3232
artifacts[mma-only]: 273dc0cd62dfba6c

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_fulldisk.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ set_capacity store=5 capacity=107374182400
2020
# We will repeatedly hit the disk fullness threshold which causes shedding
2121
# replicas on store 5. We should see s5 hovering right around 92.5-95%
2222
# (the storage capacity threshold value).
23-
eval duration=30m seed=42 metrics=(replicas,disk_fraction_used) cfgs=(default,mma-only)
23+
eval duration=30m seed=42 metrics=(replicas,disk_fraction_used) cfgs=(sma-count,mma-only)
2424
----
2525
disk_fraction_used#1: first: [s1=0.20, s2=0.20, s3=0.20, s4=0.20, s5=1.05] (stddev=0.34, mean=0.37, sum=2)
2626
disk_fraction_used#1: last: [s1=0.30, s2=0.30, s3=0.30, s4=0.30, s5=0.95] (stddev=0.26, mean=0.43, sum=2)
2727
replicas#1: first: [s1=300, s2=300, s3=300, s4=300, s5=300] (stddev=0.00, mean=300.00, sum=1500)
2828
replicas#1: last: [s1=322, s2=328, s3=327, s4=323, s5=200] (stddev=50.05, mean=300.00, sum=1500)
29-
artifacts[default]: 686ff7227dd03ade
29+
artifacts[sma-count]: 686ff7227dd03ade
3030
disk_fraction_used#1: first: [s1=0.20, s2=0.20, s3=0.20, s4=0.20, s5=1.05] (stddev=0.34, mean=0.37, sum=2)
3131
disk_fraction_used#1: last: [s1=0.31, s2=0.31, s3=0.31, s4=0.29, s5=0.92] (stddev=0.25, mean=0.43, sum=2)
3232
replicas#1: first: [s1=300, s2=300, s3=300, s4=300, s5=300] (stddev=0.00, mean=300.00, sum=1500)

pkg/kv/kvserver/asim/tests/testdata/non_rand/example_io_overload.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ set_capacity store=5 io_threshold=1
1414
assertion type=stat stat=replicas stores=(5) exact_bound=0 ticks=5
1515
----
1616

17-
eval duration=10m seed=42 metrics=(replicas,leases) cfgs=(default,mma-only)
17+
eval duration=10m seed=42 metrics=(replicas,leases) cfgs=(sma-count,mma-only)
1818
----
1919
leases#1: first: [s1=259, s2=129, s3=64, s4=32, s5=16] (stddev=88.43, mean=100.00, sum=500)
2020
leases#1: last: [s1=180, s2=102, s3=106, s4=106, s5=6] (stddev=55.34, mean=100.00, sum=500)
2121
replicas#1: first: [s1=500, s2=456, s3=262, s4=165, s5=117] (stddev=153.29, mean=300.00, sum=1500)
2222
replicas#1: last: [s1=347, s2=343, s3=348, s4=345, s5=117] (stddev=91.52, mean=300.00, sum=1500)
23-
artifacts[default]: 6574ebfbb518515a
23+
artifacts[sma-count]: 6574ebfbb518515a
2424
failed assertion sample 1
2525
stat=replicas value=(=0.00) ticks=5
2626
store=5 stat=117.00

0 commit comments

Comments
 (0)