eventpb: move hot range log events to the health channel

As title states, currently hot range logs are emitted on the OPS
channel. This is a change we made recently, and we've revised our
targeted destination to be the HEALTH channel.

Fixes: #143512
Epic: CRDB-43150

Release note (ops change): Moves the hot range logs to the HEALTH
channel.

Author: angles-n-daemons

docs/generated/eventlog.md

@@ -181,34 +181,6 @@ events.
 | `StoreID` |  | no |
 
 
-#### Common fields
-
-| Field | Description | Sensitive |
-|--|--|--|
-| `Timestamp` | The timestamp of the event. Expressed as nanoseconds since the Unix epoch. | no |
-| `EventType` | The type of the event. | no |
-
-### `hot_ranges_stats`
-
-An event of type `hot_ranges_stats`
-
-
-| Field | Description | Sensitive |
-|--|--|--|
-| `RangeID` |  | no |
-| `Qps` |  | no |
-| `SchemaName` | SchemaName is the name of the schema in which the index was created. | yes |
-| `LeaseholderNodeID` | LeaseholderNodeID indicates the Node ID that is the current leaseholder for the given range. | no |
-| `WritesPerSecond` | Writes per second is the recent number of keys written per second on this range. | no |
-| `ReadsPerSecond` | Reads per second is the recent number of keys read per second on this range. | no |
-| `WriteBytesPerSecond` | Write bytes per second is the recent number of bytes written per second on this range. | no |
-| `ReadBytesPerSecond` | Read bytes per second is the recent number of bytes read per second on this range. | no |
-| `CPUTimePerSecond` | CPU time per second is the recent cpu usage in nanoseconds of this range. | no |
-| `Databases` | Databases for the range. | yes |
-| `Tables` | Tables for the range | yes |
-| `Indexes` | Indexes for the range | yes |
-
-
 #### Common fields
 
 | Field | Description | Sensitive |
@@ -475,6 +447,34 @@ Events in this category pertain to the health of one or more servers.
 Events in this category are logged to the `HEALTH` channel.
 
 
+### `hot_ranges_stats`
+
+An event of type `hot_ranges_stats`
+
+
+| Field | Description | Sensitive |
+|--|--|--|
+| `RangeID` |  | no |
+| `Qps` |  | no |
+| `SchemaName` | SchemaName is the name of the schema in which the index was created. | yes |
+| `LeaseholderNodeID` | LeaseholderNodeID indicates the Node ID that is the current leaseholder for the given range. | no |
+| `WritesPerSecond` | Writes per second is the recent number of keys written per second on this range. | no |
+| `ReadsPerSecond` | Reads per second is the recent number of keys read per second on this range. | no |
+| `WriteBytesPerSecond` | Write bytes per second is the recent number of bytes written per second on this range. | no |
+| `ReadBytesPerSecond` | Read bytes per second is the recent number of bytes read per second on this range. | no |
+| `CPUTimePerSecond` | CPU time per second is the recent cpu usage in nanoseconds of this range. | no |
+| `Databases` | Databases for the range. | yes |
+| `Tables` | Tables for the range | yes |
+| `Indexes` | Indexes for the range | yes |
+
+
+#### Common fields
+
+| Field | Description | Sensitive |
+|--|--|--|
+| `Timestamp` | The timestamp of the event. Expressed as nanoseconds since the Unix epoch. | no |
+| `EventType` | The type of the event. | no |
+
 ### `runtime_stats`
 
 An event of type `runtime_stats` is recorded every 10 seconds as server health metrics.

pkg/server/structlogging/hot_ranges_log_test.go

@@ -43,7 +43,7 @@ func (spy *hotRangesLogSpy) Intercept(e []byte) {
 	}
 
 	re := regexp.MustCompile(`"EventType":"hot_ranges_stats"`)
-	if entry.Channel != logpb.Channel_OPS || !re.MatchString(entry.Message) {
+	if entry.Channel != logpb.Channel_HEALTH || !re.MatchString(entry.Message) {
 		return
 	}
 

pkg/util/log/eventpb/cluster_events.proto

@@ -202,50 +202,3 @@ message TenantSharedServiceStop {
 
   CommonSharedServiceEventDetails shared = 2 [(gogoproto.nullable) = false, (gogoproto.jsontag) = "", (gogoproto.embed) = true];
 }
-
-// HotRangesStats
-message HotRangesStats {
-  CommonEventDetails common = 1 [(gogoproto.nullable) = false, (gogoproto.jsontag) = "", (gogoproto.embed) = true];
-
-  int64 range_id = 2 [(gogoproto.jsontag) = ",omitempty", (gogoproto.customname) = "RangeID"];
-
-  double qps = 3 [(gogoproto.jsontag) = ",includeempty"];
-
-  // SchemaName is the name of the schema in which the index was created.
-  string schema_name = 7 [(gogoproto.jsontag) = ",omitempty"];
-
-  // LeaseholderNodeID indicates the Node ID that is the current leaseholder for the given range.
-  int32 leaseholder_node_id = 8 [(gogoproto.customname) = "LeaseholderNodeID", (gogoproto.jsontag) = ",omitempty"];
-
-  // Writes per second is the recent number of keys written per second on
-  // this range.
-  double writes_per_second = 9 [(gogoproto.jsontag) = ",omitempty"];
-
-  // Reads per second is the recent number of keys read per second on
-  // this range.
-  double reads_per_second = 10 [(gogoproto.jsontag) = ",omitempty"];
-
-  // Write bytes per second is the recent number of bytes written per second on
-  // this range.
-  double write_bytes_per_second = 11 [(gogoproto.jsontag) = ",omitempty"];
-
-  // Read bytes per second is the recent number of bytes read per second on
-  // this range.
-  double read_bytes_per_second = 12 [(gogoproto.jsontag) = ",omitempty"];
-
-  // CPU time per second is the recent cpu usage in nanoseconds of this range.
-  double cpu_time_per_second = 13 [(gogoproto.customname) = "CPUTimePerSecond", (gogoproto.jsontag) = ",omitempty"];
-
-  // Databases for the range.
-  repeated string databases = 16;
-  // Tables for the range
-  repeated string tables = 17;
-  // Indexes for the range
-  repeated string indexes = 18;
-
-  // previously used for database, table, and index name
-  // syntax reserved 4 to 6 breaks json encoding checks
-  reserved 4;
-  reserved 5;
-  reserved 6;
-}

pkg/util/log/eventpb/eventlog_channels_generated.go

@@ -60,3 +60,50 @@ message RuntimeStats {
   // The bytes sent on all network interfaces since this process started.
   uint64 net_host_send_bytes = 19 [(gogoproto.jsontag) = ",omitempty"];
 }
+
+// HotRangesStats
+message HotRangesStats {
+  CommonEventDetails common = 1 [(gogoproto.nullable) = false, (gogoproto.jsontag) = "", (gogoproto.embed) = true];
+
+  int64 range_id = 2 [(gogoproto.jsontag) = ",omitempty", (gogoproto.customname) = "RangeID"];
+
+  double qps = 3 [(gogoproto.jsontag) = ",includeempty"];
+
+  // SchemaName is the name of the schema in which the index was created.
+  string schema_name = 7 [(gogoproto.jsontag) = ",omitempty"];
+
+  // LeaseholderNodeID indicates the Node ID that is the current leaseholder for the given range.
+  int32 leaseholder_node_id = 8 [(gogoproto.customname) = "LeaseholderNodeID", (gogoproto.jsontag) = ",omitempty"];
+
+  // Writes per second is the recent number of keys written per second on
+  // this range.
+  double writes_per_second = 9 [(gogoproto.jsontag) = ",omitempty"];
+
+  // Reads per second is the recent number of keys read per second on
+  // this range.
+  double reads_per_second = 10 [(gogoproto.jsontag) = ",omitempty"];
+
+  // Write bytes per second is the recent number of bytes written per second on
+  // this range.
+  double write_bytes_per_second = 11 [(gogoproto.jsontag) = ",omitempty"];
+
+  // Read bytes per second is the recent number of bytes read per second on
+  // this range.
+  double read_bytes_per_second = 12 [(gogoproto.jsontag) = ",omitempty"];
+
+  // CPU time per second is the recent cpu usage in nanoseconds of this range.
+  double cpu_time_per_second = 13 [(gogoproto.customname) = "CPUTimePerSecond", (gogoproto.jsontag) = ",omitempty"];
+
+  // Databases for the range.
+  repeated string databases = 16;
+  // Tables for the range
+  repeated string tables = 17;
+  // Indexes for the range
+  repeated string indexes = 18;
+
+  // previously used for database, table, and index name
+  // syntax reserved 4 to 6 breaks json encoding checks
+  reserved 4;
+  reserved 5;
+  reserved 6;
+}