File tree Expand file tree Collapse file tree 1 file changed +8
-6
lines changed
pkg/kv/kvserver/rangefeed Expand file tree Collapse file tree 1 file changed +8
-6
lines changed Original file line number Diff line number Diff line change @@ -50,21 +50,23 @@ import (
50
50
51
51
// RangefeedSingleBufferedSenderQueueMaxSize is the maximum number of events
52
52
// that the buffered sender will buffer before it starts returning capacity
53
- // exceeded errors. Updates to this setting are only applied to need
54
- // MuxRangefeedCalls, existing streams will use the previous value until
53
+ // exceeded errors. Updates to this setting are only applied to new
54
+ // MuxRangefeedCalls. Existing streams will use the previous value until
55
55
// restarted.
56
56
//
57
- // # The main goal of this limit is to provide a backstop against the
58
- //
59
- // The default here has been somewhat arbitrarily chosen considering that:
57
+ // The default here has been arbitrarily chosen. Ideally,
60
58
//
61
59
// - We want to avoid capacity exceeded errors that wouldn't have occurred
62
60
// when the buffered registrations were in use.
63
61
//
64
62
// - We don't want to drastically increase the amount of queueing allowed for a
65
63
// single registration.
66
64
//
67
- // - One buffered sender is feeding a single gRPC client.
65
+ // A small buffer may be justified given that:
66
+ //
67
+ // - One buffered sender is feeding a single gRPC client, so scaling based on
68
+ // registrations doesn't necessarily make sense. If the consumer is behind, it
69
+ // is behind.
68
70
//
69
71
// - Events emitted during catchup scans have their own per-registration buffer
70
72
// still.
You can’t perform that action at this time.
0 commit comments