Skip to content

Commit 530be0d

Browse files
committed
asimview: add mma.png as an icon
1 parent 7b8101c commit 530be0d

File tree

5 files changed

+13
-0
lines changed

5 files changed

+13
-0
lines changed

pkg/kv/kvserver/asim/tests/cmd/asimview/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ go_library(
77
"sha_compare.go",
88
],
99
embedsrcs = [
10+
"mma.png",
1011
"viewer.html",
1112
"sha_compare.html",
1213
],

pkg/kv/kvserver/asim/tests/cmd/asimview/main.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ var viewerHTML string
2828
//go:embed sha_compare.html
2929
var shaCompareHTML string
3030

31+
//go:embed mma.png
32+
var faviconPNG []byte
33+
3134
type FileInfo struct {
3235
Path string `json:"path"`
3336
Name string `json:"name"`
@@ -102,6 +105,7 @@ func mainErr(port int, dir string) error {
102105
http.HandleFunc("/", serveViewer)
103106
http.HandleFunc("/api/files", makeFileListHandler(absDir))
104107
http.HandleFunc("/api/file/", makeFileHandler(absDir))
108+
http.HandleFunc("/favicon.ico", serveFavicon)
105109

106110
return http.ListenAndServe(fmt.Sprintf(":%d", port), nil)
107111
}
@@ -111,6 +115,11 @@ func serveViewer(w http.ResponseWriter, r *http.Request) {
111115
w.Write([]byte(viewerHTML))
112116
}
113117

118+
func serveFavicon(w http.ResponseWriter, r *http.Request) {
119+
w.Header().Set("Content-Type", "image/png")
120+
w.Write(faviconPNG)
121+
}
122+
114123
func makeFileListHandler(baseDir string) http.HandlerFunc {
115124
return func(w http.ResponseWriter, r *http.Request) {
116125
var files []FileInfo
@@ -196,6 +205,7 @@ func setupShaComparisonRoutes() error {
196205
}
197206

198207
http.HandleFunc("/", serveShaCompareViewer)
208+
http.HandleFunc("/favicon.ico", serveFavicon)
199209
http.HandleFunc("/api/sha-comparisons", getShaComparisons)
200210
http.HandleFunc("/api/recent-commits", getRecentCommits)
201211
http.HandleFunc("/api/generate-comparison", generateComparison)
3.73 MB
Loading

pkg/kv/kvserver/asim/tests/cmd/asimview/sha_compare.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
<meta charset="UTF-8">
55
<meta name="viewport" content="width=device-width, initial-scale=1.0">
66
<title>ASIM SHA Comparison Viewer</title>
7+
<link rel="icon" type="image/png" href="/favicon.ico">
78
<script src="https://cdn.plot.ly/plotly-latest.min.js"></script>
89
<style>
910
* { margin: 0; padding: 0; box-sizing: border-box; }

pkg/kv/kvserver/asim/tests/cmd/asimview/viewer.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<head>
44
<meta charset="UTF-8">
55
<title>ASIM Test Results Viewer</title>
6+
<link rel="icon" type="image/png" href="/favicon.ico">
67
<script src="https://cdn.jsdelivr.net/npm/chart.js"></script>
78
<script src="https://cdn.jsdelivr.net/npm/chartjs-plugin-zoom"></script>
89
<style>

0 commit comments

Comments
 (0)