Skip to content

Commit 541b9d3

Browse files
craig[bot]andyyang890bghalsanchit-CRL
committed
153975: changefeedccl: add progress skew metrics r=KeithCh,asg0451 a=andyyang890 This patch adds two new changefeed metrics for tracking the max skew between a changefeed's slowest and fastest span/table. The metrics are gauge metrics with the names `changefeed.progress_skew.{span,table}`. Fixes #153170 Release note (ops change): Two new changefeed metrics for tracking the max skew between a changefeed's slowest and fastest span/table have been added. The metrics are gauge metrics with the names `changefeed.progress_skew.{span,table}`. --- Some example graphs from running `cdc/frontier-persistence-benchmark/interval=5s/tables=10000/ranges=1`: **Per-table tracking off** <img width="2450" height="556" alt="image" src="https://github.com/user-attachments/assets/ac7b6a86-d154-4e15-b37f-b88398185341" /> **Per-table tracking on** <img width="2438" height="564" alt="image" src="https://github.com/user-attachments/assets/cebd5f18-0fcd-43d4-849d-bf42b7256db8" /> 154019: sql: add virtual view for inspect errors r=bghal a=bghal The delegated `SHOW INSPECT ERRORS` (from #153727) will use this virtual view to read the `system.inspect_errors` table which is otherwise restricted to admins. Part of: #148287 Epic: CRDB-30356 Release note: None 154107: oidcccl: Upgrade go-oidc dependency from v2 to v3 r=sanchit-CRL a=sanchit-CRL * go-oidc had a reported CVE from an indirect dependency gopkg.in/square/go-jose.v2-v2.5.1 * Upgrading from v2 to v3 of the go-oidc package resolves the CVE as this indirectly upgrades go-jose from v2 to v4. Epic: CRDB-54547 Co-authored-by: Andy Yang <[email protected]> Co-authored-by: Brendan Gerrity <[email protected]> Co-authored-by: Sanchit Khanna <[email protected]>
4 parents 1c99d43 + 199c371 + be24b40 + 57e191b commit 541b9d3

File tree

30 files changed

+534
-216
lines changed

30 files changed

+534
-216
lines changed

‎DEPS.bzl‎

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2150,10 +2150,20 @@ def go_deps():
21502150
name = "com_github_coreos_go_oidc",
21512151
build_file_proto_mode = "disable_global",
21522152
importpath = "github.com/coreos/go-oidc",
2153-
sha256 = "b997f93fbff8a4aed3bb2d78a3bf115ba4f06b1d1e4b9ef4cc9d1f63d3ce4036",
2154-
strip_prefix = "github.com/coreos/go-oidc@v2.2.1+incompatible",
2153+
sha256 = "e2e123270614dd7d47d95ae1fce80a9102df019f9e820d4f5cf5c92c64e1ad91",
2154+
strip_prefix = "github.com/coreos/go-oidc@v2.1.0+incompatible",
21552155
urls = [
2156-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-oidc/com_github_coreos_go_oidc-v2.2.1+incompatible.zip",
2156+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-oidc/com_github_coreos_go_oidc-v2.1.0+incompatible.zip",
2157+
],
2158+
)
2159+
go_repository(
2160+
name = "com_github_coreos_go_oidc_v3",
2161+
build_file_proto_mode = "disable_global",
2162+
importpath = "github.com/coreos/go-oidc/v3",
2163+
sha256 = "70e7e08dce12ae0feb50c6a6befe9e73ddef046da79f705e0dec449298f6669e",
2164+
strip_prefix = "github.com/coreos/go-oidc/[email protected]",
2165+
urls = [
2166+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-oidc/v3/com_github_coreos_go_oidc_v3-v3.15.0.zip",
21572167
],
21582168
)
21592169
go_repository(
@@ -3237,6 +3247,16 @@ def go_deps():
32373247
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-ini/ini/com_github_go_ini_ini-v1.25.4.zip",
32383248
],
32393249
)
3250+
go_repository(
3251+
name = "com_github_go_jose_go_jose_v4",
3252+
build_file_proto_mode = "disable_global",
3253+
importpath = "github.com/go-jose/go-jose/v4",
3254+
sha256 = "7bb0205c235a4bc2bbca729a08d2d86f31ac0199cfc1c70b2d780f7594366407",
3255+
strip_prefix = "github.com/go-jose/go-jose/[email protected]",
3256+
urls = [
3257+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-jose/go-jose/v4/com_github_go_jose_go_jose_v4-v4.0.5.zip",
3258+
],
3259+
)
32403260
go_repository(
32413261
name = "com_github_go_kit_kit",
32423262
build_file_proto_mode = "disable_global",
@@ -7364,10 +7384,10 @@ def go_deps():
73647384
name = "com_github_pquerna_cachecontrol",
73657385
build_file_proto_mode = "disable_global",
73667386
importpath = "github.com/pquerna/cachecontrol",
7367-
sha256 = "aee5feeaf00551b3448ba6ab0d56314924cbe2aff3eb56257839b528502c4b1a",
7368-
strip_prefix = "github.com/pquerna/[email protected]20200921180117-858c6e7e6b7e",
7387+
sha256 = "d6cc37c2f66b55943c56be5199cf3182b6c6ac6878bba7d7184425e4faf22301",
7388+
strip_prefix = "github.com/pquerna/[email protected]20171018203845-0dec1b30a021",
73697389
urls = [
7370-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/pquerna/cachecontrol/com_github_pquerna_cachecontrol-v0.0.0-20200921180117-858c6e7e6b7e.zip",
7390+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/pquerna/cachecontrol/com_github_pquerna_cachecontrol-v0.0.0-20171018203845-0dec1b30a021.zip",
73717391
],
73727392
)
73737393
go_repository(

‎build/bazelutil/distdir_files.bzl‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,8 @@ DISTDIR_FILES = {
390390
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/bbolt/com_github_coreos_bbolt-v1.3.2.zip": "097e7c6cf2dc9c50a0c8827f451bd3cba44c2cbf086d4fb684f2dfada9bfa841",
391391
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/etcd/com_github_coreos_etcd-v3.3.10+incompatible.zip": "6d4f268491a5e80078b3f80a94a8780c3c04bad50efb371ef10bbc80652ec122",
392392
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-iptables/com_github_coreos_go_iptables-v0.5.0.zip": "07e31b1e6c7dec3e1c22b90b02bb1fe610884ad20ca46d623d949c71b3dcb55f",
393-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-oidc/com_github_coreos_go_oidc-v2.2.1+incompatible.zip": "b997f93fbff8a4aed3bb2d78a3bf115ba4f06b1d1e4b9ef4cc9d1f63d3ce4036",
393+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-oidc/com_github_coreos_go_oidc-v2.1.0+incompatible.zip": "e2e123270614dd7d47d95ae1fce80a9102df019f9e820d4f5cf5c92c64e1ad91",
394+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-oidc/v3/com_github_coreos_go_oidc_v3-v3.15.0.zip": "70e7e08dce12ae0feb50c6a6befe9e73ddef046da79f705e0dec449298f6669e",
394395
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-semver/com_github_coreos_go_semver-v0.3.0.zip": "b2fc075395ffc34cff4b964681d0ae3cd22096cfcadd2970eeaa877596ceb210",
395396
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-systemd/com_github_coreos_go_systemd-v0.0.0-20190719114852-fd7a80b32e1f.zip": "22237f0aed3ab6018a1025c65f4f45b4c05f9aa0c0bb9ec880294273b9a15bf2",
396397
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/coreos/go-systemd/v22/com_github_coreos_go_systemd_v22-v22.3.2.zip": "01134ae89bf4a91c17eeb1f8425e1064f9bde64cf3ce0c9cf546a9fa1ee25e64",
@@ -494,6 +495,7 @@ DISTDIR_FILES = {
494495
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-gl/glfw/com_github_go_gl_glfw-v0.0.0-20190409004039-e6da0acd62b1.zip": "96c694c42e7b866ea8e26dc48b612c4daa8582ce61fdeefbe92c1a4c46163169",
495496
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-gl/glfw/v3.3/glfw/com_github_go_gl_glfw_v3_3_glfw-v0.0.0-20200222043503-6f7a984d4dc4.zip": "2f6a1963397cb7c3df66257a45d75fae860aa9b9eec17825d8101c1e1313da5b",
496497
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-ini/ini/com_github_go_ini_ini-v1.25.4.zip": "2ec52de9f1c96133e9f81b8250fdc99ca0729c0d429e318d7c8836b7a6ba5f60",
498+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-jose/go-jose/v4/com_github_go_jose_go_jose_v4-v4.0.5.zip": "7bb0205c235a4bc2bbca729a08d2d86f31ac0199cfc1c70b2d780f7594366407",
497499
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-kit/kit/com_github_go_kit_kit-v0.10.0.zip": "dbdc933092b036483ca332f8c7c13e8b7d029192e79354d4f5a581ef3c364816",
498500
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-kit/log/com_github_go_kit_log-v0.2.1.zip": "52634b502b9d0aa945833d93582cffc1bdd9bfa39810e7c70d0688e330b75198",
499501
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/go-latex/latex/com_github_go_latex_latex-v0.0.0-20231108140139-5c1ce85aa4ea.zip": "eee17f6b6ac8e1571a29101eab97b1c247fc1109ee3c3c632e38c0fc81e3e753",
@@ -881,7 +883,7 @@ DISTDIR_FILES = {
881883
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/pmezard/go-difflib/com_github_pmezard_go_difflib-v1.0.0.zip": "de04cecc1a4b8d53e4357051026794bcbc54f2e6a260cfac508ce69d5d6457a0",
882884
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/posener/complete/com_github_posener_complete-v1.2.3.zip": "88b48005b995dc6592fa6fda08130488c83f63bcaa4ccb0fb8e926fee63112ec",
883885
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/power-devops/perfstat/com_github_power_devops_perfstat-v0.0.0-20210106213030-5aafc221ea8c.zip": "3ef206586f26201742728d9ae351348179ae94bb8b0c7913aa1cdf0f13e24fd8",
884-
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/pquerna/cachecontrol/com_github_pquerna_cachecontrol-v0.0.0-20200921180117-858c6e7e6b7e.zip": "aee5feeaf00551b3448ba6ab0d56314924cbe2aff3eb56257839b528502c4b1a",
886+
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/pquerna/cachecontrol/com_github_pquerna_cachecontrol-v0.0.0-20171018203845-0dec1b30a021.zip": "d6cc37c2f66b55943c56be5199cf3182b6c6ac6878bba7d7184425e4faf22301",
885887
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/prashantv/protectmem/com_github_prashantv_protectmem-v0.0.0-20171002184600-e20412882b3a.zip": "53d930afbb812eb68b665dcbd96ac371ff600c8821cf5e43628ab283457881e9",
886888
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/prometheus/alertmanager/com_github_prometheus_alertmanager-v0.23.0.zip": "1c51abe35f12ebc11de46e0d888c93fe8e85b146ced1c2ab2a49dd97cf2b1c6a",
887889
"https://storage.googleapis.com/cockroach-godeps/gomod/github.com/prometheus/client_model/com_github_prometheus_client_model-v0.3.0.zip": "2a1d147754959287fc34a7bb7c333b3d6fe0ca0d7db1606c49e8f48fd0311547",

‎docs/generated/metrics/metrics.yaml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,6 +1725,22 @@ layers:
17251725
unit: NANOSECONDS
17261726
aggregation: AVG
17271727
derivative: NONE
1728+
- name: changefeed.progress_skew.span
1729+
exported_name: changefeed_progress_skew_span
1730+
description: The time difference between the fastest and slowest span's resolved timestamp
1731+
y_axis_label: Nanoseconds
1732+
type: GAUGE
1733+
unit: NANOSECONDS
1734+
aggregation: AVG
1735+
derivative: NONE
1736+
- name: changefeed.progress_skew.table
1737+
exported_name: changefeed_progress_skew_table
1738+
description: The time difference between the fastest and slowest table's resolved timestamp
1739+
y_axis_label: Nanoseconds
1740+
type: GAUGE
1741+
unit: NANOSECONDS
1742+
aggregation: AVG
1743+
derivative: NONE
17281744
- name: changefeed.queue_time_nanos
17291745
exported_name: changefeed_queue_time_nanos
17301746
description: Time KV event spent waiting to be processed

‎go.mod‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ require (
152152
github.com/cockroachdb/version v0.0.0-20250509181251-54dac3003410
153153
github.com/codahale/hdrhistogram v0.0.0-20161010025455-3a0bb77429bd
154154
github.com/containerd/containerd v1.6.18
155-
github.com/coreos/go-oidc v2.2.1+incompatible
155+
github.com/coreos/go-oidc/v3 v3.15.0
156156
github.com/dave/dst v0.24.0
157157
github.com/davecgh/go-spew v1.1.1
158158
github.com/docker/distribution v2.7.1+incompatible
@@ -335,6 +335,7 @@ require (
335335
github.com/ghodss/yaml v1.0.0 // indirect
336336
github.com/go-asn1-ber/asn1-ber v1.5.5 // indirect
337337
github.com/go-fonts/liberation v0.3.2 // indirect
338+
github.com/go-jose/go-jose/v4 v4.0.5 // indirect
338339
github.com/go-kit/log v0.2.1 // indirect
339340
github.com/go-latex/latex v0.0.0-20231108140139-5c1ce85aa4ea // indirect
340341
github.com/go-logfmt/logfmt v0.5.1 // indirect
@@ -429,7 +430,6 @@ require (
429430
github.com/pierrec/lz4 v2.5.2+incompatible // indirect
430431
github.com/pkg/profile v1.6.0 // indirect
431432
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect
432-
github.com/pquerna/cachecontrol v0.0.0-20200921180117-858c6e7e6b7e // indirect
433433
github.com/prometheus/procfs v0.10.1 // indirect
434434
github.com/pseudomuto/protokit v0.2.0 // indirect
435435
github.com/rivo/uniseg v0.2.0 // indirect
@@ -468,7 +468,6 @@ require (
468468
google.golang.org/appengine v1.6.7 // indirect
469469
google.golang.org/genproto/googleapis/bytestream v0.0.0-20230525234009-2805bf891e89 // indirect
470470
google.golang.org/genproto/googleapis/rpc v0.0.0-20230525234030-28d5490b6b19 // indirect
471-
gopkg.in/square/go-jose.v2 v2.5.1 // indirect
472471
)
473472

474473
require (

‎go.sum‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -695,8 +695,8 @@ github.com/coreos/etcd v3.3.10+incompatible/go.mod h1:uF7uidLiAD3TWHmW31ZFd/JWoc
695695
github.com/coreos/go-iptables v0.4.5/go.mod h1:/mVI274lEDI2ns62jHCDnCyBF9Iwsmekav8Dbxlm1MU=
696696
github.com/coreos/go-iptables v0.5.0/go.mod h1:/mVI274lEDI2ns62jHCDnCyBF9Iwsmekav8Dbxlm1MU=
697697
github.com/coreos/go-oidc v2.1.0+incompatible/go.mod h1:CgnwVTmzoESiwO9qyAFEMiHoZ1nMCKZlZ9V6mm3/LKc=
698-
github.com/coreos/go-oidc v2.2.1+incompatible h1:mh48q/BqXqgjVHpy2ZY7WnWAbenxRjsz9N1i1YxjHAk=
699-
github.com/coreos/go-oidc v2.2.1+incompatible/go.mod h1:CgnwVTmzoESiwO9qyAFEMiHoZ1nMCKZlZ9V6mm3/LKc=
698+
github.com/coreos/go-oidc/v3 v3.15.0 h1:R6Oz8Z4bqWR7VFQ+sPSvZPQv4x8M+sJkDO5ojgwlyAg=
699+
github.com/coreos/go-oidc/v3 v3.15.0/go.mod h1:HaZ3szPaZ0e4r6ebqvsLWlk2Tn+aejfmrfah6hnSYEU=
700700
github.com/coreos/go-semver v0.2.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk=
701701
github.com/coreos/go-semver v0.3.0/go.mod h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk=
702702
github.com/coreos/go-systemd v0.0.0-20161114122254-48702e0da86b/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=
@@ -904,6 +904,8 @@ github.com/go-gl/glfw v0.0.0-20190409004039-e6da0acd62b1/go.mod h1:vR7hzQXu2zJy9
904904
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20191125211704-12ad95a8df72/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
905905
github.com/go-gl/glfw/v3.3/glfw v0.0.0-20200222043503-6f7a984d4dc4/go.mod h1:tQ2UAYgL5IevRw8kRxooKSPJfGvJ9fJQFa0TUsXzTg8=
906906
github.com/go-ini/ini v1.25.4/go.mod h1:ByCAeIL28uOIIG0E3PJtZPDL8WnHpFKFOtgjp+3Ies8=
907+
github.com/go-jose/go-jose/v4 v4.0.5 h1:M6T8+mKZl/+fNNuFHvGIzDz7BTLQPIounk/b9dw3AaE=
908+
github.com/go-jose/go-jose/v4 v4.0.5/go.mod h1:s3P1lRrkT8igV8D9OjyL4WRyHvjB6a4JSllnOrmmBOA=
907909
github.com/go-kit/kit v0.8.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as=
908910
github.com/go-kit/kit v0.9.0/go.mod h1:xBxKIO96dXMWWy0MnWVtmwkA9/13aqxPnvrjFYMA2as=
909911
github.com/go-kit/kit v0.10.0/go.mod h1:xUsJbQ/Fp4kEt7AFgCuvyX4a71u8h9jB8tj/ORgOZ7o=
@@ -2011,8 +2013,6 @@ github.com/posener/complete v1.2.3/go.mod h1:WZIdtGGp+qx0sLrYKtIRAruyNpv6hFCicSg
20112013
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c h1:ncq/mPwQF4JjgDlrVEn3C11VoGHZN7m8qihwgMEtzYw=
20122014
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c/go.mod h1:OmDBASR4679mdNQnz2pUhc2G8CO2JrUAVFDRBDP/hJE=
20132015
github.com/pquerna/cachecontrol v0.0.0-20171018203845-0dec1b30a021/go.mod h1:prYjPmNq4d1NPVmpShWobRqXY3q7Vp+80DqgxxUrUIA=
2014-
github.com/pquerna/cachecontrol v0.0.0-20200921180117-858c6e7e6b7e h1:BLqxdwZ6j771IpSCRx7s/GJjXHUE00Hmu7/YegCGdzA=
2015-
github.com/pquerna/cachecontrol v0.0.0-20200921180117-858c6e7e6b7e/go.mod h1:hoLfEwdY11HjRfKFH6KqnPsfxlo3BP6bJehpDv8t6sQ=
20162016
github.com/prashantv/protectmem v0.0.0-20171002184600-e20412882b3a/go.mod h1:lzZQ3Noex5pfAy7mkAeCjcBDteYU85uWWnJ/y6gKU8k=
20172017
github.com/prometheus/alertmanager v0.20.0/go.mod h1:9g2i48FAyZW6BtbsnvHtMHQXl2aVtrORKwKVCQ+nbrg=
20182018
github.com/prometheus/alertmanager v0.23.0/go.mod h1:0MLTrjQI8EuVmvykEhcfr/7X0xmaDAZrqMgxIq3OXHk=
@@ -3205,7 +3205,6 @@ gopkg.in/resty.v1 v1.12.0/go.mod h1:mDo4pnntr5jdWRML875a/NmxYqAlA73dVijT2AXvQQo=
32053205
gopkg.in/square/go-jose.v2 v2.2.2/go.mod h1:M9dMgbHiYLoDGQrXy7OpJDJWiKiU//h+vD76mk0e1AI=
32063206
gopkg.in/square/go-jose.v2 v2.3.1/go.mod h1:M9dMgbHiYLoDGQrXy7OpJDJWiKiU//h+vD76mk0e1AI=
32073207
gopkg.in/square/go-jose.v2 v2.4.1/go.mod h1:M9dMgbHiYLoDGQrXy7OpJDJWiKiU//h+vD76mk0e1AI=
3208-
gopkg.in/square/go-jose.v2 v2.5.1 h1:7odma5RETjNHWJnR32wx8t+Io4djHE1PqxCFx3iiZ2w=
32093208
gopkg.in/square/go-jose.v2 v2.5.1/go.mod h1:M9dMgbHiYLoDGQrXy7OpJDJWiKiU//h+vD76mk0e1AI=
32103209
gopkg.in/src-d/go-billy.v4 v4.3.0/go.mod h1:tm33zBoOwxjYHZIE+OV8bxTWFMJLrconzFMd38aARFk=
32113210
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=

‎pkg/ccl/changefeedccl/changefeed_processors.go‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1736,6 +1736,8 @@ func (cf *changeFrontier) noteAggregatorProgress(ctx context.Context, d rowenc.E
17361736
}
17371737
}
17381738

1739+
cf.updateProgressSkewMetrics()
1740+
17391741
return nil
17401742
}
17411743

@@ -2263,6 +2265,20 @@ func (cf *changeFrontier) maybeEmitResolved(ctx context.Context, newResolved hlc
22632265
return nil
22642266
}
22652267

2268+
// updateProgressSkewMetrics updates the progress skew metrics.
2269+
func (cf *changeFrontier) updateProgressSkewMetrics() {
2270+
maxSpanTS := cf.frontier.LatestTS()
2271+
maxTableTS := cf.frontier.Frontier()
2272+
for _, f := range cf.frontier.Frontiers() {
2273+
tableTS := f.Frontier()
2274+
if tableTS.After(maxTableTS) {
2275+
maxTableTS = tableTS
2276+
}
2277+
}
2278+
2279+
cf.sliMetrics.setFastestTS(cf.sliMetricsID, maxSpanTS, maxTableTS)
2280+
}
2281+
22662282
func frontierIsBehind(frontier hlc.Timestamp, sv *settings.Values) bool {
22672283
if frontier.IsEmpty() {
22682284
// During backfills we consider ourselves "behind" for the purposes of

0 commit comments

Comments
 (0)